1c/v8-code-style
1
0
Fork 0
mirror of https://github.com/1C-Company/v8-code-style.git synced 2025-02-22 00:13:11 +02:00
Code Issues Releases Activity

#398 Исправление кода проверки

Browse Source
This commit is contained in:
Vadim Goncharov 2023-03-26 18:42:15 +03:00
parent 020df79acc
commit afd26f3180
1 changed files with 9 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/UseGotoOperatorCheck.java
View File

@ -13,14 +13,13 @@
package com.e1c.v8codestyle.bsl.check;
import static com._1c.g5.v8.dt.bsl.model.BslPackage.Literals.BLOCK;
import static com._1c.g5.v8.dt.bsl.model.BslPackage.Literals.GOTO_STATEMENT;
import static com._1c.g5.v8.dt.bsl.model.BslPackage.Literals.LABELED_STATEMENT;
import org.eclipse.core.runtime.IProgressMonitor;
import com._1c.g5.v8.dt.bsl.model.Block;
import com._1c.g5.v8.dt.bsl.model.GotoStatement;
import com._1c.g5.v8.dt.bsl.model.LabeledStatement;
import com._1c.g5.v8.dt.bsl.model.Statement;
import com.e1c.g5.v8.dt.check.CheckComplexity;
import com.e1c.g5.v8.dt.check.ICheckParameters;
import com.e1c.g5.v8.dt.check.components.BasicCheck;
@ -60,34 +59,21 @@ public class UseGotoOperatorCheck
.issueType(IssueType.CODE_STYLE)
.extension(new StandardCheckExtension(547, getCheckId(), BslPlugin.PLUGIN_ID))
.module()
.checkedObjectType(BLOCK);
.checkedObjectType(GOTO_STATEMENT, LABELED_STATEMENT);
}
@Override
protected void check(Object object, ResultAcceptor resultAcceptor, ICheckParameters parameters,
IProgressMonitor monitor)
{
Block block = (Block)object;
for (Statement st : block.allStatements())
if (object instanceof GotoStatement)
{
if (monitor.isCanceled())
{
return;
}
if (st instanceof GotoStatement)
{
resultAcceptor.addIssue(Messages.UseGotoOperatorCheck_Use_Goto_operator, st);
}
if (st instanceof LabeledStatement)
{
resultAcceptor.addIssue(Messages.UseGotoOperatorCheck_Use_Label_with_Goto_operator, st);
}
resultAcceptor.addIssue(Messages.UseGotoOperatorCheck_Use_Goto_operator, object);
}
else if (object instanceof LabeledStatement)
{
resultAcceptor.addIssue(Messages.UseGotoOperatorCheck_Use_Label_with_Goto_operator, object);
}
}
}