1c/v8-code-style
1
0
Fork 0
mirror of https://github.com/1C-Company/v8-code-style.git synced 2025-07-16 12:44:15 +02:00
Code Issues Releases Activity

Проверка исключена из настроек

Browse Source
This commit is contained in:
Artem Iliukhin
2024-02-09 10:47:53 +03:00
parent 1d3e0b5a6c
commit e737abb7b9
2 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/RedundantExportMethodCheck.java
View File

@ -12,7 +12,6 @@
*******************************************************************************/ *******************************************************************************/
package com.e1c.v8codestyle.bsl.check; package com.e1c.v8codestyle.bsl.check;
import static com._1c.g5.v8.dt.bsl.model.BslPackage.Literals.METHOD;
import static org.eclipse.xtext.resource.impl.ResourceDescriptionsProvider.PERSISTED_DESCRIPTIONS; import static org.eclipse.xtext.resource.impl.ResourceDescriptionsProvider.PERSISTED_DESCRIPTIONS;
import java.text.MessageFormat; import java.text.MessageFormat;
@ -54,10 +53,7 @@ import com._1c.g5.v8.dt.bsl.model.StringLiteral;
import com._1c.g5.v8.dt.common.StringUtils; import com._1c.g5.v8.dt.common.StringUtils;
import com._1c.g5.v8.dt.mcore.util.McoreUtil; import com._1c.g5.v8.dt.mcore.util.McoreUtil;
import com._1c.g5.v8.dt.metadata.mdclass.MdClassPackage; import com._1c.g5.v8.dt.metadata.mdclass.MdClassPackage;
import com.e1c.g5.v8.dt.check.CheckComplexity;
import com.e1c.g5.v8.dt.check.ICheckParameters; import com.e1c.g5.v8.dt.check.ICheckParameters;
import com.e1c.g5.v8.dt.check.settings.IssueSeverity;
import com.e1c.g5.v8.dt.check.settings.IssueType;
import com.e1c.v8codestyle.bsl.ModuleStructureSection; import com.e1c.v8codestyle.bsl.ModuleStructureSection;
import com.google.inject.Inject; import com.google.inject.Inject;
@ -114,7 +110,8 @@ public final class RedundantExportMethodCheck
@Override @Override
protected void configureCheck(CheckConfigurer builder) protected void configureCheck(CheckConfigurer builder)
{ {
builder.title(Messages.RedundantExportCheck_Escess_title) //TODO Переделать реализацию проверки в рамках задачи #314
/* builder.title(Messages.RedundantExportCheck_Escess_title)
.description(Messages.RedundantExportCheck_Excess_description) .description(Messages.RedundantExportCheck_Excess_description)
.complexity(CheckComplexity.NORMAL) .complexity(CheckComplexity.NORMAL)
.severity(IssueSeverity.MINOR) .severity(IssueSeverity.MINOR)
@ -122,11 +119,10 @@ public final class RedundantExportMethodCheck
.disable() .disable()
.extension(ModuleTypeFilter.onlyTypes(ModuleType.MANAGER_MODULE, ModuleType.COMMON_MODULE, .extension(ModuleTypeFilter.onlyTypes(ModuleType.MANAGER_MODULE, ModuleType.COMMON_MODULE,
ModuleType.OBJECT_MODULE)) ModuleType.OBJECT_MODULE))
//.extension(new StandardCheckExtension(getCheckId(), BslPlugin.PLUGIN_ID))
.module() .module()
.checkedObjectType(METHOD) .checkedObjectType(METHOD)
.parameter(PARAMETER_EXCLUDE_REGION_LIST, String.class, DEFAULT_EXCLUDE_REGION_NAME_LIST, .parameter(PARAMETER_EXCLUDE_REGION_LIST, String.class, DEFAULT_EXCLUDE_REGION_NAME_LIST,
Messages.RedundantExportCheck_Exclude_title); Messages.RedundantExportCheck_Exclude_title);*/
} }

9
tests/com.e1c.v8codestyle.bsl.itests/src/com/e1c/v8codestyle/bsl/check/itests/RedundantExportMethodCheckTest.java
View File

@ -18,6 +18,7 @@ import java.util.List;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import org.eclipse.core.runtime.Path; import org.eclipse.core.runtime.Path;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import com._1c.g5.v8.dt.validation.marker.IExtraInfoKeys; import com._1c.g5.v8.dt.validation.marker.IExtraInfoKeys;
@ -51,6 +52,7 @@ public class RedundantExportMethodCheckTest
return PROJECT_NAME; return PROJECT_NAME;
} }
@Ignore
@Test @Test
public void testNoCallNoPublic() throws Exception public void testNoCallNoPublic() throws Exception
{ {
@ -60,6 +62,7 @@ public class RedundantExportMethodCheckTest
assertEquals("1", markers.get(0).getExtraInfo().get(IExtraInfoKeys.TEXT_EXTRA_INFO_LINE_KEY)); assertEquals("1", markers.get(0).getExtraInfo().get(IExtraInfoKeys.TEXT_EXTRA_INFO_LINE_KEY));
} }
@Ignore
@Test @Test
public void testNoCallPublic() throws Exception public void testNoCallPublic() throws Exception
{ {
@ -67,6 +70,7 @@ public class RedundantExportMethodCheckTest
assertEquals(0, markers.size()); assertEquals(0, markers.size());
} }
@Ignore
@Test @Test
public void testCallNoPublic() throws Exception public void testCallNoPublic() throws Exception
{ {
@ -74,6 +78,7 @@ public class RedundantExportMethodCheckTest
assertEquals(0, markers.size()); assertEquals(0, markers.size());
} }
@Ignore
@Test @Test
public void testLocalCall() throws Exception public void testLocalCall() throws Exception
{ {
@ -83,6 +88,7 @@ public class RedundantExportMethodCheckTest
assertEquals("2", markers.get(0).getExtraInfo().get(IExtraInfoKeys.TEXT_EXTRA_INFO_LINE_KEY)); assertEquals("2", markers.get(0).getExtraInfo().get(IExtraInfoKeys.TEXT_EXTRA_INFO_LINE_KEY));
} }
@Ignore
@Test @Test
public void testNotifyCall() throws Exception public void testNotifyCall() throws Exception
{ {
@ -90,6 +96,7 @@ public class RedundantExportMethodCheckTest
assertEquals(0, markers.size()); assertEquals(0, markers.size());
} }
@Ignore
@Test @Test
public void testNotifyWithRegionCall() throws Exception public void testNotifyWithRegionCall() throws Exception
{ {
@ -97,6 +104,7 @@ public class RedundantExportMethodCheckTest
assertEquals(0, markers.size()); assertEquals(0, markers.size());
} }
@Ignore
@Test @Test
public void testEventSubscription() throws Exception public void testEventSubscription() throws Exception
{ {
@ -104,6 +112,7 @@ public class RedundantExportMethodCheckTest
assertEquals(0, markers.size()); assertEquals(0, markers.size());
} }
@Ignore
@Test @Test
public void testScheduledJob() throws Exception public void testScheduledJob() throws Exception
{ {