From 0586b12fe4864f674f3145646177f0f3b6ca435d Mon Sep 17 00:00:00 2001 From: Hubert depesz Lubaczewski Date: Tue, 24 Sep 2024 17:20:55 +0200 Subject: [PATCH] Fix mistake in links generated from hints per report from sheng yan --- templates/controller/show.html.ep | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/templates/controller/show.html.ep b/templates/controller/show.html.ep index cc10d9d..443b4e5 100755 --- a/templates/controller/show.html.ep +++ b/templates/controller/show.html.ep @@ -857,7 +857,7 @@ % my $node_num = $explain_node_id_to_table_node_id->{ $hint->node->id };
  • % if ( $hint->type eq 'DISK_SORT' ) { -

    You have sort node (#<%= $node_num %>) that is using disk space to sort.

    +

    You have sort node (#<%= $node_num %>) that is using disk space to sort.

    This is because your work_mem setting is too low.

    Increasing it can make the sort run in memory, or, at least, use less of disk. Sort used <%= $hint->details->[0] %>kB, so you would need to set your work_mem to at least that much to have a chance at sorting in memory only.

    % } elsif ( $hint->type eq 'INDEXABLE_SEQSCAN_SIMPLE' ) { @@ -866,7 +866,7 @@ % my $operator = $hint->details->[1]; % my $fetched_rows = $hint->node->total_rows + $hint->node->total_rows_removed; % my $dropped_rows = $hint->node->total_rows_removed; -

    You have <%= $hint->node->type %> (#<%= $node_num %>) that could use an index.

    +

    You have <%= $hint->node->type %> (#<%= $node_num %>) that could use an index.

    This node searches in table <%= $table_name %> using <%= $operator %> operator on column <%= $column_name %>. In process it fetches from disk <%= commify_number( $fetched_rows ) %> rows, just to drop % if ( $fetched_rows == $dropped_rows ) { all @@ -881,7 +881,7 @@ % my @columns = map { $_->{'column'} } @{ $hint->details }; % my $fetched_rows = $hint->node->total_rows + $hint->node->total_rows_removed; % my $dropped_rows = $hint->node->total_rows_removed; -

    You have <%= $hint->node->type %> (#<%= $node_num %>) that could use an index.

    +

    You have <%= $hint->node->type %> (#<%= $node_num %>) that could use an index.

    This node searches in table <%= $table_name %> using many comparisons using = operator, on columns: % for my $column_no ( 0 .. $#columns ) { % if ($column_no == $#columns ) {