db/pg_probackup
1
0
Fork 0
mirror of https://github.com/postgrespro/pg_probackup.git synced 2025-09-16 09:26:30 +02:00
Code Issues Releases Activity

[PBCKP-354] Pg15: continue reading if error "missing contrecord" is met.

Browse Source 
Pg15 now reports if it didn't met expected contrecord. Absence of this
message was long standing bug in previous postgres versions.

This situation could happen if WAL segment was rewritten after restart.

It causes "tests.validate.ValidateTest.test_validate_wal_unreal_values"
to hang but (looks like) for other reason: test tries to read "in future".

Probably we should stop reading logs here. But since we always did
continue here, lets continue as well.
This commit is contained in:
Yura Sokolov
2022-11-29 11:12:20 +03:00
parent 8f20e7eb58
commit 15a5c5dad7
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/parsexlog.c
View File

@@ -1443,7 +1443,14 @@ XLogThreadWorker(void *arg)
* Usually SimpleXLogPageRead() does it by itself. But here we need
* to do it manually to support threads.
*/
if (reader_data->need_switch && errormsg == NULL)
if (reader_data->need_switch && (
errormsg == NULL ||
/*
* Pg15 now informs if "contrecord" is missing.
* TODO: probably we should abort reading logs at this moment.
* But we continue as we did with bug present in Pg < 15.
*/
strncmp(errormsg, "missing contrecord", 18) == 0))
{
if (SwitchThreadToNextWal(xlogreader, thread_arg))
continue;