db/pg_probackup
db/pg_probackup
1
0
Fork 0
mirror of https://github.com/postgrespro/pg_probackup.git synced 2024-12-11 11:41:33 +02:00
Code Issues Releases Activity

bugfix: do not check page layout version, it may give false-positive result

Browse Source
This commit is contained in:
Grigory Smolkin 2019-04-19 11:36:04 +03:00
parent cd6b175301
commit 45e05ba126
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/data.c
View File

@ -139,7 +139,7 @@ page_may_be_compressed(Page page, CompressAlg alg, uint32 backup_version)
/* First check if page header is valid (it seems to be fast enough check) */ /* First check if page header is valid (it seems to be fast enough check) */
if (!(PageGetPageSize(phdr) == BLCKSZ && if (!(PageGetPageSize(phdr) == BLCKSZ &&
PageGetPageLayoutVersion(phdr) == PG_PAGE_LAYOUT_VERSION && // PageGetPageLayoutVersion(phdr) == PG_PAGE_LAYOUT_VERSION &&
(phdr->pd_flags & ~PD_VALID_FLAG_BITS) == 0 && (phdr->pd_flags & ~PD_VALID_FLAG_BITS) == 0 &&
phdr->pd_lower >= SizeOfPageHeaderData && phdr->pd_lower >= SizeOfPageHeaderData &&
phdr->pd_lower <= phdr->pd_upper && phdr->pd_lower <= phdr->pd_upper &&
@ -178,7 +178,7 @@ parse_page(Page page, XLogRecPtr *lsn)
*lsn = PageXLogRecPtrGet(phdr->pd_lsn); *lsn = PageXLogRecPtrGet(phdr->pd_lsn);
if (PageGetPageSize(phdr) == BLCKSZ && if (PageGetPageSize(phdr) == BLCKSZ &&
PageGetPageLayoutVersion(phdr) == PG_PAGE_LAYOUT_VERSION && // PageGetPageLayoutVersion(phdr) == PG_PAGE_LAYOUT_VERSION &&
(phdr->pd_flags & ~PD_VALID_FLAG_BITS) == 0 && (phdr->pd_flags & ~PD_VALID_FLAG_BITS) == 0 &&
phdr->pd_lower >= SizeOfPageHeaderData && phdr->pd_lower >= SizeOfPageHeaderData &&
phdr->pd_lower <= phdr->pd_upper && phdr->pd_lower <= phdr->pd_upper &&
@ -1527,7 +1527,7 @@ validate_one_page(Page page, pgFile *file,
* TODO: We should give more information about what exactly is looking "wrong" * TODO: We should give more information about what exactly is looking "wrong"
*/ */
if (!(PageGetPageSize(phdr) == BLCKSZ && if (!(PageGetPageSize(phdr) == BLCKSZ &&
PageGetPageLayoutVersion(phdr) == PG_PAGE_LAYOUT_VERSION && // PageGetPageLayoutVersion(phdr) == PG_PAGE_LAYOUT_VERSION &&
(phdr->pd_flags & ~PD_VALID_FLAG_BITS) == 0 && (phdr->pd_flags & ~PD_VALID_FLAG_BITS) == 0 &&
phdr->pd_lower >= SizeOfPageHeaderData && phdr->pd_lower >= SizeOfPageHeaderData &&
phdr->pd_lower <= phdr->pd_upper && phdr->pd_lower <= phdr->pd_upper &&