db/pg_probackup
db/pg_probackup
1
0
Fork 0
mirror of https://github.com/postgrespro/pg_probackup.git synced 2024-12-04 10:44:46 +02:00
Code Issues Releases Activity

PGPRO-427: Add lock for datapagemap_add

Browse Source
This commit is contained in:
Arthur Zakirov 2018-05-29 18:44:08 +03:00
parent 70257b371f
commit a3b9d1ebbb
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/backup.c
View File

@ -46,6 +46,9 @@ const char *progname = "pg_probackup";
/* list of files contained in backup */ /* list of files contained in backup */
static parray *backup_files_list = NULL; static parray *backup_files_list = NULL;
/* We need critical section for datapagemap_add() in case of using threads */
static pthread_mutex_t backup_pagemap_mutex = PTHREAD_MUTEX_INITIALIZER;
/* /*
* We need to wait end of WAL streaming before execute pg_stop_backup(). * We need to wait end of WAL streaming before execute pg_stop_backup().
*/ */
@ -2333,8 +2336,17 @@ process_block_change(ForkNumber forknum, RelFileNode rnode, BlockNumber blkno)
* backup would simply copy it as-is. * backup would simply copy it as-is.
*/ */
if (file_item) if (file_item)
{
/* We need critical section only we use more than one threads */
if (num_threads > 1)
pthread_mutex_lock(&backup_pagemap_mutex);
datapagemap_add(&(*file_item)->pagemap, blkno_inseg); datapagemap_add(&(*file_item)->pagemap, blkno_inseg);
if (num_threads > 1)
pthread_mutex_unlock(&backup_pagemap_mutex);
}
pg_free(path); pg_free(path);
} }