db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-07-07 00:35:37 +02:00
Code Issues Releases Activity
Files
22aa532be1be83c5b1df8db5fa85047e1255a789
pgbackrest/test/src/module/command/infoTest.c

839 lines
41 KiB
C
Raw Normal View History

Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
/***********************************************************************************************************************************
Test Info Command
***********************************************************************************************************************************/
Simplify storage object names. Remove "File" and "Driver" from object names so they are shorter and easier to keep consistent. Also remove the "driver" directory so storage implementations are visible directly under "storage".
2019-05-03 15:46:15 -04:00
#include "storage/posix/storage.h"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
#include "common/harnessConfig.h"
Add harnessInfoChecksum/Z() to ease creation of test info files.
2019-04-23 14:02:30 -04:00
#include "common/harnessInfo.h"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
/***********************************************************************************************************************************
Test Run
***********************************************************************************************************************************/
void
testRun(void)
{
FUNCTION_HARNESS_VOID();
// Create the repo directories
String *repoPath = strNewFmt("%s/repo", testPath());
String *archivePath = strNewFmt("%s/%s", strPtr(repoPath), "archive");
String *backupPath = strNewFmt("%s/%s", strPtr(repoPath), "backup");
String *archiveStanza1Path = strNewFmt("%s/stanza1", strPtr(archivePath));
String *backupStanza1Path = strNewFmt("%s/stanza1", strPtr(backupPath));
// *****************************************************************************************************************************
if (testBegin("infoRender()"))
{
StringList *argList = strLstNew();
strLstAddZ(argList, "pgbackrest");
Fix issues when a path option is / terminated. This condition was not being properly checked for in the C code and it caused problems in the info command, at the very least. Instead of applying a local fix, introduce a new path option type that will rigorously check the format of any incoming paths. Reported by Marc Cousin.
2019-03-14 13:48:33 +04:00
strLstAdd(argList, strNewFmt("--repo-path=%s/", strPtr(repoPath)));
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
strLstAddZ(argList, "info");
StringList *argListText = strLstDup(argList);
strLstAddZ(argList, "--output=json");
harnessCfgLoad(strLstSize(argList), strLstPtr(argList));
// No stanzas have been created
//--------------------------------------------------------------------------------------------------------------------------
TEST_RESULT_STR(strPtr(infoRender()), "[]\n", "json - repo but no stanzas");
harnessCfgLoad(strLstSize(argListText), strLstPtr(argListText));
Simplify info command text message when no stanza are present. Replace the repository path with just "the repository". The path is not important in this context and it is clearer to state where the stanzas are missing from.
2019-01-16 19:23:10 +02:00
TEST_RESULT_STR(strPtr(infoRender()), "No stanzas exist in the repository.\n", "text - no stanzas");
Make the C version of the info command conform to the Perl version. There were some small differences in ordering and how the C version handled missing directories. It may be that the C version is more consistent, but for now it is more important to be compatible with the Perl version. These differences were missed because the C info command was not wired into main.c so it was not being tested in regression. This commit does not fix the wiring issue because there will likely be a release soon and it is too big a change to put in at the last moment.
2019-01-13 22:44:58 +02:00
storagePathCreateNP(storageLocalWrite(), archivePath);
storagePathCreateNP(storageLocalWrite(), backupPath);
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
// Empty stanza
//--------------------------------------------------------------------------------------------------------------------------
TEST_RESULT_VOID(storagePathCreateNP(storageLocalWrite(), backupStanza1Path), "backup stanza1 directory");
TEST_RESULT_VOID(storagePathCreateNP(storageLocalWrite(), archiveStanza1Path), "archive stanza1 directory");
TEST_RESULT_STR(strPtr(infoRender()),
"stanza: stanza1\n"
" status: error (missing stanza data)\n"
" cipher: none\n", "text - missing stanza data");
harnessCfgLoad(strLstSize(argList), strLstPtr(argList));
TEST_RESULT_STR(strPtr(infoRender()),
"[\n"
" {\n"
" \"archive\" : [],\n"
" \"backup\" : [],\n"
" \"cipher\" : \"none\",\n"
" \"db\" : [],\n"
" \"name\" : \"stanza1\",\n"
" \"status\" : {\n"
" \"code\" : 3,\n"
" \"message\" : \"missing stanza data\"\n"
" }\n"
" }\n"
"]\n", "json - missing stanza data");
// backup.info file exists, but archive.info does not
//--------------------------------------------------------------------------------------------------------------------------
String *content = strNew
(
Fix difference in cipher type reporting missed in 8304d452. The C code can't get the cipher type from the storage object because the C storage object does not have encryption baked in like the Perl code does. Instead, check backup.info to see if encryption is enabled. This will need to rethought if another cipher type is added but for now it works fine.
2019-01-16 22:16:50 +02:00
"[cipher]\n"
Add separate functions to encode/decode each JSON type. In most cases the JSON type is known so this is more efficient than converting to Variant first, both in terms of memory and time. Also rename some of the existing functions for consistency.
2019-04-22 18:41:01 -04:00
"cipher-pass=\"12345\"\n"
Fix difference in cipher type reporting missed in 8304d452. The C code can't get the cipher type from the storage object because the C storage object does not have encryption baked in like the Perl code does. Instead, check backup.info to see if encryption is enabled. This will need to rethought if another cipher type is added but for now it works fine.
2019-01-16 22:16:50 +02:00
"\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
"[db]\n"
"db-catalog-version=201409291\n"
"db-control-version=942\n"
"db-id=2\n"
"db-system-id=6569239123849665679\n"
"db-version=\"9.4\"\n"
"\n"
"[db:history]\n"
"1={\"db-catalog-version\":201306121,\"db-control-version\":937,\"db-system-id\":6569239123849665666,"
"\"db-version\":\"9.3\"}\n"
"2={\"db-catalog-version\":201409291,\"db-control-version\":942,\"db-system-id\":6569239123849665679,"
"\"db-version\":\"9.4\"}\n"
);
TEST_RESULT_VOID(
storagePutNP(storageNewWriteNP(storageLocalWrite(), strNewFmt("%s/backup.info", strPtr(backupStanza1Path))),
Add harnessInfoChecksum/Z() to ease creation of test info files.
2019-04-23 14:02:30 -04:00
harnessInfoChecksum(content)), "put backup info to file");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
TEST_ERROR_FMT(infoRender(), FileMissingError,
"unable to load info file '%s/archive.info' or '%s/archive.info.copy':\n"
Refactoring path support in the storage module. Not all storage types support paths as a physical thing that must be created/destroyed. Add a feature to determine which drivers use paths and simplify the driver API as much as possible given that knowledge and by implementing as much path logic as possible in the Storage object. Remove the ignoreMissing parameter from pathSync() since it is not used and makes little sense. Create a standard list of error messages for the drivers to use and apply them where the code was modified -- there is plenty of work still to be done here.
2019-05-26 12:41:15 -04:00
"FileMissingError: " STORAGE_ERROR_READ_MISSING "\n"
"FileMissingError: " STORAGE_ERROR_READ_MISSING "\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
"HINT: archive.info cannot be opened but is required to push/get WAL segments.\n"
"HINT: is archive_command configured correctly in postgresql.conf?\n"
"HINT: has a stanza-create been performed?\n"
"HINT: use --no-archive-check to disable archive checks during backup if you have an alternate archiving scheme.",
Refactoring path support in the storage module. Not all storage types support paths as a physical thing that must be created/destroyed. Add a feature to determine which drivers use paths and simplify the driver API as much as possible given that knowledge and by implementing as much path logic as possible in the Storage object. Remove the ignoreMissing parameter from pathSync() since it is not used and makes little sense. Create a standard list of error messages for the drivers to use and apply them where the code was modified -- there is plenty of work still to be done here.
2019-05-26 12:41:15 -04:00
strPtr(archiveStanza1Path), strPtr(archiveStanza1Path),
strPtr(strNewFmt("%s/archive.info", strPtr(archiveStanza1Path))),
strPtr(strNewFmt("%s/archive.info.copy", strPtr(archiveStanza1Path))));
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
// backup.info/archive.info files exist, mismatched db ids, no backup:current section so no valid backups
// Only the current db information from the db:history will be processed.
//--------------------------------------------------------------------------------------------------------------------------
content = strNew
(
"[db]\n"
"db-id=1\n"
"db-system-id=6569239123849665679\n"
"db-version=\"9.4\"\n"
"\n"
"[db:history]\n"
"1={\"db-id\":6569239123849665679,\"db-version\":\"9.4\"}\n"
"2={\"db-id\":6569239123849665666,\"db-version\":\"9.3\"}\n"
"3={\"db-id\":6569239123849665679,\"db-version\":\"9.4\"}\n"
);
TEST_RESULT_VOID(
storagePutNP(storageNewWriteNP(storageLocalWrite(), strNewFmt("%s/archive.info", strPtr(archiveStanza1Path))),
Add harnessInfoChecksum/Z() to ease creation of test info files.
2019-04-23 14:02:30 -04:00
harnessInfoChecksum(content)), "put archive info to file");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
// archive section will cross reference backup db-id 2 to archive db-id 3 but db section will only use the db-ids from
// backup.info
TEST_RESULT_STR(strPtr(infoRender()),
"[\n"
" {\n"
" \"archive\" : [\n"
" {\n"
" \"database\" : {\n"
" \"id\" : 2\n"
" },\n"
" \"id\" : \"9.4-3\",\n"
" \"max\" : null,\n"
" \"min\" : null\n"
" }\n"
" ],\n"
" \"backup\" : [],\n"
Fix difference in cipher type reporting missed in 8304d452. The C code can't get the cipher type from the storage object because the C storage object does not have encryption baked in like the Perl code does. Instead, check backup.info to see if encryption is enabled. This will need to rethought if another cipher type is added but for now it works fine.
2019-01-16 22:16:50 +02:00
" \"cipher\" : \"aes-256-cbc\",\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
" \"db\" : [\n"
" {\n"
" \"id\" : 1,\n"
" \"system-id\" : 6569239123849665666,\n"
" \"version\" : \"9.3\"\n"
Make the C version of the info command conform to the Perl version. There were some small differences in ordering and how the C version handled missing directories. It may be that the C version is more consistent, but for now it is more important to be compatible with the Perl version. These differences were missed because the C info command was not wired into main.c so it was not being tested in regression. This commit does not fix the wiring issue because there will likely be a release soon and it is too big a change to put in at the last moment.
2019-01-13 22:44:58 +02:00
" },\n"
" {\n"
" \"id\" : 2,\n"
" \"system-id\" : 6569239123849665679,\n"
" \"version\" : \"9.4\"\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
" }\n"
" ],\n"
" \"name\" : \"stanza1\",\n"
" \"status\" : {\n"
" \"code\" : 2,\n"
" \"message\" : \"no valid backups\"\n"
" }\n"
" }\n"
"]\n", "json - single stanza, no valid backups");
harnessCfgLoad(strLstSize(argListText), strLstPtr(argListText));
TEST_RESULT_STR(strPtr(infoRender()),
"stanza: stanza1\n"
" status: error (no valid backups)\n"
Fix difference in cipher type reporting missed in 8304d452. The C code can't get the cipher type from the storage object because the C storage object does not have encryption baked in like the Perl code does. Instead, check backup.info to see if encryption is enabled. This will need to rethought if another cipher type is added but for now it works fine.
2019-01-16 22:16:50 +02:00
" cipher: aes-256-cbc\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
"\n"
" db (current)\n"
" wal archive min/max (9.4-3): none present\n",
"text - single stanza, no valid backups");
Fix info command missing WAL min/max when stanza specified. This issue was a result of STORAGE_REPO_PATH prepending an extra stanza when the stanza was specified on the command line. The tests missed this because by some strange coincidence the WAL dirs were empty for each test that specified a stanza. Add new tests to prevent a regression. Fixed by Stefan Fercot.
2019-02-21 12:09:12 +02:00
// Add WAL segments
//--------------------------------------------------------------------------------------------------------------------------
String *archiveDb3 = strNewFmt("%s/9.4-3/0000000100000000", strPtr(archiveStanza1Path));
TEST_RESULT_VOID(storagePathCreateNP(storageLocalWrite(), archiveDb3), "create db3 archive WAL1 directory");
String *archiveDb3Wal = strNewFmt(
"%s/000000010000000000000004-47dff2b7552a9d66e4bae1a762488a6885e7082c.gz", strPtr(archiveDb3));
TEST_RESULT_VOID(storagePutNP(storageNewWriteNP(storageLocalWrite(), archiveDb3Wal), bufNew(0)), "touch WAL3 file");
StringList *argList2 = strLstDup(argListText);
strLstAddZ(argList2, "--stanza=stanza1");
harnessCfgLoad(strLstSize(argList2), strLstPtr(argList2));
TEST_RESULT_STR(strPtr(infoRender()),
"stanza: stanza1\n"
" status: error (no valid backups)\n"
" cipher: aes-256-cbc\n"
"\n"
" db (current)\n"
" wal archive min/max (9.4-3): 000000010000000000000004/000000010000000000000004\n",
"text - single stanza, one wal segment");
TEST_RESULT_VOID(storageRemoveP(storageLocalWrite(), archiveDb3Wal, .errorOnMissing = true), "remove WAL file");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
// Coverage for stanzaStatus branches
//--------------------------------------------------------------------------------------------------------------------------
String *archiveDb1_1 = strNewFmt("%s/9.4-1/0000000100000000", strPtr(archiveStanza1Path));
TEST_RESULT_VOID(storagePathCreateNP(storageLocalWrite(), archiveDb1_1), "create db1 archive WAL1 directory");
TEST_RESULT_INT(system(
strPtr(strNewFmt("touch %s", strPtr(strNewFmt("%s/000000010000000000000002-ac61b8f1ec7b1e6c3eaee9345214595eb7daa9a1.gz",
strPtr(archiveDb1_1)))))), 0, "touch WAL1 file");
TEST_RESULT_INT(system(
strPtr(strNewFmt("touch %s", strPtr(strNewFmt("%s/000000010000000000000003-37dff2b7552a9d66e4bae1a762488a6885e7082c.gz",
strPtr(archiveDb1_1)))))), 0, "touch WAL1 file");
String *archiveDb1_2 = strNewFmt("%s/9.4-1/0000000200000000", strPtr(archiveStanza1Path));
TEST_RESULT_VOID(storagePathCreateNP(storageLocalWrite(), archiveDb1_2), "create db1 archive WAL2 directory");
TEST_RESULT_INT(system(
strPtr(strNewFmt("touch %s", strPtr(strNewFmt("%s/000000020000000000000003-37dff2b7552a9d66e4bae1a762488a6885e7082c.gz",
strPtr(archiveDb1_2)))))), 0, "touch WAL2 file");
String *archiveDb1_3 = strNewFmt("%s/9.4-1/0000000300000000", strPtr(archiveStanza1Path));
TEST_RESULT_VOID(storagePathCreateNP(storageLocalWrite(), archiveDb1_3), "create db1 archive WAL3 directory");
harnessCfgLoad(strLstSize(argList), strLstPtr(argList));
content = strNew
(
"[db]\n"
"db-catalog-version=201409291\n"
"db-control-version=942\n"
"db-id=3\n"
"db-system-id=6569239123849665679\n"
"db-version=\"9.4\"\n"
"\n"
"[backup:current]\n"
"20181116-154756F={\"backrest-format\":5,\"backrest-version\":\"2.04\","
"\"backup-archive-start\":null,\"backup-archive-stop\":null,"
"\"backup-info-repo-size\":3159776,\"backup-info-repo-size-delta\":3159,\"backup-info-size\":26897030,"
"\"backup-info-size-delta\":26897030,\"backup-timestamp-start\":1542383276,\"backup-timestamp-stop\":1542383289,"
"\"backup-type\":\"full\",\"db-id\":1,\"option-archive-check\":true,\"option-archive-copy\":false,"
"\"option-backup-standby\":false,\"option-checksum-page\":true,\"option-compress\":true,\"option-hardlink\":false,"
"\"option-online\":true}\n"
"\n"
"[db:history]\n"
"1={\"db-catalog-version\":201409291,\"db-control-version\":942,\"db-system-id\":6569239123849665679,"
"\"db-version\":\"9.4\"}\n"
"2={\"db-catalog-version\":201306121,\"db-control-version\":937,\"db-system-id\":6569239123849665666,"
"\"db-version\":\"9.3\"}\n"
"3={\"db-catalog-version\":201409291,\"db-control-version\":942,\"db-system-id\":6569239123849665679,"
"\"db-version\":\"9.4\"}\n"
);
TEST_RESULT_VOID(
storagePutNP(storageNewWriteNP(storageLocalWrite(), strNewFmt("%s/backup.info", strPtr(backupStanza1Path))),
Add harnessInfoChecksum/Z() to ease creation of test info files.
2019-04-23 14:02:30 -04:00
harnessInfoChecksum(content)), "put backup info to file");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
TEST_RESULT_STR(strPtr(infoRender()),
"[\n"
" {\n"
" \"archive\" : [\n"
" {\n"
" \"database\" : {\n"
" \"id\" : 1\n"
" },\n"
" \"id\" : \"9.4-1\",\n"
" \"max\" : \"000000020000000000000003\",\n"
" \"min\" : \"000000010000000000000002\"\n"
Make the C version of the info command conform to the Perl version. There were some small differences in ordering and how the C version handled missing directories. It may be that the C version is more consistent, but for now it is more important to be compatible with the Perl version. These differences were missed because the C info command was not wired into main.c so it was not being tested in regression. This commit does not fix the wiring issue because there will likely be a release soon and it is too big a change to put in at the last moment.
2019-01-13 22:44:58 +02:00
" },\n"
" {\n"
" \"database\" : {\n"
" \"id\" : 3\n"
" },\n"
" \"id\" : \"9.4-3\",\n"
" \"max\" : null,\n"
" \"min\" : null\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
" }\n"
" ],\n"
" \"backup\" : [\n"
" {\n"
" \"archive\" : {\n"
" \"start\" : null,\n"
" \"stop\" : null\n"
" },\n"
" \"backrest\" : {\n"
" \"format\" : 5,\n"
" \"version\" : \"2.04\"\n"
" },\n"
" \"database\" : {\n"
" \"id\" : 1\n"
" },\n"
" \"info\" : {\n"
" \"delta\" : 26897030,\n"
" \"repository\" : {\n"
" \"delta\" : 3159,\n"
" \"size\" : 3159776\n"
" },\n"
" \"size\" : 26897030\n"
" },\n"
" \"label\" : \"20181116-154756F\",\n"
" \"prior\" : null,\n"
" \"reference\" : null,\n"
" \"timestamp\" : {\n"
" \"start\" : 1542383276,\n"
" \"stop\" : 1542383289\n"
" },\n"
" \"type\" : \"full\"\n"
" }\n"
" ],\n"
" \"cipher\" : \"none\",\n"
" \"db\" : [\n"
" {\n"
Make the C version of the info command conform to the Perl version. There were some small differences in ordering and how the C version handled missing directories. It may be that the C version is more consistent, but for now it is more important to be compatible with the Perl version. These differences were missed because the C info command was not wired into main.c so it was not being tested in regression. This commit does not fix the wiring issue because there will likely be a release soon and it is too big a change to put in at the last moment.
2019-01-13 22:44:58 +02:00
" \"id\" : 1,\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
" \"system-id\" : 6569239123849665679,\n"
" \"version\" : \"9.4\"\n"
" },\n"
" {\n"
" \"id\" : 2,\n"
" \"system-id\" : 6569239123849665666,\n"
" \"version\" : \"9.3\"\n"
" },\n"
" {\n"
Make the C version of the info command conform to the Perl version. There were some small differences in ordering and how the C version handled missing directories. It may be that the C version is more consistent, but for now it is more important to be compatible with the Perl version. These differences were missed because the C info command was not wired into main.c so it was not being tested in regression. This commit does not fix the wiring issue because there will likely be a release soon and it is too big a change to put in at the last moment.
2019-01-13 22:44:58 +02:00
" \"id\" : 3,\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
" \"system-id\" : 6569239123849665679,\n"
" \"version\" : \"9.4\"\n"
" }\n"
" ],\n"
" \"name\" : \"stanza1\",\n"
" \"status\" : {\n"
" \"code\" : 0,\n"
" \"message\" : \"ok\"\n"
" }\n"
" }\n"
"]\n", "json - single stanza, valid backup, no priors, no archives in latest DB");
harnessCfgLoad(strLstSize(argListText), strLstPtr(argListText));
TEST_RESULT_STR(strPtr(infoRender()),
"stanza: stanza1\n"
" status: ok\n"
" cipher: none\n"
"\n"
" db (prior)\n"
" wal archive min/max (9.4-1): 000000010000000000000002/000000020000000000000003\n"
"\n"
" full backup: 20181116-154756F\n"
" timestamp start/stop: 2018-11-16 15:47:56 / 2018-11-16 15:48:09\n"
" wal start/stop: n/a\n"
" database size: 25.7MB, backup size: 25.7MB\n"
" repository size: 3MB, repository backup size: 3KB\n"
Reorder info command text output so most recent backup is output last. After a stanza-upgrade backups for the old cluster are displayed until they expire. Cluster info was output newest to oldest which meant after an upgrade the most recent backup would no longer be output last. Update the text output ordering so the most recent backup is always output last. Contributed by Cynthia Shang. Suggested by Ryan Lambert.
2018-12-14 18:25:31 -05:00
"\n"
" db (current)\n"
" wal archive min/max (9.4-3): none present\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
,"text - single stanza, valid backup, no priors, no archives in latest DB");
// backup.info/archive.info files exist, backups exist, archives exist
//--------------------------------------------------------------------------------------------------------------------------
content = strNew
(
"[db]\n"
"db-id=2\n"
"db-system-id=6626363367545678089\n"
"db-version=\"9.5\"\n"
"\n"
"[db:history]\n"
"1={\"db-id\":6625592122879095702,\"db-version\":\"9.4\"}\n"
"2={\"db-id\":6626363367545678089,\"db-version\":\"9.5\"}\n"
);
TEST_RESULT_VOID(
storagePutNP(storageNewWriteNP(storageLocalWrite(), strNewFmt("%s/archive.info", strPtr(archiveStanza1Path))),
Add harnessInfoChecksum/Z() to ease creation of test info files.
2019-04-23 14:02:30 -04:00
harnessInfoChecksum(content)), "put archive info to file - stanza1");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
content = strNew
(
"[backup:current]\n"
"20181119-152138F={"
"\"backrest-format\":5,\"backrest-version\":\"2.08dev\","
"\"backup-archive-start\":\"000000010000000000000002\",\"backup-archive-stop\":\"000000010000000000000002\","
"\"backup-info-repo-size\":2369186,\"backup-info-repo-size-delta\":2369186,"
"\"backup-info-size\":20162900,\"backup-info-size-delta\":20162900,"
"\"backup-timestamp-start\":1542640898,\"backup-timestamp-stop\":1542640911,\"backup-type\":\"full\","
"\"db-id\":1,\"option-archive-check\":true,\"option-archive-copy\":false,\"option-backup-standby\":false,"
"\"option-checksum-page\":true,\"option-compress\":true,\"option-hardlink\":false,\"option-online\":true}\n"
"20181119-152138F_20181119-152152D={"
"\"backrest-format\":5,\"backrest-version\":\"2.08dev\",\"backup-archive-start\":\"000000010000000000000003\","
"\"backup-archive-stop\":\"000000010000000000000003\",\"backup-info-repo-size\":2369186,"
"\"backup-info-repo-size-delta\":346,\"backup-info-size\":20162900,\"backup-info-size-delta\":8428,"
"\"backup-prior\":\"20181119-152138F\",\"backup-reference\":[\"20181119-152138F\"],"
"\"backup-timestamp-start\":1542640912,\"backup-timestamp-stop\":1542640915,\"backup-type\":\"diff\","
"\"db-id\":1,\"option-archive-check\":true,\"option-archive-copy\":false,\"option-backup-standby\":false,"
"\"option-checksum-page\":true,\"option-compress\":true,\"option-hardlink\":false,\"option-online\":true}\n"
"20181119-152138F_20181119-152152I={"
"\"backrest-format\":5,\"backrest-version\":\"2.08dev\",\"backup-archive-start\":\"000000010000000000000003\","
"\"backup-info-repo-size\":2369186,"
"\"backup-info-repo-size-delta\":346,\"backup-info-size\":20162900,\"backup-info-size-delta\":8428,"
"\"backup-prior\":\"20181119-152138F_20181119-152152D\","
"\"backup-reference\":[\"20181119-152138F\",\"20181119-152138F_20181119-152152D\"],"
"\"backup-timestamp-start\":1542640912,\"backup-timestamp-stop\":1542640915,\"backup-type\":\"incr\","
"\"db-id\":1,\"option-archive-check\":true,\"option-archive-copy\":false,\"option-backup-standby\":false,"
"\"option-checksum-page\":true,\"option-compress\":true,\"option-hardlink\":false,\"option-online\":true}\n"
"\n"
"[db]\n"
"db-catalog-version=201510051\n"
"db-control-version=942\n"
"db-id=2\n"
"db-system-id=6626363367545678089\n"
"db-version=\"9.5\"\n"
"\n"
"[db:history]\n"
"1={\"db-catalog-version\":201409291,\"db-control-version\":942,\"db-system-id\":6625592122879095702,"
"\"db-version\":\"9.4\"}\n"
"2={\"db-catalog-version\":201510051,\"db-control-version\":942,\"db-system-id\":6626363367545678089,"
"\"db-version\":\"9.5\"}\n"
);
TEST_RESULT_VOID(
storagePutNP(storageNewWriteNP(storageLocalWrite(), strNewFmt("%s/backup.info", strPtr(backupStanza1Path))),
Add harnessInfoChecksum/Z() to ease creation of test info files.
2019-04-23 14:02:30 -04:00
harnessInfoChecksum(content)), "put backup info to file - stanza1");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
String *archiveStanza2Path = strNewFmt("%s/stanza2", strPtr(archivePath));
String *backupStanza2Path = strNewFmt("%s/stanza2", strPtr(backupPath));
TEST_RESULT_VOID(storagePathCreateNP(storageLocalWrite(), backupStanza1Path), "backup stanza2 directory");
TEST_RESULT_VOID(storagePathCreateNP(storageLocalWrite(), archiveStanza1Path), "archive stanza2 directory");
content = strNew
(
"[db]\n"
"db-id=1\n"
"db-system-id=6625633699176220261\n"
"db-version=\"9.4\"\n"
"\n"
"[db:history]\n"
"1={\"db-id\":6625633699176220261,\"db-version\":\"9.4\"}\n"
);
TEST_RESULT_VOID(
storagePutNP(storageNewWriteNP(storageLocalWrite(), strNewFmt("%s/archive.info", strPtr(archiveStanza2Path))),
Add harnessInfoChecksum/Z() to ease creation of test info files.
2019-04-23 14:02:30 -04:00
harnessInfoChecksum(content)), "put archive info to file - stanza2");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
content = strNew
(
"[db]\n"
"db-catalog-version=201409291\n"
"db-control-version=942\n"
"db-id=1\n"
"db-system-id=6625633699176220261\n"
"db-version=\"9.4\"\n"
"\n"
"[db:history]\n"
"1={\"db-catalog-version\":201409291,\"db-control-version\":942,\"db-system-id\":6625633699176220261,"
"\"db-version\":\"9.4\"}\n"
);
TEST_RESULT_VOID(
storagePutNP(storageNewWriteNP(storageLocalWrite(), strNewFmt("%s/backup.info", strPtr(backupStanza2Path))),
Add harnessInfoChecksum/Z() to ease creation of test info files.
2019-04-23 14:02:30 -04:00
harnessInfoChecksum(content)), "put backup info to file - stanza2");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
harnessCfgLoad(strLstSize(argList), strLstPtr(argList));
TEST_RESULT_STR(strPtr(infoRender()),
"[\n"
" {\n"
" \"archive\" : [\n"
" {\n"
" \"database\" : {\n"
" \"id\" : 1\n"
" },\n"
" \"id\" : \"9.4-1\",\n"
" \"max\" : \"000000020000000000000003\",\n"
" \"min\" : \"000000010000000000000002\"\n"
Make the C version of the info command conform to the Perl version. There were some small differences in ordering and how the C version handled missing directories. It may be that the C version is more consistent, but for now it is more important to be compatible with the Perl version. These differences were missed because the C info command was not wired into main.c so it was not being tested in regression. This commit does not fix the wiring issue because there will likely be a release soon and it is too big a change to put in at the last moment.
2019-01-13 22:44:58 +02:00
" },\n"
" {\n"
" \"database\" : {\n"
" \"id\" : 2\n"
" },\n"
" \"id\" : \"9.5-2\",\n"
" \"max\" : null,\n"
" \"min\" : null\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
" }\n"
" ],\n"
" \"backup\" : [\n"
" {\n"
" \"archive\" : {\n"
" \"start\" : \"000000010000000000000002\",\n"
" \"stop\" : \"000000010000000000000002\"\n"
" },\n"
" \"backrest\" : {\n"
" \"format\" : 5,\n"
" \"version\" : \"2.08dev\"\n"
" },\n"
" \"database\" : {\n"
" \"id\" : 1\n"
" },\n"
" \"info\" : {\n"
" \"delta\" : 20162900,\n"
" \"repository\" : {\n"
" \"delta\" : 2369186,\n"
" \"size\" : 2369186\n"
" },\n"
" \"size\" : 20162900\n"
" },\n"
" \"label\" : \"20181119-152138F\",\n"
" \"prior\" : null,\n"
" \"reference\" : null,\n"
" \"timestamp\" : {\n"
" \"start\" : 1542640898,\n"
" \"stop\" : 1542640911\n"
" },\n"
" \"type\" : \"full\"\n"
" },\n"
" {\n"
" \"archive\" : {\n"
" \"start\" : \"000000010000000000000003\",\n"
" \"stop\" : \"000000010000000000000003\"\n"
" },\n"
" \"backrest\" : {\n"
" \"format\" : 5,\n"
" \"version\" : \"2.08dev\"\n"
" },\n"
" \"database\" : {\n"
" \"id\" : 1\n"
" },\n"
" \"info\" : {\n"
" \"delta\" : 8428,\n"
" \"repository\" : {\n"
" \"delta\" : 346,\n"
" \"size\" : 2369186\n"
" },\n"
" \"size\" : 20162900\n"
" },\n"
" \"label\" : \"20181119-152138F_20181119-152152D\",\n"
" \"prior\" : \"20181119-152138F\",\n"
" \"reference\" : [\n"
" \"20181119-152138F\"\n"
" ],\n"
" \"timestamp\" : {\n"
" \"start\" : 1542640912,\n"
" \"stop\" : 1542640915\n"
" },\n"
" \"type\" : \"diff\"\n"
" },\n"
" {\n"
" \"archive\" : {\n"
" \"start\" : \"000000010000000000000003\",\n"
" \"stop\" : null\n"
" },\n"
" \"backrest\" : {\n"
" \"format\" : 5,\n"
" \"version\" : \"2.08dev\"\n"
" },\n"
" \"database\" : {\n"
" \"id\" : 1\n"
" },\n"
" \"info\" : {\n"
" \"delta\" : 8428,\n"
" \"repository\" : {\n"
" \"delta\" : 346,\n"
" \"size\" : 2369186\n"
" },\n"
" \"size\" : 20162900\n"
" },\n"
" \"label\" : \"20181119-152138F_20181119-152152I\",\n"
" \"prior\" : \"20181119-152138F_20181119-152152D\",\n"
" \"reference\" : [\n"
" \"20181119-152138F\",\n"
" \"20181119-152138F_20181119-152152D\"\n"
" ],\n"
" \"timestamp\" : {\n"
" \"start\" : 1542640912,\n"
" \"stop\" : 1542640915\n"
" },\n"
" \"type\" : \"incr\"\n"
" }\n"
" ],\n"
" \"cipher\" : \"none\",\n"
" \"db\" : [\n"
" {\n"
" \"id\" : 1,\n"
" \"system-id\" : 6625592122879095702,\n"
" \"version\" : \"9.4\"\n"
Make the C version of the info command conform to the Perl version. There were some small differences in ordering and how the C version handled missing directories. It may be that the C version is more consistent, but for now it is more important to be compatible with the Perl version. These differences were missed because the C info command was not wired into main.c so it was not being tested in regression. This commit does not fix the wiring issue because there will likely be a release soon and it is too big a change to put in at the last moment.
2019-01-13 22:44:58 +02:00
" },\n"
" {\n"
" \"id\" : 2,\n"
" \"system-id\" : 6626363367545678089,\n"
" \"version\" : \"9.5\"\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
" }\n"
" ],\n"
" \"name\" : \"stanza1\",\n"
" \"status\" : {\n"
" \"code\" : 0,\n"
" \"message\" : \"ok\"\n"
" }\n"
" },\n"
" {\n"
" \"archive\" : [\n"
" {\n"
" \"database\" : {\n"
" \"id\" : 1\n"
" },\n"
" \"id\" : \"9.4-1\",\n"
" \"max\" : null,\n"
" \"min\" : null\n"
" }\n"
" ],\n"
" \"backup\" : [],\n"
" \"cipher\" : \"none\",\n"
" \"db\" : [\n"
" {\n"
" \"id\" : 1,\n"
" \"system-id\" : 6625633699176220261,\n"
" \"version\" : \"9.4\"\n"
" }\n"
" ],\n"
" \"name\" : \"stanza2\",\n"
" \"status\" : {\n"
" \"code\" : 2,\n"
" \"message\" : \"no valid backups\"\n"
" }\n"
" }\n"
"]\n", "json - multiple stanzas, one with valid backups, archives in latest DB");
harnessCfgLoad(strLstSize(argListText), strLstPtr(argListText));
TEST_RESULT_STR(strPtr(infoRender()),
"stanza: stanza1\n"
" status: ok\n"
" cipher: none\n"
"\n"
" db (prior)\n"
" wal archive min/max (9.4-1): 000000010000000000000002/000000020000000000000003\n"
"\n"
" full backup: 20181119-152138F\n"
" timestamp start/stop: 2018-11-19 15:21:38 / 2018-11-19 15:21:51\n"
" wal start/stop: 000000010000000000000002 / 000000010000000000000002\n"
" database size: 19.2MB, backup size: 19.2MB\n"
" repository size: 2.3MB, repository backup size: 2.3MB\n"
"\n"
" diff backup: 20181119-152138F_20181119-152152D\n"
" timestamp start/stop: 2018-11-19 15:21:52 / 2018-11-19 15:21:55\n"
" wal start/stop: 000000010000000000000003 / 000000010000000000000003\n"
" database size: 19.2MB, backup size: 8.2KB\n"
" repository size: 2.3MB, repository backup size: 346B\n"
" backup reference list: 20181119-152138F\n"
"\n"
" incr backup: 20181119-152138F_20181119-152152I\n"
" timestamp start/stop: 2018-11-19 15:21:52 / 2018-11-19 15:21:55\n"
" wal start/stop: n/a\n"
" database size: 19.2MB, backup size: 8.2KB\n"
" repository size: 2.3MB, repository backup size: 346B\n"
" backup reference list: 20181119-152138F, 20181119-152138F_20181119-152152D\n"
"\n"
Reorder info command text output so most recent backup is output last. After a stanza-upgrade backups for the old cluster are displayed until they expire. Cluster info was output newest to oldest which meant after an upgrade the most recent backup would no longer be output last. Update the text output ordering so the most recent backup is always output last. Contributed by Cynthia Shang. Suggested by Ryan Lambert.
2018-12-14 18:25:31 -05:00
" db (current)\n"
" wal archive min/max (9.5-2): none present\n"
"\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
"stanza: stanza2\n"
" status: error (no valid backups)\n"
" cipher: none\n"
"\n"
" db (current)\n"
" wal archive min/max (9.4-1): none present\n"
, "text - multiple stanzas, one with valid backups, archives in latest DB");
// Stanza not found
//--------------------------------------------------------------------------------------------------------------------------
Fix info command missing WAL min/max when stanza specified. This issue was a result of STORAGE_REPO_PATH prepending an extra stanza when the stanza was specified on the command line. The tests missed this because by some strange coincidence the WAL dirs were empty for each test that specified a stanza. Add new tests to prevent a regression. Fixed by Stefan Fercot.
2019-02-21 12:09:12 +02:00
argList2 = strLstDup(argList);
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
strLstAddZ(argList2, "--stanza=silly");
harnessCfgLoad(strLstSize(argList2), strLstPtr(argList2));
TEST_RESULT_STR(strPtr(infoRender()),
"[\n"
" {\n"
" \"backup\" : [],\n"
" \"db\" : [],\n"
" \"name\" : \"silly\",\n"
" \"status\" : {\n"
" \"code\" : 1,\n"
" \"message\" : \"missing stanza path\"\n"
" }\n"
" }\n"
"]\n", "json - missing stanza path");
StringList *argListText2 = strLstDup(argListText);
strLstAddZ(argListText2, "--stanza=silly");
harnessCfgLoad(strLstSize(argListText2), strLstPtr(argListText2));
TEST_RESULT_STR(strPtr(infoRender()),
"stanza: silly\n"
" status: error (missing stanza path)\n"
, "text - missing stanza path");
// Stanza found
//--------------------------------------------------------------------------------------------------------------------------
strLstAddZ(argList, "--stanza=stanza2");
harnessCfgLoad(strLstSize(argList), strLstPtr(argList));
TEST_RESULT_STR(strPtr(infoRender()),
"[\n"
" {\n"
" \"archive\" : [\n"
" {\n"
" \"database\" : {\n"
" \"id\" : 1\n"
" },\n"
" \"id\" : \"9.4-1\",\n"
" \"max\" : null,\n"
" \"min\" : null\n"
" }\n"
" ],\n"
" \"backup\" : [],\n"
" \"cipher\" : \"none\",\n"
" \"db\" : [\n"
" {\n"
" \"id\" : 1,\n"
" \"system-id\" : 6625633699176220261,\n"
" \"version\" : \"9.4\"\n"
" }\n"
" ],\n"
" \"name\" : \"stanza2\",\n"
" \"status\" : {\n"
" \"code\" : 2,\n"
" \"message\" : \"no valid backups\"\n"
" }\n"
" }\n"
"]\n"
, "json - multiple stanzas - selected found");
strLstAddZ(argListText, "--stanza=stanza2");
harnessCfgLoad(strLstSize(argListText), strLstPtr(argListText));
TEST_RESULT_STR(strPtr(infoRender()),
"stanza: stanza2\n"
" status: error (no valid backups)\n"
" cipher: none\n"
"\n"
" db (current)\n"
" wal archive min/max (9.4-1): none present\n"
,"text - multiple stanzas - selected found");
// Crypto error
//--------------------------------------------------------------------------------------------------------------------------
content = strNew
(
"[global]\n"
"repo-cipher-pass=123abc\n"
);
TEST_RESULT_VOID(
storagePutNP(storageNewWriteNP(storageLocalWrite(), strNewFmt("%s/pgbackrest.conf", testPath())),
Add macros to create constant Buffer objects. These are more efficient than creating buffers in place when needed. After replacement discovered that bufNewStr() and BufNewZ() were not being used in the core code so removed them. This required using the macros in tests which is not the usual pattern.
2019-04-20 08:16:17 -04:00
BUFSTR(content)), "put pgbackrest.conf file");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
strLstAddZ(argListText, "--repo-cipher-type=aes-256-cbc");
strLstAdd(argListText, strNewFmt("--config=%s/pgbackrest.conf", testPath()));
harnessCfgLoad(strLstSize(argListText), strLstPtr(argListText));
TEST_ERROR_FMT(
infoRender(), CryptoError,
"unable to load info file '%s/backup.info' or '%s/backup.info.copy':\n"
"CryptoError: '%s/backup.info' cipher header invalid\n"
"HINT: Is or was the repo encrypted?\n"
Refactoring path support in the storage module. Not all storage types support paths as a physical thing that must be created/destroyed. Add a feature to determine which drivers use paths and simplify the driver API as much as possible given that knowledge and by implementing as much path logic as possible in the Storage object. Remove the ignoreMissing parameter from pathSync() since it is not used and makes little sense. Create a standard list of error messages for the drivers to use and apply them where the code was modified -- there is plenty of work still to be done here.
2019-05-26 12:41:15 -04:00
"FileMissingError: " STORAGE_ERROR_READ_MISSING "\n"
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
"HINT: backup.info cannot be opened and is required to perform a backup.\n"
"HINT: has a stanza-create been performed?\n"
Refactoring path support in the storage module. Not all storage types support paths as a physical thing that must be created/destroyed. Add a feature to determine which drivers use paths and simplify the driver API as much as possible given that knowledge and by implementing as much path logic as possible in the Storage object. Remove the ignoreMissing parameter from pathSync() since it is not used and makes little sense. Create a standard list of error messages for the drivers to use and apply them where the code was modified -- there is plenty of work still to be done here.
2019-05-26 12:41:15 -04:00
"HINT: use option --stanza if encryption settings are different for the stanza than the global settings",
strPtr(backupStanza2Path), strPtr(backupStanza2Path), strPtr(backupStanza2Path),
strPtr(strNewFmt("%s/backup.info.copy", strPtr(backupStanza2Path))));
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
}
//******************************************************************************************************************************
if (testBegin("formatTextDb()"))
{
// These tests cover branches not covered in other tests
KeyValue *stanzaInfo = kvNew();
VariantList *dbSection = varLstNew();
varNewKv() accepts a KeyValue object rather than creating one. This allows for more flexibility about when the Variant is created.
2019-04-22 16:04:04 -04:00
Variant *pgInfo = varNewKv(kvNew());
Update code to use new unsigned int Variant type and config methods.
2019-04-19 11:40:39 -04:00
kvPut(varKv(pgInfo), DB_KEY_ID_VAR, varNewUInt(1));
Add macros to create constant Variant types. These work almost exactly like the String constant macros. However, a struct per variant type was required which meant custom constructors and destructors for each type. Propagate the variant constants out into the codebase wherever they are useful.
2019-04-17 08:04:22 -04:00
kvPut(varKv(pgInfo), DB_KEY_SYSTEM_ID_VAR, varNewUInt64(6625633699176220261));
kvPut(varKv(pgInfo), DB_KEY_VERSION_VAR, VARSTR(pgVersionToStr(90500)));
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
varLstAdd(dbSection, pgInfo);
// Add the database history, backup and archive sections to the stanza info
Add macros to create constant Variant types. These work almost exactly like the String constant macros. However, a struct per variant type was required which meant custom constructors and destructors for each type. Propagate the variant constants out into the codebase wherever they are useful.
2019-04-17 08:04:22 -04:00
kvPut(stanzaInfo, STANZA_KEY_DB_VAR, varNewVarLst(dbSection));
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
VariantList *backupSection = varLstNew();
varNewKv() accepts a KeyValue object rather than creating one. This allows for more flexibility about when the Variant is created.
2019-04-22 16:04:04 -04:00
Variant *backupInfo = varNewKv(kvNew());
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
Add macros to create constant Variant types. These work almost exactly like the String constant macros. However, a struct per variant type was required which meant custom constructors and destructors for each type. Propagate the variant constants out into the codebase wherever they are useful.
2019-04-17 08:04:22 -04:00
kvPut(varKv(backupInfo), BACKUP_KEY_LABEL_VAR, VARSTRDEF("20181119-152138F"));
kvPut(varKv(backupInfo), BACKUP_KEY_TYPE_VAR, VARSTRDEF("full"));
kvPutKv(varKv(backupInfo), KEY_ARCHIVE_VAR);
KeyValue *infoInfo = kvPutKv(varKv(backupInfo), BACKUP_KEY_INFO_VAR);
kvPut(infoInfo, KEY_SIZE_VAR, varNewUInt64(0));
kvPut(infoInfo, KEY_DELTA_VAR, varNewUInt64(0));
KeyValue *repoInfo = kvPutKv(infoInfo, INFO_KEY_REPOSITORY_VAR);
kvAdd(repoInfo, KEY_SIZE_VAR, varNewUInt64(0));
kvAdd(repoInfo, KEY_DELTA_VAR, varNewUInt64(0));
KeyValue *databaseInfo = kvPutKv(varKv(backupInfo), KEY_DATABASE_VAR);
Update code to use new unsigned int Variant type and config methods.
2019-04-19 11:40:39 -04:00
kvAdd(databaseInfo, DB_KEY_ID_VAR, varNewUInt(1));
Add macros to create constant Variant types. These work almost exactly like the String constant macros. However, a struct per variant type was required which meant custom constructors and destructors for each type. Propagate the variant constants out into the codebase wherever they are useful.
2019-04-17 08:04:22 -04:00
KeyValue *timeInfo = kvPutKv(varKv(backupInfo), BACKUP_KEY_TIMESTAMP_VAR);
kvAdd(timeInfo, KEY_START_VAR, varNewUInt64(1542383276));
kvAdd(timeInfo, KEY_STOP_VAR, varNewUInt64(1542383289));
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
varLstAdd(backupSection, backupInfo);
Add macros to create constant Variant types. These work almost exactly like the String constant macros. However, a struct per variant type was required which meant custom constructors and destructors for each type. Propagate the variant constants out into the codebase wherever they are useful.
2019-04-17 08:04:22 -04:00
kvPut(stanzaInfo, STANZA_KEY_BACKUP_VAR, varNewVarLst(backupSection));
kvPut(stanzaInfo, KEY_ARCHIVE_VAR, varNewVarLst(varLstNew()));
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
String *result = strNew("");
formatTextDb(stanzaInfo, result);
TEST_RESULT_STR(strPtr(result),
"\n"
" db (current)\n"
" full backup: 20181119-152138F\n"
" timestamp start/stop: 2018-11-16 15:47:56 / 2018-11-16 15:48:09\n"
" wal start/stop: n/a\n"
" database size: 0B, backup size: 0B\n"
" repository size: 0B, repository backup size: 0B\n"
,"formatTextDb only backup section (code cverage only)");
}
//******************************************************************************************************************************
if (testBegin("cmdInfo()"))
{
StringList *argList = strLstNew();
strLstAddZ(argList, "pgbackrest");
strLstAdd(argList, strNewFmt("--repo-path=%s", strPtr(repoPath)));
strLstAddZ(argList, "info");
harnessCfgLoad(strLstSize(argList), strLstPtr(argList));
storagePathCreateNP(storageLocalWrite(), archivePath);
storagePathCreateNP(storageLocalWrite(), backupPath);
// Redirect stdout to a file
int stdoutSave = dup(STDOUT_FILENO);
String *stdoutFile = strNewFmt("%s/stdout.info", testPath());
Use THROW_ON_SYS_ERROR*() to improve code coverage. There is only one instance in the core code where this helps. It is mostly helpful in the tests. There is an argument to be made that only THROW_SYS_ERROR*() variants should be used in the core code to improve test coverage. If so, that will be the subject of a future commit.
2019-04-29 18:36:57 -04:00
THROW_ON_SYS_ERROR(freopen(strPtr(stdoutFile), "w", stdout) == NULL, FileWriteError, "unable to reopen stdout");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
// Not in a test wrapper to avoid writing to stdout
cmdInfo();
// Restore normal stdout
dup2(stdoutSave, STDOUT_FILENO);
Simplify storage object names. Remove "File" and "Driver" from object names so they are shorter and easier to keep consistent. Also remove the "driver" directory so storage implementations are visible directly under "storage".
2019-05-03 15:46:15 -04:00
Storage *storage = storagePosixNew(
Improve type safety of interfaces and drivers. The function pointer casting used when creating drivers made changing interfaces difficult and led to slightly divergent driver implementations. Unit testing caught production-level errors but there were a lot of small issues and the process was harder than it should have been. Use void pointers instead so that no casts are required. Introduce the THIS_VOID and THIS() macros to make dealing with void pointers a little safer. Since we don't want to expose void pointers in header files, driver functions have been removed from the headers and the various driver objects return their interface type. This cuts down on accessor methods and the vast majority of those functions were not being used. Move functions that are still required to .intern.h. Remove the special "C" crypto functions that were used in libc and instead use the standard interface.
2019-05-02 17:52:24 -04:00
strNew(testPath()), STORAGE_MODE_FILE_DEFAULT, STORAGE_MODE_PATH_DEFAULT, false, NULL);
Simplify info command text message when no stanza are present. Replace the repository path with just "the repository". The path is not important in this context and it is clearer to state where the stanzas are missing from.
2019-01-16 19:23:10 +02:00
TEST_RESULT_STR(
strPtr(strNewBuf(storageGetNP(storageNewReadNP(storage, stdoutFile)))), "No stanzas exist in the repository.\n",
" check text");
Migrate local info command to C. The info command will only be executed in C if the repository is local, i.e. not located on a remote repository host. S3 is considered "local" in this case. This is a direct migration from Perl to integrate as seamlessly with the remaining Perl code as possible. It should not be possible to determine if the C version is running unless debug-level logging is enabled. Contributed by Cynthia Shang.
2018-12-13 16:22:34 -05:00
}
FUNCTION_HARNESS_RESULT_VOID();
}
Reference in New Issue Copy Permalink