pgbackrest/libc/xs/storage/storage.xs

# ----------------------------------------------------------------------------------------------------------------------------------
# Storage Exports
# ----------------------------------------------------------------------------------------------------------------------------------

MODULE = pgBackRest::LibC PACKAGE = pgBackRest::LibC

####################################################################################################################################
void
storageDriverPosixPathRemove(path, errorOnMissing, recurse)
    const char *path
    bool errorOnMissing
    bool recurse
CODE:
    MEM_CONTEXT_XS_TEMP_BEGIN()
    {
        storageDriverPosixPathRemove(storageDriverPosixNew(strNew("/"), 0640, 750, true, NULL), strNew(path), errorOnMissing, recurse);
    }
    MEM_CONTEXT_XS_TEMP_END();
Add storagePathRemove() and use it in the Perl Posix driver. This implementation should be faster because it does not stat each file. It simply assumes that most directory entries are files so attempts an unlink() first. If the entry is reported by error codes to be a directory then it attempts an rmdir(). 2018-04-11 14:21:09 +02:00			`# ----------------------------------------------------------------------------------------------------------------------------------`
			`# Storage Exports`
			`# ----------------------------------------------------------------------------------------------------------------------------------`

			`MODULE = pgBackRest::LibC PACKAGE = pgBackRest::LibC`

			`####################################################################################################################################`
			`void`
			`storageDriverPosixPathRemove(path, errorOnMissing, recurse)`
			`const char *path`
			`bool errorOnMissing`
			`bool recurse`
			`CODE:`
			`MEM_CONTEXT_XS_TEMP_BEGIN()`
			`{`
Full abstraction of storage driver interface. The external storage interfaces (Storage, StorageFileRead, etc.) have been stable for a while, but internally they were calling the posix driver functions directly. Create driver interfaces for storage, fileRead, and fileWrite and remove all references to the posix driver outside storage/driver/posix (with the exception of a direct call to pathRemove() in Perl LibC). Posix is still the only available driver so more adjustment may be needed, but this should represent the bulk of the changes. 2018-09-14 22:08:33 +02:00			`storageDriverPosixPathRemove(storageDriverPosixNew(strNew("/"), 0640, 750, true, NULL), strNew(path), errorOnMissing, recurse);`
Add storagePathRemove() and use it in the Perl Posix driver. This implementation should be faster because it does not stat each file. It simply assumes that most directory entries are files so attempts an unlink() first. If the entry is reported by error codes to be a directory then it attempts an rmdir(). 2018-04-11 14:21:09 +02:00			`}`
			`MEM_CONTEXT_XS_TEMP_END();`