db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-11-06 08:49:29 +02:00
Code Issues Releases Activity

Update Perl page checksum expression.

Browse Source 
This expression determines which files contain page checksums but it was also including the directory above the relation directories.  In a real PostgreSQL installation this not a problem because these directories don't contain any files.

However, our tests place a file in `base` which the Perl code thought should have page checksums while the new C code says no.

Update the expression to document the change and avoid churn in the expect logs later.
This commit is contained in:
David Steele
2019-11-25 07:37:09 -05:00
parent 18e43c5955
commit 01aefc563d
6 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/lib/pgBackRestTest/Module/Manifest/ManifestAllPerlTest.pm
View File

@@ -1661,7 +1661,7 @@ sub run
$self->testResult(sub {isChecksumPage($strFile)}, false,
"file '${strFile}' isChecksumPage=false");
$strFile = MANIFEST_TARGET_PGDATA . '/' . DB_PATH_BASE . '/' . BOGUS;
$strFile = MANIFEST_TARGET_PGDATA . '/' . DB_PATH_BASE . '/123/' . BOGUS;
$self->testResult(sub {isChecksumPage($strFile)}, true,
"file '${strFile}' isChecksumPage=true");

3
test/lib/pgBackRestTest/Module/Mock/MockAllTest.pm
View File

@@ -1067,8 +1067,7 @@ sub run
$oHostDbMaster->manifestReference(\%oManifest, $strBackup);
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/base2.txt', 'BASE2', '09b5e31766be1dba1ec27de82f975c1b6eea2a92',
$lTime, undef, undef, false);
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/base2.txt', 'BASE2', '09b5e31766be1dba1ec27de82f975c1b6eea2a92', $lTime);
$oHostDbMaster->manifestTablespaceDrop(\%oManifest, 1, 2);