db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-01-18 04:58:51 +02:00
Code Issues Releases Activity

Reset line number in TEST_ERROR*() macros.

Browse Source 
If these are not reset then an error not wrapped in a TEST_ERROR*() macro may show the line number of the previous error in a stack trace, which is confusing.

It is better for the line number to be unreported than wrong.
This commit is contained in:
David Steele 2020-04-07 14:42:05 -04:00
parent 627b495352
commit 099bd85ed7
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/src/common/harnessTest.h
View File

@ -117,6 +117,8 @@ Test that an expected error is actually thrown and error when it isn't
THROW_FMT( \ THROW_FMT( \
TestError, "statement '%s' returned but error %s, '%s' was expected", #statement, errorTypeName(&errorTypeExpected), \ TestError, "statement '%s' returned but error %s, '%s' was expected", #statement, errorTypeName(&errorTypeExpected), \
errorMessageExpected); \ errorMessageExpected); \
\
stackTraceTestFileLineSet(0); \
} }
/*********************************************************************************************************************************** /***********************************************************************************************************************************
@ -130,6 +132,8 @@ Test error with a formatted expected message
THROW_FMT(AssertError, "error message needs more than the %zu characters available", sizeof(TEST_ERROR_FMT_buffer)); \ THROW_FMT(AssertError, "error message needs more than the %zu characters available", sizeof(TEST_ERROR_FMT_buffer)); \
\ \
TEST_ERROR(statement, errorTypeExpected, TEST_ERROR_FMT_buffer); \ TEST_ERROR(statement, errorTypeExpected, TEST_ERROR_FMT_buffer); \
\
stackTraceTestFileLineSet(0); \
} }
/*********************************************************************************************************************************** /***********************************************************************************************************************************