db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-04-13 11:30:40 +02:00
Code Issues Releases Activity

Fix mismatched parameters in tlsClientNew() call.

Browse Source 
3879bc69 added this call and the parameters were not quite right but in way that the compiler decided they were OK. It was mostly working but TLS verification was disabled if caPath was NULL, which is not OK.
This commit is contained in:
Reid Thompson 2021-10-25 12:56:33 -04:00 committed by David Steele
parent a1a2284c88
commit 1152f7a7d6
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/xml/release.xml
View File

@ -78,12 +78,16 @@
</release-item>
<release-item>
<github-issue id="1203"/>
<github-pull-request id="1527"/>
<commit subject="Add WebIdentity authentication for AWS S3.">
<github-issue id="1203"/>
<github-pull-request id="1527"/>
</commit>
<commit subject="Fix mismatched parameters in tlsClientNew() call."/>
<release-item-contributor-list>
<release-item-contributor id="david.steele"/>
<release-item-reviewer id="james.callahan"/>
<release-item-reviewer id="reid.thompson"/>
<!-- Actually tester, but we don't have a tag for that yet -->
<release-item-reviewer id="benjamin.blattberg"/>
<release-item-reviewer id="andrew.lecuyer"/>

4
src/storage/s3/storage.c
View File

@ -1111,8 +1111,8 @@ storageS3New(
driver->credExpirationTime = time(NULL);
driver->credHttpClient = httpClientNew(
tlsClientNew(
sckClientNew(driver->credHost, S3_STS_PORT, timeout, timeout), driver->credHost, timeout, true, caFile,
caPath, NULL, NULL, NULL),
sckClientNew(driver->credHost, S3_STS_PORT, timeout, timeout), driver->credHost, timeout, timeout, true,
caFile, caPath, NULL, NULL),
timeout);
break;