From 148956aed8aca201aa800af321d946094b96f176 Mon Sep 17 00:00:00 2001 From: David Steele Date: Wed, 1 Jun 2022 10:13:57 -0400 Subject: [PATCH] Remove useless command/check unit test. This test was a placeholder and did not provide any coverage, but it did give inconsistent results on different shell versions. --- test/define.yaml | 2 +- test/src/module/command/checkTest.c | 18 ------------------ 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/test/define.yaml b/test/define.yaml index 910e39fa0..98554f808 100644 --- a/test/define.yaml +++ b/test/define.yaml @@ -740,7 +740,7 @@ unit: # ---------------------------------------------------------------------------------------------------------------------------- - name: check - total: 4 + total: 3 containerReq: true coverage: diff --git a/test/src/module/command/checkTest.c b/test/src/module/command/checkTest.c index 0df6e0401..2fbf3a73b 100644 --- a/test/src/module/command/checkTest.c +++ b/test/src/module/command/checkTest.c @@ -367,24 +367,6 @@ testRun(void) TEST_RESULT_VOID(checkPrimary(dbGroup), "primary == NULL"); } - // ***************************************************************************************************************************** - if (testBegin("checkManifest()")) - { - argList = strLstNew(); - hrnCfgArgRawZ(argList, cfgOptStanza, "test1"); - hrnCfgArgRawZ(argList, cfgOptPgPath, TEST_PATH "/pg"); - hrnCfgArgKeyRawZ(argList, cfgOptPgHost, 5, "localhost"); - hrnCfgArgKeyRawZ(argList, cfgOptPgHostCmd, 5, "pgbackrest-bogus"); - hrnCfgArgKeyRawZ(argList, cfgOptPgPath, 5, "/path/to/pg5"); - hrnCfgArgKeyRawZ(argList, cfgOptPgHostUser, 5, TEST_USER); - HRN_CFG_LOAD(cfgCmdCheck, argList); - - // Placeholder test for manifest - TEST_ERROR( - checkManifest(), UnknownError, - "remote-0 process on 'localhost' terminated unexpectedly [127]: bash: pgbackrest-bogus: command not found"); - } - // ***************************************************************************************************************************** if (testBegin("checkDbConfig(), checkArchiveCommand()")) {