From 1b647a1a22ae36e2447dc04384ab794b011a74aa Mon Sep 17 00:00:00 2001 From: David Steele Date: Thu, 5 Mar 2020 14:06:36 -0500 Subject: [PATCH] Remove invalid page checksum test. All zero pages should not have checksums. Not only is this test invalid but it will not work with the stock page checksum implementation in PostgreSQL, which checks for zero pages. Since we will be using that code verbatim soon this test needs to go. --- test/src/module/postgres/pageChecksumTest.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/src/module/postgres/pageChecksumTest.c b/test/src/module/postgres/pageChecksumTest.c index 290241e81..28c315012 100644 --- a/test/src/module/postgres/pageChecksumTest.c +++ b/test/src/module/postgres/pageChecksumTest.c @@ -27,10 +27,6 @@ testRun(void) // ***************************************************************************************************************************** if (testBegin("pgPageChecksum()")) { - // Checksum for 0x00 fill, page 0x00 - memset(testPage(0), 0, PG_PAGE_SIZE_DEFAULT); - TEST_RESULT_U16_HEX(pgPageChecksum(testPage(0), 0), 0xC6AA, "check for 0x00 filled page, block 0"); - // Checksum for 0xFF fill, page 0x00 memset(testPage(0), 0xFF, PG_PAGE_SIZE_DEFAULT); TEST_RESULT_U16_HEX(pgPageChecksum(testPage(0), 0), 0x0E1C, "check for 0xFF filled page, block 0");