db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-07-09 00:45:49 +02:00
Code Issues Releases Activity

Convert storagePosixNew() to storagePosixNewP().

Browse Source 
An upcoming feature requires new parameters for storagePosixNew() and this causes a lot of churn because almost every test creates a Posix storage object. Some refactoring in the tests might reduce this duplication but storagePosixNew() is collecting a lot of parameters so converting to storagePosixNewP() makes sense in any case.

There are relatively few call sites in the core code but they still benefit from better readability after this change.
This commit is contained in:
David Steele
2020-04-30 11:01:38 -04:00
parent baf8cb9068
commit 22ba1f02ce
26 changed files with 67 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/src/module/command/infoTest.c
View File

@ -1312,8 +1312,7 @@ testRun(void)
// Restore normal stdout
dup2(stdoutSave, STDOUT_FILENO);
Storage *storage = storagePosixNew(
strNew(testPath()), STORAGE_MODE_FILE_DEFAULT, STORAGE_MODE_PATH_DEFAULT, false, NULL);
Storage *storage = storagePosixNewP(strNew(testPath()));
TEST_RESULT_STR_Z(
strNewBuf(storageGetP(storageNewReadP(storage, stdoutFile))), "No stanzas exist in the repository.\n",
" check text");