db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-07-15 01:04:37 +02:00
Code Issues Releases Activity

Rearrange members in StackTraceData struct to save memory.

Browse Source 
This arrangement is more efficient on 64-bit systems due to alignment. There is no difference on 32-bit systems.
This commit is contained in:
David Steele
2020-08-20 15:53:01 -04:00
parent 859b8a50fd
commit 25ee913932
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/stackTrace.c
View File

@ -34,10 +34,10 @@ typedef struct StackTraceData
LogLevel functionLogLevel; LogLevel functionLogLevel;
unsigned int tryDepth; unsigned int tryDepth;
char *param;
size_t paramSize;
bool paramOverflow; bool paramOverflow;
bool paramLog; bool paramLog;
char *param;
size_t paramSize;
} StackTraceData; } StackTraceData;
static StackTraceData stackTrace[STACK_TRACE_MAX]; static StackTraceData stackTrace[STACK_TRACE_MAX];

4
test/src/module/common/stackTraceTest.c
View File

@ -68,6 +68,10 @@ testRun(void)
#ifdef WITH_BACKTRACE #ifdef WITH_BACKTRACE
stackTraceInit(testExe()); stackTraceInit(testExe());
#endif #endif
// -------------------------------------------------------------------------------------------------------------------------
TEST_TITLE("check size of StackTraceData");
TEST_RESULT_UINT(sizeof(StackTraceData), TEST_64BIT() ? 48 : 32, "check");
TEST_ERROR(stackTracePop("file1", "function1", false), AssertError, "assertion 'stackSize > 0' failed"); TEST_ERROR(stackTracePop("file1", "function1", false), AssertError, "assertion 'stackSize > 0' failed");