db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-07-03 00:26:59 +02:00
Code Issues Releases Activity

Use THROW_ON_SYS_ERROR macro to improve fork code coverage.

Browse Source 
Lack of code coverage in this module is just noise since these functions cannot generally be made to fail.

Any failures are fatal.
This commit is contained in:
David Steele
2018-11-11 18:12:43 -05:00
parent 72ea47bfb3
commit 38c5f65770
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
doc/xml/release.xml
View File

@ -114,6 +114,10 @@
<p>Add <code>KernelError</code> to report miscellaneous kernel errors.</p>
</release-item>
<release-item>
<p>Use <code>THROW_ON_SYS_ERROR</code> macro to improve <code>fork</code> code coverage.</p>
</release-item>
<release-item>
<p><code>Storage</code> interface methods no longer declare the driver as const.</p>
</release-item>

20
src/common/fork.c
View File

@ -16,20 +16,16 @@ forkDetach(void)
{
FUNCTION_DEBUG_VOID(logLevelTrace);
if (chdir("/") == -1) // {uncoverable - should never fail}
THROW_SYS_ERROR(PathMissingError, "unable to change directory to '/'"); // {uncoverable+}
// Change the working directory to / so we won't error if the old working directory goes away
THROW_ON_SYS_ERROR(chdir("/") == -1, PathMissingError, "unable to change directory to '/'");
if (setsid() == -1) // {uncoverable - should never fail}
THROW_SYS_ERROR(AssertError, "unable to create new session group"); // {uncoverable+}
// Make this process a group leader so the parent process won't block waiting for it to finish
THROW_ON_SYS_ERROR(setsid() == -1, KernelError, "unable to create new session group");
if (close(STDIN_FILENO) == -1) // {uncoverable - should never fail}
THROW_SYS_ERROR(FileCloseError, "unable to close stdin"); // {uncoverable+}
if (close(STDOUT_FILENO) == -1) // {uncoverable - should never fail}
THROW_SYS_ERROR(FileCloseError, "unable to close stdout"); // {uncoverable+}
if (close(STDERR_FILENO) == -1) // {uncoverable - should never fail}
THROW_SYS_ERROR(FileCloseError, "unable to close stderr"); // {uncoverable+}
// Close standard file handles
THROW_ON_SYS_ERROR(close(STDIN_FILENO) == -1, FileCloseError, "unable to close stdin");
THROW_ON_SYS_ERROR(close(STDOUT_FILENO) == -1, FileCloseError, "unable to close stdout");
THROW_ON_SYS_ERROR(close(STDERR_FILENO) == -1, FileCloseError, "unable to close stderr");
FUNCTION_DEBUG_RESULT_VOID();
}