From 3a7558985505ce1a764e846aa01e943dc1e470d1 Mon Sep 17 00:00:00 2001
From: David Steele <david@pgmasters.net>
Date: Thu, 7 May 2020 07:23:15 -0400
Subject: [PATCH] Don't allow sudo to disable core dumps in documentation.

Newer versions of sudo output this message to stdout when run in a container:

sudo: setrlimit(RLIMIT_CORE): Operation not permitted

See https://github.com/sudo-project/sudo/issues/42 for details.

A simple workaround is to prevent sudo from disabling core dumps. This seems safe enough because if sudo is segfaulting then core files are the least of our worries.
---
 doc/xml/user-guide.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/xml/user-guide.xml b/doc/xml/user-guide.xml
index f7b33ee07..8cf0db16a 100644
--- a/doc/xml/user-guide.xml
+++ b/doc/xml/user-guide.xml
@@ -266,6 +266,9 @@
         </variable>
 
         <variable key="copy-ca-cert">COPY {[fake-cert-path-relative]}/ca.crt {[ca-cert-path]}/pgbackrest-ca.crt</variable>
+
+        <!-- Don't allow sudo to disable core dump (suppresses errors, see https://github.com/sudo-project/sudo/issues/42) -->
+        <variable key="sudo-disable-core-dump">RUN echo "Set disable_coredump false" >> /etc/sudo.conf</variable>
     </variable-list>
 
     <!-- Setup hosts used to build the documentation
@@ -282,6 +285,8 @@
             apt-get update &amp;&amp; \
             apt-get install -y sudo ssh wget vim gnupg lsb-release iputils-ping ca-certificates tzdata locales 2>&amp;1
 
+        {[sudo-disable-core-dump]}
+
         # Install CA certificate
         RUN update-ca-certificates
 
@@ -318,6 +323,8 @@
         # Install packages
         RUN yum install -y openssh-server openssh-clients sudo wget vim 2>&amp;1
 
+        {[sudo-disable-core-dump]}
+
         # Install CA certificate
         RUN update-ca-trust enable &amp;&amp; \
             update-ca-trust extract