db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-07-15 01:04:37 +02:00
Code Issues Releases Activity

Add MAX_ASSIGN() macro.

Browse Source 
This improves coverage in cases where the compared values may be always ascending or descending.
This commit is contained in:
David Steele
2019-05-13 18:05:54 -04:00
parent 15a33bf74b
commit 57281d4792
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/common/macro.h
View File

@ -7,7 +7,7 @@ General Macros
/*********************************************************************************************************************************** /***********************************************************************************************************************************
Convert the parameter to a zero-terminated string Convert the parameter to a zero-terminated string
This is useful for converting non-string types (e.g. int) to strings for inclusion in messages. Useful for converting non-string types (e.g. int) to strings for inclusion in messages.
***********************************************************************************************************************************/ ***********************************************************************************************************************************/
#define STRINGIFY_HELPER(param) #param #define STRINGIFY_HELPER(param) #param
#define STRINGIFY(param) STRINGIFY_HELPER(param) #define STRINGIFY(param) STRINGIFY_HELPER(param)
@ -21,4 +21,17 @@ common/object.h has numerous examples of this.
#define GLUE_HELPER(param1, param2) param1##param2 #define GLUE_HELPER(param1, param2) param1##param2
#define GLUE(param1, param2) GLUE_HELPER(param1, param2) #define GLUE(param1, param2) GLUE_HELPER(param1, param2)
/***********************************************************************************************************************************
If param2 > param1 then assign it to param1
Useful for ensuring coverage in cases where compared values may be always ascending or decending.
***********************************************************************************************************************************/
#define MAX_ASSIGN(param1, param2) \
do \
{ \
if (param2 > param1) \
param1 = param2; \
} \
while (0)
#endif #endif

5
src/protocol/parallel.c
View File

@ -147,9 +147,8 @@ protocolParallelProcess(ProtocolParallel *this)
int handle = ioReadHandle(protocolClientIoRead(*(ProtocolClient **)lstGet(this->clientList, clientIdx))); int handle = ioReadHandle(protocolClientIoRead(*(ProtocolClient **)lstGet(this->clientList, clientIdx)));
FD_SET((unsigned int)handle, &selectSet); FD_SET((unsigned int)handle, &selectSet);
// Set the max handle // Find the max file handle needed for select()
if (handle > handleMax) // {+uncovered_branch - often in ascending order} MAX_ASSIGN(handleMax, handle);
handleMax = handle;
clientRunningTotal++; clientRunningTotal++;
} }