Remove unused type parameter from FUNCTION_TEST_RETURN().

This parameter was always useless but commit 7333b630 removed all references to it so remove the parameter at all call sites as well.

The original intention was probably to allow logging of TEST return values but that never happened.

src/postgres/interface.c

@@ -291,7 +291,7 @@ pgControlTestToBuffer(PgControl pgControl)
     // Generate pg_control
     interface->controlTest(pgControl, result);
 
-    FUNCTION_TEST_RETURN(BUFFER, result);
+    FUNCTION_TEST_RETURN(result);
 }
 
 #endif

src/postgres/interface/v083.c

@@ -25,7 +25,7 @@ pgInterfaceIs083(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v084.c

@@ -25,7 +25,7 @@ pgInterfaceIs084(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v090.c

@@ -25,7 +25,7 @@ pgInterfaceIs090(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v091.c

@@ -25,7 +25,7 @@ pgInterfaceIs091(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v092.c

@@ -25,7 +25,7 @@ pgInterfaceIs092(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v093.c

@@ -25,7 +25,7 @@ pgInterfaceIs093(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v094.c

@@ -25,7 +25,7 @@ pgInterfaceIs094(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v095.c

@@ -25,7 +25,7 @@ pgInterfaceIs095(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v096.c

@@ -25,7 +25,7 @@ pgInterfaceIs096(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v100.c

@@ -25,7 +25,7 @@ pgInterfaceIs100(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/interface/v110.c

@@ -25,7 +25,7 @@ pgInterfaceIs110(const Buffer *controlFile)
     ControlFileData *controlData = (ControlFileData *)bufPtr(controlFile);
 
     FUNCTION_TEST_RETURN(
-        BOOL, controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
+        controlData->pg_control_version == PG_CONTROL_VERSION && controlData->catalog_version_no == CATALOG_VERSION_NO);
 }
 
 /***********************************************************************************************************************************

src/postgres/pageChecksum.c

@@ -165,7 +165,7 @@ pageChecksumBlock(const unsigned char *page, unsigned int pageSize)
     for (i = 0; i < N_SUMS; i++)
         result ^= sums[i];
 
-    FUNCTION_TEST_RETURN(UINT32, result);
+    FUNCTION_TEST_RETURN(result);
 }
 
 /***********************************************************************************************************************************
@@ -198,7 +198,7 @@ pageChecksum(const unsigned char *page, unsigned int blockNo, unsigned int pageS
     checksum ^= blockNo;
 
     // Reduce to a uint16 with an offset of one. That avoids checksums of zero, which seems like a good idea.
-    FUNCTION_TEST_RETURN(UINT16, (uint16_t)(checksum % 65535 + 1));
+    FUNCTION_TEST_RETURN((uint16_t)(checksum % 65535 + 1));
 }
 
 /***********************************************************************************************************************************
@@ -219,7 +219,6 @@ pageChecksumTest(
     ASSERT(page != NULL);
 
     FUNCTION_TEST_RETURN(
-        BOOL,
         // This is a new page so don't test checksum
         ((PageHeader)page)->pd_upper == 0 ||
         // LSN is after the backup started so checksum is not tested because pages may be torn