db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-03-03 14:52:21 +02:00
Code Issues Releases Activity

Fix leaks in common/io unit test.

Browse Source 
These leaks make it harder to detect leaks in the core code, so fix them.
This commit is contained in:
David Steele 2022-04-28 12:31:59 -04:00
parent 8047e97e31
commit 90f939b36f
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/src/module/common/ioTest.c
View File

@ -54,10 +54,10 @@ testIoWriteOpen(void *driver)
}
static void
testIoWrite(void *driver, const Buffer *buffer)
testIoWrite(void *const driver, const Buffer *const buffer)
{
ASSERT(driver == (void *)999);
ASSERT(strEq(strNewBuf(buffer), STRDEF("ABC")));
ASSERT(strncmp((const char *)bufPtrConst(buffer), "ABC", bufSize(buffer)) == 0);
}
static bool testIoWriteCloseCalled = false;
@ -106,7 +106,11 @@ ioTestFilterSizeResult(THIS_VOID)
pckWriteU64P(packWrite, this->size);
pckWriteEndP(packWrite);
return pckWriteResult(packWrite);
Pack *const result = pckDup(pckWriteResult(packWrite));
pckWriteFree(packWrite);
return result;
}
static IoFilter *
@ -140,7 +144,7 @@ typedef struct IoTestFilterMultiply
} IoTestFilterMultiply;
static void
ioTestFilterMultiplyProcess(THIS_VOID, const Buffer *input, Buffer *output)
ioTestFilterMultiplyProcess(THIS_VOID, const Buffer *const input, Buffer *const output)
{
THIS(IoTestFilterMultiply);
@ -163,7 +167,7 @@ ioTestFilterMultiplyProcess(THIS_VOID, const Buffer *input, Buffer *output)
else
{
char flushZ[] = {this->flushChar, 0};
bufCat(output, bufNewC(flushZ, 1));
bufCat(output, BUF(flushZ, 1));
this->flushTotal--;
}
}
@ -171,7 +175,12 @@ ioTestFilterMultiplyProcess(THIS_VOID, const Buffer *input, Buffer *output)
{
if (this->multiplyBuffer == NULL)
{
this->multiplyBuffer = bufNew(bufUsed(input) * this->multiplier);
MEM_CONTEXT_OBJ_BEGIN(this)
{
this->multiplyBuffer = bufNew(bufUsed(input) * this->multiplier);
}
MEM_CONTEXT_OBJ_END();
const unsigned char *inputPtr = bufPtrConst(input);
unsigned char *bufferPtr = bufPtr(this->multiplyBuffer);