db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2024-12-14 10:13:05 +02:00
Code Issues Releases Activity

Remove unused constructor strLstNewParam().

Browse Source 
This function is not used in the core code so remove it and update the test where it was used.

There may eventually be a need for a strLstNewP() function but it doesn't seem worth the code churn until there is an actual requirement.
This commit is contained in:
David Steele 2020-07-20 18:09:32 -04:00
parent 1783e0490a
commit 90ffde8881
3 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/common/type/stringList.c
View File

@ -19,17 +19,7 @@ StringList *
strLstNew(void)
{
FUNCTION_TEST_VOID();
FUNCTION_TEST_RETURN(strLstNewParam(lstComparatorStr));
}
StringList *
strLstNewParam(ListComparator *comparator)
{
FUNCTION_TEST_BEGIN();
FUNCTION_TEST_PARAM(FUNCTIONP, comparator);
FUNCTION_TEST_END();
FUNCTION_TEST_RETURN((StringList *)lstNewP(sizeof(String *), .comparator = comparator));
FUNCTION_TEST_RETURN((StringList *)lstNewP(sizeof(String *), .comparator = lstComparatorStr));
}
/***********************************************************************************************************************************

1
src/common/type/stringList.h
View File

@ -18,7 +18,6 @@ typedef struct StringList StringList;
Constructors
***********************************************************************************************************************************/
StringList *strLstNew(void);
StringList *strLstNewParam(ListComparator *comparator);
// Split a string into a string list based on a delimiter
StringList *strLstNewSplit(const String *string, const String *delimiter);

2
test/src/module/command/expireTest.c
View File

@ -2052,7 +2052,7 @@ testRun(void)
//--------------------------------------------------------------------------------------------------------------------------
TEST_TITLE("archiveId comparator sorting");
StringList *list = strLstNewParam(archiveIdComparator);
StringList *list = strLstComparatorSet(strLstNew(), archiveIdComparator);
strLstAddZ(list, "10-4");
strLstAddZ(list, "11-10");