db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-07-15 01:04:37 +02:00
Code Issues Releases Activity

Add hint about starting the stanza when WAL segment not found.

Browse Source 
If a stop command has been issued the check command fails due to archiving timing out.

Provide a hint to document this situation and point the user in the proper direction.
This commit is contained in:
David Christensen
2020-09-03 07:49:49 -04:00
committed by David Steele
parent 76900d6764
commit 9fd31913a8
5 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
doc/xml/release.xml
View File

@ -14,6 +14,17 @@
<release-list> <release-list>
<release date="XXXX-XX-XX" version="2.30dev" title="UNDER DEVELOPMENT"> <release date="XXXX-XX-XX" version="2.30dev" title="UNDER DEVELOPMENT">
<release-core-list> <release-core-list>
<release-improvement-list>
<release-item>
<release-item-contributor-list>
<release-item-contributor id="david.christensen"/>
<release-item-reviewer id="david.steele"/>
</release-item-contributor-list>
<p>Add hint about starting the stanza when WAL segment not found.</p>
</release-item>
</release-improvement-list>
<release-development-list> <release-development-list>
<release-item> <release-item>
<release-item-contributor-list> <release-item-contributor-list>
@ -8709,6 +8720,11 @@
<contributor-id type="github">danielwestermann</contributor-id> <contributor-id type="github">danielwestermann</contributor-id>
</contributor> </contributor>
<contributor id="david.christensen">
<contributor-name-display>David Christensen</contributor-name-display>
<contributor-id type="github">machack666</contributor-id>
</contributor>
<contributor id="david.raftis"> <contributor id="david.raftis">
<contributor-name-display>David Raftis</contributor-name-display> <contributor-name-display>David Raftis</contributor-name-display>
<contributor-id type="github">dpr11</contributor-id> <contributor-id type="github">dpr11</contributor-id>

3
src/command/archive/common.c
View File

@ -442,7 +442,8 @@ walSegmentFind(const Storage *storage, const String *archiveId, const String *wa
ArchiveTimeoutError, ArchiveTimeoutError,
"WAL segment %s was not archived before the %" PRIu64 "ms timeout\n" "WAL segment %s was not archived before the %" PRIu64 "ms timeout\n"
"HINT: check the archive_command to ensure that all options are correct (especially --stanza).\n" "HINT: check the archive_command to ensure that all options are correct (especially --stanza).\n"
"HINT: check the PostgreSQL server log for errors.", "HINT: check the PostgreSQL server log for errors.\n"
"HINT: run the 'start' command if the stanza was previously stopped.",
strZ(walSegment), timeout); strZ(walSegment), timeout);
} }

3
test/src/module/command/archiveCommonTest.c
View File

@ -237,7 +237,8 @@ testRun(void)
walSegmentFind(storageRepo(), strNew("9.6-2"), strNew("123456781234567812345678"), 100), ArchiveTimeoutError, walSegmentFind(storageRepo(), strNew("9.6-2"), strNew("123456781234567812345678"), 100), ArchiveTimeoutError,
"WAL segment 123456781234567812345678 was not archived before the 100ms timeout\n" "WAL segment 123456781234567812345678 was not archived before the 100ms timeout\n"
"HINT: check the archive_command to ensure that all options are correct (especially --stanza).\n" "HINT: check the archive_command to ensure that all options are correct (especially --stanza).\n"
"HINT: check the PostgreSQL server log for errors."); "HINT: check the PostgreSQL server log for errors.\n"
"HINT: run the 'start' command if the stanza was previously stopped.");
// Check timeout by making the wal segment appear after 250ms // Check timeout by making the wal segment appear after 250ms
HARNESS_FORK_BEGIN() HARNESS_FORK_BEGIN()

3
test/src/module/command/backupTest.c
View File

@ -2122,7 +2122,8 @@ testRun(void)
cmdBackup(), ArchiveTimeoutError, cmdBackup(), ArchiveTimeoutError,
"WAL segment 0000000105DA69C000000000 was not archived before the 100ms timeout\n" "WAL segment 0000000105DA69C000000000 was not archived before the 100ms timeout\n"
"HINT: check the archive_command to ensure that all options are correct (especially --stanza).\n" "HINT: check the archive_command to ensure that all options are correct (especially --stanza).\n"
"HINT: check the PostgreSQL server log for errors."); "HINT: check the PostgreSQL server log for errors.\n"
"HINT: run the 'start' command if the stanza was previously stopped.");
// Remove halted backup so there's no resume // Remove halted backup so there's no resume
storagePathRemoveP(storageRepoWrite(), STRDEF(STORAGE_REPO_BACKUP "/20191016-042640F"), .recurse = true); storagePathRemoveP(storageRepoWrite(), STRDEF(STORAGE_REPO_BACKUP "/20191016-042640F"), .recurse = true);

3
test/src/module/command/checkTest.c
View File

@ -273,7 +273,8 @@ testRun(void)
cmdCheck(), ArchiveTimeoutError, cmdCheck(), ArchiveTimeoutError,
"WAL segment 000000010000000100000001 was not archived before the 500ms timeout\n" "WAL segment 000000010000000100000001 was not archived before the 500ms timeout\n"
"HINT: check the archive_command to ensure that all options are correct (especially --stanza).\n" "HINT: check the archive_command to ensure that all options are correct (especially --stanza).\n"
"HINT: check the PostgreSQL server log for errors."); "HINT: check the PostgreSQL server log for errors.\n"
"HINT: run the 'start' command if the stanza was previously stopped.");
// Create WAL segment // Create WAL segment
Buffer *buffer = bufNew(16 * 1024 * 1024); Buffer *buffer = bufNew(16 * 1024 * 1024);