db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2024-12-12 10:04:14 +02:00
Code Issues Releases Activity

Refactor loop limit in removeExpiredArchive().

Browse Source 
This simplifies the formatting, which was a bit tortured. Also, there is no need to check the limit on each iteration so this is a bit more efficient.
This commit is contained in:
David Steele 2023-01-30 10:55:14 +07:00
parent f91af30584
commit a96837d2ed
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/command/expire/expire.c
View File

@ -448,13 +448,12 @@ removeExpiredArchive(InfoBackup *infoBackup, bool timeBasedFullRetention, unsign
// globalBackupRetentionList is ordered newest to oldest backup, so create globalBackupArchiveRetentionList of the
// newest backups whose archives will be retained
for (unsigned int idx = 0;
idx < (archiveRetention < strLstSize(globalBackupRetentionList) ?
archiveRetention : strLstSize(globalBackupRetentionList));
idx++)
{
strLstAdd(globalBackupArchiveRetentionList, strLstGet(globalBackupRetentionList, idx));
}
const unsigned int retentionSize =
archiveRetention < strLstSize(globalBackupRetentionList) ?
archiveRetention : strLstSize(globalBackupRetentionList);
for (unsigned int retentionIdx = 0; retentionIdx < retentionSize; retentionIdx++)
strLstAdd(globalBackupArchiveRetentionList, strLstGet(globalBackupRetentionList, retentionIdx));
// From newest to oldest, confirm the pgVersion and pgSystemId from the archive.info history id match that of the
// same history id of the backup.info and if not, there is a mismatch between the info files so do not continue.