From bb752cd111b1257088e57137bdbe6715e96eb292 Mon Sep 17 00:00:00 2001 From: David Steele Date: Tue, 19 Sep 2023 12:08:09 -0400 Subject: [PATCH] Remove duplicate tests from storage/sftp unit test module. These tests are already run as part of storage/posix and do not need to be duplicated in storage/sftp. --- test/define.yaml | 2 +- test/src/module/storage/sftpTest.c | 21 --------------------- 2 files changed, 1 insertion(+), 22 deletions(-) diff --git a/test/define.yaml b/test/define.yaml index cc91e503c..1c7febc95 100644 --- a/test/define.yaml +++ b/test/define.yaml @@ -607,7 +607,7 @@ unit: # ---------------------------------------------------------------------------------------------------------------------------- - name: sftp - total: 20 + total: 19 harness: libSsh2 harness: name: fd diff --git a/test/src/module/storage/sftpTest.c b/test/src/module/storage/sftpTest.c index 3d7e2f82c..49d1cca15 100644 --- a/test/src/module/storage/sftpTest.c +++ b/test/src/module/storage/sftpTest.c @@ -70,27 +70,6 @@ testRun(void) unsigned int repoIdx = 0; - // This test should always be first so the storage helper is uninitialized - // ***************************************************************************************************************************** - if (testBegin("storageHelperDryRunInit()")) - { - // ------------------------------------------------------------------------------------------------------------------------- - TEST_TITLE("writable storage fails when dry-run is not initialized"); - - TEST_ERROR(storagePgIdxWrite(0), AssertError, WRITABLE_WHILE_DRYRUN); - TEST_ERROR(storageRepoIdxWrite(0), AssertError, WRITABLE_WHILE_DRYRUN); - TEST_ERROR(storageSpoolWrite(), AssertError, WRITABLE_WHILE_DRYRUN); - - // ------------------------------------------------------------------------------------------------------------------------- - TEST_TITLE("writable storage fails when dry-run is true"); - - storageHelperDryRunInit(true); - - TEST_ERROR(storagePgIdxWrite(0), AssertError, WRITABLE_WHILE_DRYRUN); - TEST_ERROR(storageRepoIdxWrite(0), AssertError, WRITABLE_WHILE_DRYRUN); - TEST_ERROR(storageSpoolWrite(), AssertError, WRITABLE_WHILE_DRYRUN); - } - // ***************************************************************************************************************************** if (testBegin("storageNew()")) {