db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-10-30 23:37:45 +02:00
Code Issues Releases Activity

Changed some TBD comments from urgent to whenever.

Browse Source
This commit is contained in:
David Steele
2016-04-13 19:05:31 -04:00
parent 723abadb75
commit be8487dbad
6 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bin/pg_backrest
View File

@@ -80,7 +80,7 @@ eval
protocolTimeoutGet()
);
# !!! Would like to remove this check and allow a test lock
# ??? Would like to remove this check and allow a test lock
if (optionGet(OPTION_COMMAND) ne 'test' && !optionTest(OPTION_PROCESS))
{
lockAcquire(optionGet(OPTION_COMMAND), undef, true, optionGet(OPTION_PROCESS, false));

2
doc/lib/BackRestDoc/Common/DocRender.pm
View File

@@ -452,7 +452,7 @@ sub process
$strBuffer = ('#' x $iDepth) . ' `' . $oDoc->paramGet('id') . '` ' . $strTitle;
}
# Try to get the title param from the element (!!! this is the old style and should be removed)
# Try to get the title param from the element (??? this is the old style and should be removed)
my $strTitle = $oDoc->paramGet('title', false);
if (!defined($strTitle))

4
lib/BackRest/Archive.pm
View File

@@ -384,8 +384,8 @@ sub get
# If the destination file path is not absolute then it is relative to the db data path
if (index($strDestinationFile, '/',) != 0)
{
# !!! If db-path is required this is can be removed.
# !!! db-path should be added as a requirement for the remote settings work.
# ??? If db-path is required this is can be removed.
# ??? db-path should be added as a requirement for the remote settings work.
if (!optionTest(OPTION_DB_PATH))
{
confess &log(ERROR, 'option db-path must be set when relative xlog paths are used');

2
lib/BackRest/Common/Log.pm
View File

@@ -286,7 +286,7 @@ sub logDebugProcess
{
# If the parameter is a hash but not blessed then represent it as a string
# !!! This should go away once the inputs to logDebug can be changed
# ??? This should go away once the inputs to logDebug can be changed
if (ref($oValue) eq 'HASH' && !blessed($oValue))
{
$$oParamHash{$strParamName}{value} = '[hash]';

4
lib/BackRest/File.pm
View File

@@ -312,7 +312,7 @@ sub pathTypeGet
####################################################################################################################################
# pathGet
# !!! Need ot tackle the return paths in this function
# ??? Need to tackle the return paths in this function (i.e. there are to many ways to return)
####################################################################################################################################
sub pathGet
{
@@ -528,7 +528,7 @@ sub linkCreate
else
{
# If the destination path is backup and does not exist, create it
# !!! This should only happen when the link create errors
# ??? This should only happen when the link create errors
if ($bPathCreate && $self->pathTypeGet($strDestinationPathType) eq PATH_BACKUP)
{
$self->pathCreate(PATH_BACKUP_ABSOLUTE, dirname($strDestination));

2
lib/BackRest/Protocol/IO.pm
View File

@@ -202,7 +202,7 @@ sub lineRead
# Else the buffer is empty and data will need to be loaded
else
{
undef($self->{strBuffer}); # !!! Do we need this?
undef($self->{strBuffer}); # ??? Do we need this?
$self->{iBufferSize} = 0;
$self->{iBufferPos} = 0;
}