db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-07-17 01:12:23 +02:00
Code Issues Releases Activity

Add hint to check SFTP authorization log.

Browse Source 
In the case of authorization failures there many be valuable information in the log.
This commit is contained in:
Vitalii Zurian
2024-07-09 06:34:13 +02:00
committed by GitHub
parent cf8625d24b
commit ccae609402
4 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
doc/xml/release/2024/2.53.xml
View File

@ -76,6 +76,19 @@
<p>Allow alternative WAL segment sizes for PostgreSQL &amp;le; 10.</p> <p>Allow alternative WAL segment sizes for PostgreSQL &amp;le; 10.</p>
</release-item> </release-item>
<release-item>
<github-issue id="2381"/>
<github-pull-request id="2385"/>
<release-item-contributor-list>
<release-item-contributor id="vitalii.zurian"/>
<release-item-reviewer id="reid.thompson"/>
<release-item-reviewer id="david.steele"/>
</release-item-contributor-list>
<p>Add hint to check <proper>SFTP</proper> authorization log.</p>
</release-item>
</release-improvement-list> </release-improvement-list>
</release-core-list> </release-core-list>
</release> </release>

5
doc/xml/release/contributor.xml
View File

@ -1073,6 +1073,11 @@
<contributor-id type="github">ViperRu</contributor-id> <contributor-id type="github">ViperRu</contributor-id>
</contributor> </contributor>
<contributor id="vitalii.zurian">
<contributor-name-display>Vitalii Zurian</contributor-name-display>
<contributor-id type="github">thecatontheflat</contributor-id>
</contributor>
<contributor id="vitaliy.kukharik"> <contributor id="vitaliy.kukharik">
<contributor-name-display>Vitaliy Kukharik</contributor-name-display> <contributor-name-display>Vitaliy Kukharik</contributor-name-display>
<contributor-id type="github">vitabaks</contributor-id> <contributor-id type="github">vitabaks</contributor-id>

3
src/storage/sftp/storage.c
View File

@ -1343,7 +1343,8 @@ storageSftpNew(
"HINT: libssh2 compiled against non-openssl libraries requires --repo-sftp-private-key-file and" "HINT: libssh2 compiled against non-openssl libraries requires --repo-sftp-private-key-file and"
" --repo-sftp-public-key-file to be provided\n" " --repo-sftp-public-key-file to be provided\n"
"HINT: libssh2 versions before 1.9.0 expect a PEM format keypair, try ssh-keygen -m PEM -t rsa -P \"\" to" "HINT: libssh2 versions before 1.9.0 expect a PEM format keypair, try ssh-keygen -m PEM -t rsa -P \"\" to"
" generate the keypair")); " generate the keypair\n"
"HINT: check authorization log on the SFTP server"));
} }
// Init the sftp session // Init the sftp session

9
test/src/module/storage/sftpTest.c
View File

@ -240,7 +240,8 @@ testRun(void)
"HINT: libssh2 compiled against non-openssl libraries requires --repo-sftp-private-key-file and" "HINT: libssh2 compiled against non-openssl libraries requires --repo-sftp-private-key-file and"
" --repo-sftp-public-key-file to be provided\n" " --repo-sftp-public-key-file to be provided\n"
"HINT: libssh2 versions before 1.9.0 expect a PEM format keypair, try ssh-keygen -m PEM -t rsa -P \"\" to generate the" "HINT: libssh2 versions before 1.9.0 expect a PEM format keypair, try ssh-keygen -m PEM -t rsa -P \"\" to generate the"
" keypair"); " keypair\n"
"HINT: check authorization log on the SFTP server");
// ------------------------------------------------------------------------------------------------------------------------- // -------------------------------------------------------------------------------------------------------------------------
TEST_TITLE("fingerprint mismatch"); TEST_TITLE("fingerprint mismatch");
@ -586,7 +587,8 @@ testRun(void)
"HINT: libssh2 compiled against non-openssl libraries requires --repo-sftp-private-key-file and" "HINT: libssh2 compiled against non-openssl libraries requires --repo-sftp-private-key-file and"
" --repo-sftp-public-key-file to be provided\n" " --repo-sftp-public-key-file to be provided\n"
"HINT: libssh2 versions before 1.9.0 expect a PEM format keypair, try ssh-keygen -m PEM -t rsa -P \"\" to generate the" "HINT: libssh2 versions before 1.9.0 expect a PEM format keypair, try ssh-keygen -m PEM -t rsa -P \"\" to generate the"
" keypair"); " keypair\n"
"HINT: check authorization log on the SFTP server");
TEST_RESULT_BOOL( TEST_RESULT_BOOL(
unsetenv("PGBACKREST_REPO1_SFTP_PRIVATE_KEY_PASSPHRASE"), 0, "unset PGBACKREST_REPO1_SFTP_PRIVATE_KEY_PASSPHRASE"); unsetenv("PGBACKREST_REPO1_SFTP_PRIVATE_KEY_PASSPHRASE"), 0, "unset PGBACKREST_REPO1_SFTP_PRIVATE_KEY_PASSPHRASE");
@ -2036,7 +2038,8 @@ testRun(void)
"HINT: libssh2 compiled against non-openssl libraries requires --repo-sftp-private-key-file and" "HINT: libssh2 compiled against non-openssl libraries requires --repo-sftp-private-key-file and"
" --repo-sftp-public-key-file to be provided\n" " --repo-sftp-public-key-file to be provided\n"
"HINT: libssh2 versions before 1.9.0 expect a PEM format keypair, try ssh-keygen -m PEM -t rsa -P \"\" to generate the" "HINT: libssh2 versions before 1.9.0 expect a PEM format keypair, try ssh-keygen -m PEM -t rsa -P \"\" to generate the"
" keypair"); " keypair\n"
"HINT: check authorization log on the SFTP server");
TEST_RESULT_BOOL( TEST_RESULT_BOOL(
unsetenv("PGBACKREST_REPO1_SFTP_PRIVATE_KEY_PASSPHRASE"), 0, "unset PGBACKREST_REPO1_SFTP_PRIVATE_KEY_PASSPHRASE"); unsetenv("PGBACKREST_REPO1_SFTP_PRIVATE_KEY_PASSPHRASE"), 0, "unset PGBACKREST_REPO1_SFTP_PRIVATE_KEY_PASSPHRASE");