1
0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2024-12-12 10:04:14 +02:00
pgbackrest/test
David Steele e6e1122dbc Pass file by reference in manifestFileAdd().
Coverity complained that this pass by value was inefficient:

CID 376402:  Performance inefficiencies  (PASS_BY_VALUE)
Passing parameter file of type "ManifestFile" (size 136 bytes) by value.

This was completely intentional since it gives us a copy of the struct that we can change without bothering the caller. However, updating fields is fine and may benefit the caller at some future data, and in any case does no harm now.

And as usual it is easier not to fight with Coverity.
2022-02-20 16:45:07 -06:00
..
certificate Add TLS Server. 2021-10-18 14:32:41 -04:00
code-count Simplify manifest defaults. 2022-01-21 15:22:48 -05:00
data
expect Bundle files in the repository during backup. 2022-02-14 13:24:14 -06:00
lib/pgBackRestTest Bundle files in the repository during backup. 2022-02-14 13:24:14 -06:00
src Pass file by reference in manifestFileAdd(). 2022-02-20 16:45:07 -06:00
.gitignore
ci.pl Use Rocky Linux for documentation builds instead of CentOS. 2021-10-28 15:15:49 -04:00
container.yaml Fix language in rh7 test container for aarch64. 2022-01-26 13:22:31 -06:00
define.yaml Move command/backup-common tests in the command/backup module. 2022-02-18 17:50:05 -06:00
Dockerfile Add libc6-dbg required by updated valgrind to Vagrantfile/Dockerfile. 2021-10-13 09:37:03 -04:00
test.pl Use Rocky Linux for documentation builds instead of CentOS. 2021-10-28 15:15:49 -04:00
Vagrantfile Update Vagrantfile to Ubuntu 20.04. 2021-10-13 13:21:04 -04:00