mirror of
https://github.com/pgbackrest/pgbackrest.git
synced 2025-04-15 11:36:40 +02:00
ef4c4ab852
The function worked fine, but Coverity was unable to determine that the finally block was run, which led to false positives about unfreed memory. Using a boolean in the block makes it clear to Coverity that the finally block will always be run no matter what else happens. We'll depend on the compiler to optimize away the boolean if it is not used in a finally block. The cost of the boolean is fairly low in comparison to everything else being done in these macros, so it does not seem worth having a separate block even if the compiler is not able to eliminate the boolean. This reverts most of 9a271e9 that fixed a bug caused by c5b5b58, which was also attempting to help Coverity understand FINALLY() blocks.