From 12cd703e3998bb0d68fb578d79a8bd9bbf3d6ab3 Mon Sep 17 00:00:00 2001 From: Fini Jastrow Date: Thu, 22 Sep 2022 17:28:51 +0200 Subject: [PATCH] Fix Hasklug ligature removal MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [why] Entering two consecutive vertical-bars (i.e. `||`) results in the display of just one - the right - bar glyph. [how] The ligature removal is only partially implemented. The rule at work here is not removed. There are two parts at work: One rule to replace the first bar with nothing. One rule to replace the second bar with a ligarture glyph with negative left bearing, that shows two bars. The second rule has been removed, but the first is still there. This commit also removes the first rule. [note] The whole design here is broken. We remove only some rules and leave others intact, for reasons unknown to me. Other ligartures will also be only partially removed and leave the user with unreadable output. We should either remove all (!) tables and not just some, or leave the ligatures in the font. As the ligature removal has been broken at large anyhow (see previous commit), I would suggest to not remove any ligatures (anymore). Fixes: #934 Reported-by: Rádler Ákos Signed-off-by: Fini Jastrow --- src/unpatched-fonts/Hasklig/config.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/unpatched-fonts/Hasklig/config.json b/src/unpatched-fonts/Hasklig/config.json index 06809369f..579f63e54 100644 --- a/src/unpatched-fonts/Hasklig/config.json +++ b/src/unpatched-fonts/Hasklig/config.json @@ -24,4 +24,5 @@ "Single Substitution lookup 106 subtable", "Single Substitution lookup 107 subtable", "Single Substitution lookup 109 subtable", - "Single Substitution lookup 110 subtable" ] + "Single Substitution lookup 110 subtable", + "Single Substitution lookup 111 subtable" ]