[why]
The config files are called `config.json` while the contents is
INI-like. The usual extension would be `.cfg`.
[how]
We use `.cfg` already for the shell variable configuration.
Combine both config file variants into one (real) cfg file, that is
directly read by the font-patcher and no shell variables files are used
anymore.
This needs some rewrite in gotta-patch-em to get the quoting right.
To make this simpler we remove the `--debug 1` option from the variable
and insert it directly (as it is applied always anyhow).
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
At the moment we have two different config files:
config.cfg:
Is read by gotta-patch-em and allows to specify some needed
commandline options for a font-patcher run
config.json:
Is read by font-patcher and can contain ligature table removal
instructions
It would be nice to combine/unify them.
[how]
Add the possibility to add commandline options in the config.cfg
file. Of course we need commandline options to specify the config
file first, so the options are parsed in two steps.
The config.file takes precedence (if possible) over directly specified
options.
This is how the new section in the config file can look like:
[Config]
commandline: --powerlineextra --mono
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
Suggested now fonts/glyphs/set are usually closed to keep the Issue list
to real Issues and not suggestions. People should be able to further
discuss that addition in the (closed) Issue and it will be evaluated on
the next release.
Anyhow, closing the Issue automatically locks it after half a year and
no discussion is possible anymore. That was not intended.
[how]
Add new tag that keeps closed Issues unlocked and mark the addition
Issues as such.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
The font list in this has not been updated for quite some time.
There are excellent and up to date Chocolatey packages already
out there created by @sumo300
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
It can be hard to find out which license a particular font is using.
Therefore we add a new field to the fonts.json with an SPDX license
identifier (if possible).
[how]
For fonts with a license that has no SPDX identifier we use a free
`LicenseRef-*` identifier, but that reference is not solved in the
fonts.json file.
[note]
Also correct some licensing info given in the license audit.
Related: #1578
Suggested-by: Jan Christian Gruenhage <jan.christian@gruenhage.xyz>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
I guess it would be good to explicitly state that PRs should be
discussed beforehand, as the disappointment can be big if it is not even
considered for pulling. Prior discussion can also clarify some technical
things that otherwise would need laborious changes afterwards.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
The fi and fl ligs are formulated in the font to go through glyphs with
codepoint `F001` and `F002`. That is detected and overwriting that
glyphs with some (Font Awesome) icons is prevented.
The question is: What is more important, to have the fi ligature or to
have the fa-music and fa-magnifying_glass icons?
[how]
We sacrify here Font Nerdism over Icon Nerdism and remove the
ligatures before patching.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
We have two ranges of glyphs to examine:
1. `0x0000`-`0x017f` is the Latin Extended-A range
2. `0xfb00`-`0xfb06` are 'fi' and other ligatures
Both ranges are added to the essential glyphs (with their
sub-references, and with other glyphs that are referenced through
possub rules).
That is correct for range 1, but range 2 - the ligature glyphs - should
only become essential if they are indeed used for ligatures by some
rule.
For example with the UbuntuMono font, that does not have any fi ligature
natively, but it DOES have a filled `0xFB01` glyph, we would protect
that glyph and its subreferences (i.e. `0xF001`) - needlessly breaking
the Font Awesome icons in that font.
[how]
Add all glyphs of range 1 to the essential glyphs, but add glyphs of
range 2 only if they have a possub rule attached.
Reported-by: Eli Array Minkoff <eli@planetminkoff.com>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
The essential glyphs are partially based on which substitution rules
the font has.
And the config.json configuration is able to remove some substitution
rules.
So we must first possibly remove rules and then examine them, not the
other way around, because now we detect 'essential glyphs' for rules
that we later remove.
[how]
Correct order of operation.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
The glyphs can look a bit small(er) when used unscaled, for example in a
Nerd Font Propo font. Note that some icons indeed got smaller, but in
general the generated font is a bit smaller than before.
Related: #1588
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
We do not want to break the Fira progress icons, but on the other hand
these are so few icons that we can not keep the whole 0x0100 block
unoccupied.
So we just leave a small gap in the FontAwesome codepoints.
[how]
Be careful, the current code moves the icons 'to the back', which will
be different if we ever update FontAwesome. The code will break
(reassign a lot codepoints) then.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
Previously we had icons with an open screen and a button, now it is
filled.
[how]
Swap the icons with the open icons at completely different codepoints.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
F1DB had an open circle, called circle-thin.
That must now come from the regular set.
Unfortunaly circle_o at F10C already is also the same regular set icon.
And we try to prefer the solid set if a regular set has been used
already.
[how]
Add one specific exception to the rule :-(
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
youtube and cloudsmith should change their codepoints, because youtube
occupies a 'lesser' youtube codepoint and yields a 'better' codepoint to
cloudsmith.
Better means the icon looks more like in FA 4.
Also swap the devices icons that in 4 showed a screen and now it is
filled.
[how]
The mechanics is a bit ... ugly.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
When creating the renaming table the wrong number has been entered
(twice the same).
[how]
Correct the renaming thereby making the renamed icon visible.
The icon that has been 'kicked out' is moved to the end of the patched
block.
New:
F0E6 F0E6 regular/comments.svg
Moved:
F374 EFC2 brands/avianex.svg (was previously on F0E6)
Renamed:
RENAME comments_o to comment_o (F0E5)
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
The open variants of circle_xmark and circle_check are missing.
[how]
Rename the filled versions to their old (i.e. FA 4.2) names
(remove_sign and ok_sign) and let the open (regular) variants
find their place automatically.
Because we now have two more icons that would move all codepoints we can
either drop the icons that occupied the circle_xmark and circle_check
codepoints before, or we move the to the end (unpatched yet) region.
As these are just some more arrows, we drop them.
Dropped:
F30B F05C solid/right-long.svg
F30C F05D solid/up-long.svg
New:
F05C F05C regular/circle-xmark.svg
F05D F05D regular/circle-check.svg
Renamed:
RENAME circle_xmark to remove_sign (F057)
RENAME circle_check to ok_sign (F058)
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
With commit
23a14f184 Update Terminus to 4.49.3
we dropped the subdirectory structure of Terminus, but forgot to remove
that structure in the patched-fonts/ directory. The release will clear
the destination directory but not remove subdirectories, so we end up
with the 3.1.1 and 3.2.0 patched font files in the repo.
Luckily this is catched by the archiver process:
[Nerd Fonts] Limiting archive to pattern 'Terminus'
[Nerd Fonts] Packing Terminus.tar.xz (24 fonts)
[Nerd Fonts] Did not pack expected number of font files! Likely same font names for different paths.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
Has double entries.
This has been detected by generate-css that got that check recently.
[how]
Use new generator script.
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
