Merge pull request #265 from Oarcinae/255-make-moat-enable-be-the-default-setting-on-the-spawn-gui

Default to moat enabled in spawn choices.

changelog.txt

@@ -6,6 +6,7 @@ Date: ????
   Changes:
     - Stop regrowth deleting cargo pods at center of map. (By marking the center chunks as permanent.)
     - Change surface regrowth checkboxes to be enabled/disabled by the global setting to make it obvious that they are dependent on the global setting.
+    - Change moat selection to enabled by default.
   Bugfixes:
     - Fix regrowth surface setting not respecting previous setting state when surface is first created.
     - Remove offline enemy attack error messages. (Not really a bug, just false error messages.)

lib/separate_spawns_guis.lua

@@ -286,7 +286,7 @@ function CreateSpawnSettingsFrame(parent_flow, gameplay)
             tags = { action = "oarc_spawn_options", setting = "moat_option" },
             type = "checkbox",
             caption = { "oarc-moat-option" },
-            state = false,
+            state = true, -- Default to true
             tooltip = { "oarc-moat-option-tooltip" }
         }
     end
@@ -609,11 +609,11 @@ function DisplaySpawnOptions(player)
     end
     ---@type OarcSpawnChoices
     local spawn_choices_entry = {
-        surface_name = storage.ocfg.gameplay.default_surface,
+        surface_name = gameplay.default_surface,
         team = default_team,
-        moat = false, --storage.ocfg.gameplay.allow_moats_around_spawns TODO: Change default
+        moat = gameplay.allow_moats_around_spawns,
         buddy = nil,
-        distance = storage.ocfg.gameplay.near_spawn_distance,
+        distance = gameplay.near_spawn_distance,
         host = nil,
         buddy_team = false
     }