FACTO-256: Cleanup unused variables, map settings, and organized map

mod settings

control.lua

@@ -18,7 +18,6 @@
 local ChunkPropertyUtils = require("libs/ChunkPropertyUtils")
 local UnitUtils = require("libs/UnitUtils")
 local BaseUtils = require("libs/BaseUtils")
-local MathUtils = require("libs/MathUtils")
 local Processor = require("libs/Processor")
 local Constants = require("libs/Constants")
 local MapUtils = require("libs/MapUtils")
@@ -51,12 +50,6 @@ local PLAYER_PHEROMONE = Constants.PLAYER_PHEROMONE
 
 local UNIT_DEATH_POINT_COST = Constants.UNIT_DEATH_POINT_COST
 
-local PENDING_UPGRADE_CREATION_THESHOLD = Constants.PENDING_UPGRADE_CREATION_THESHOLD
-
-local MAX_HIVE_TTL = Constants.MAX_HIVE_TTL
-local MIN_HIVE_TTL = Constants.MIN_HIVE_TTL
-local DEV_HIVE_TTL = Constants.DEV_HIVE_TTL
-
 local SETTLE_CLOUD_WARMUP = Constants.SETTLE_CLOUD_WARMUP
 
 -- imported functions
@@ -75,9 +68,6 @@ local nextMap = MapUtils.nextMap
 
 local processClouds = Processor.processClouds
 
-local distortPosition = MathUtils.distortPosition
-local linearInterpolation = MathUtils.linearInterpolation
-local gaussianRandomRangeRG = MathUtils.gaussianRandomRangeRG
 local prepMap = MapUtils.prepMap
 local activateMap = MapUtils.activateMap
 

libs/Processor.lua

@@ -39,7 +39,6 @@ local MathUtils = require("MathUtils")
 
 local CHUNK_SIZE = Constants.CHUNK_SIZE
 local EIGHTH_CHUNK_SIZE = Constants.EIGHTH_CHUNK_SIZE
-local HALF_CHUNK_SIZE = Constants.HALF_CHUNK_SIZE
 
 local PLAYER_PHEROMONE_GENERATOR_AMOUNT = Constants.PLAYER_PHEROMONE_GENERATOR_AMOUNT
 

libs/Squad.lua

@@ -41,7 +41,6 @@ local BASE_AI_STATE_ONSLAUGHT = Constants.BASE_AI_STATE_ONSLAUGHT
 local BASE_AI_STATE_RAIDING = Constants.BASE_AI_STATE_RAIDING
 local MAGIC_MAXIMUM_NUMBER = Constants.MAGIC_MAXIMUM_NUMBER
 local MINIMUM_EXPANSION_DISTANCE = Constants.MINIMUM_EXPANSION_DISTANCE
-local PLAYER_PHEROMONE_GENERATOR_THRESHOLD = Constants.PLAYER_PHEROMONE_GENERATOR_THRESHOLD
 local COMMAND_TIMEOUT = Constants.COMMAND_TIMEOUT
 local PLAYER_PHEROMONE = Constants.PLAYER_PHEROMONE
 local BASE_PHEROMONE = Constants.BASE_PHEROMONE

libs/Upgrade.lua

@@ -531,21 +531,6 @@ function Upgrade.attempt()
 
         game.forces.enemy.kill_all_units()
 
-        game.map_settings.path_finder.min_steps_to_check_path_find_termination =
-            Constants.PATH_FINDER_MIN_STEPS_TO_CHECK_PATH
-
-        game.map_settings.unit_group.min_group_radius = Constants.UNIT_GROUP_MAX_RADIUS * 0.5
-        game.map_settings.unit_group.max_group_radius = Constants.UNIT_GROUP_MAX_RADIUS
-
-        game.map_settings.unit_group.max_member_speedup_when_behind = Constants.UNIT_GROUP_MAX_SPEED_UP
-        game.map_settings.unit_group.max_member_slowdown_when_ahead = Constants.UNIT_GROUP_MAX_SLOWDOWN
-        game.map_settings.unit_group.max_group_slowdown_factor = Constants.UNIT_GROUP_SLOWDOWN_FACTOR
-
-        game.map_settings.max_failed_behavior_count = 3
-        game.map_settings.unit_group.member_disown_distance = 10
-        game.map_settings.unit_group.tick_tolerance_when_member_arrives = 60
-        game.forces.enemy.ai_controllable = true
-
         Universe.evolutionLevel = game.forces.enemy.evolution_factor
 
         Universe.random = game.create_random_generator(Constants.ENEMY_SEED)

locale/en/locale.cfg

@@ -120,7 +120,7 @@ rampant--deadZoneFrequency=World: Enemy deadzone frequency
 rampant--newEnemyVariations=World: Enemy Variations
 rampant--enableBobsUnits=World: Enable Bobs as a faction
 rampant--enableNEUnits=World: Enable NE as a faction
-rampant--disallowFriendlyFire=Safety: Disallow Friendly Fire Splash Damage
+rampant--disallowFriendlyFire=Safety: Disable Friendly Fire Splash Damage
 rampant--tierStart=World: Beginning enemy level
 rampant--tierEnd=World: Ending enemy level
 rampant--enableMigration=AI: Enable Migration
@@ -172,7 +172,7 @@ rampant--siegeAIToggle=AI: Enable Siege AI
 rampant--laserEnemy=World: Laser Biter Faction
 rampant--waspEnemy=World: Wasp Biter Faction
 rampant--spawnerEnemy=World: Spawner Biter Faction
-rampant--trollEnemy=World: Regenerative Biter Faction
+rampant--trollEnemy=World: Regenerativde Biter Faction
 rampant--fastEnemy=World: Fast Biter Faction
 rampant--infernoEnemy=World: Inferno Biter Faction
 rampant--nuclearEnemy=World: Nuclear Biter Faction
@@ -201,9 +201,8 @@ rampant--energyThiefTints=World: Sapper Biter Faction Colors
 rampant--poisonTints=World: Poison Biter Faction Colors
 
 rampant--disableCollidingProjectiles=Projectiles: Non biter force colliding projectiles
-rampant--enableFullMapScan=Compatibility: Enable full map scanning
-rampant--unitAndSpawnerFadeTime=Biter, Spitter, Worm, Nest, and Hive Corpse Fade Time
-rampant--enableFadeTime=Enable corpse fade time
+rampant--unitAndSpawnerFadeTime=World: Biter, Spitter, Worm, Nest, and Hive Corpse Fade Time
+rampant--enableFadeTime=World: Enable corpse fade time
 rampant--temperamentRateModifier=AI: Temperament Rate Modifier
 rampant--enableLandfillOnDeath=World: Enemies fill water on death
 
@@ -328,7 +327,6 @@ rampant--energyThiefTints=All colors should have 8 hex characters rrggbbaa, firs
 rampant--poisonTints=All colors should have 8 hex characters rrggbbaa, first color is the base color, second color is the tinting color, third color is the hives color
 
 rampant--disableCollidingProjectiles=Biter projectiles no longer collide with other biters, worms or nests. Everything else still collides with biter projectiles.
-rampant--enableFullMapScan=This setting causes the game map to slowly be scanned for entities created or destroyed outside of the factorio event system. (If a mod isnt using script_raised_built or script_raised_destroyed this will cause Rampant to still eventually be consistent with the game map)
 
 rampant--enableFadeTime=Enable the fade time to reduce or increase biter, spitter, worm, spawner, and hive. If disabled, no alterations are made to corpse times.
 

settings.lua

@@ -280,18 +280,6 @@ data:extend({
             per_user = false
         },
 
-        -- {
-        --     type = "double-setting",
-        --     name = "rampant--deadZoneFrequency",
-        --     description = "rampant--deadZoneFrequency",
-        --     setting_type = "runtime-global",
-        --     default_value = 0.1,
-        --     minimum_value = 0.0,
-        --     maximum_value = 1.0,
-        --     order = "d[modifier]-a[ai]",
-        --     per_user = false
-        -- },
-
         {
             type = "bool-setting",
             name = "rampant--newEnemies",
@@ -526,7 +514,7 @@ data:extend({
             name = "rampant--enabledPurpleSettlerCloud",
             setting_type = "runtime-global",
             default_value = true,
-            order = "m[total]-c[ai]",
+            order = "d[modifier]-a[ai]",
             per_user = false
         },
 
@@ -612,7 +600,7 @@ data:extend({
             description = "rampant--legacyChunkScanning",
             setting_type = "runtime-global",
             default_value = false,
-            order = "m[total]-c[ai]z",
+            order = "d[modifier]-a[ai]z",
             per_user = false
         },
 
@@ -624,7 +612,7 @@ data:extend({
             minimum_value = -1,
             default_value = 60,
             maximum_value = 600,
-            order = "m[total]-c[ai]z",
+            order = "d[modifier]-a[ai]z",
             per_user = false
         },