games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-07-17 01:32:21 +02:00
Code Issues Releases Activity

Merge pull request #2485 from IvanSavenko/hotfix

Browse Source 
Hotfix for issues discovered in 1.3
This commit is contained in:
Ivan Savenko
2023-08-05 20:55:11 +03:00
committed by GitHub
parent b9729241f1 c8ec0d5419
commit 06b0ebf08c
14 changed files with 82 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CMakePresets.json
View File

@ -240,7 +240,7 @@
"default-release" "default-release"
], ],
"cacheVariables": { "cacheVariables": {
"CMAKE_BUILD_TYPE": "Release" "CMAKE_BUILD_TYPE": "RelWithDebInfo"
} }
} }
], ],

2
Mods/vcmi/mod.json
View File

@ -78,7 +78,7 @@
] ]
}, },
"version" : "1.2", "version" : "1.3",
"author" : "VCMI Team", "author" : "VCMI Team",
"contact" : "http://forum.vcmi.eu/index.php", "contact" : "http://forum.vcmi.eu/index.php",
"modType" : "Graphical", "modType" : "Graphical",

2
android/vcmi-app/build.gradle
View File

@ -10,7 +10,7 @@ android {
applicationId "is.xyz.vcmi" applicationId "is.xyz.vcmi"
minSdk 19 minSdk 19
targetSdk 31 targetSdk 31
versionCode 1301 versionCode 1302
versionName "1.3.0" versionName "1.3.0"
setProperty("archivesBaseName", "vcmi") setProperty("archivesBaseName", "vcmi")
} }

7
android/vcmi-app/src/main/java/eu/vcmi/vcmi/ActivityMods.java
View File

@ -182,10 +182,17 @@ public class ActivityMods extends ActivityWithToolbar
public void onSuccess(ServerResponse<List<VCMIMod>> response) public void onSuccess(ServerResponse<List<VCMIMod>> response)
{ {
Log.i(this, "Initialized mods repo"); Log.i(this, "Initialized mods repo");
if (mModContainer == null)
{
handleNoData();
}
else
{
mModContainer.updateFromRepo(response.mContent); mModContainer.updateFromRepo(response.mContent);
mModsAdapter.updateModsList(mModContainer.submods()); mModsAdapter.updateModsList(mModContainer.submods());
mProgress.setVisibility(View.GONE); mProgress.setVisibility(View.GONE);
} }
}
@Override @Override
public void onError(final int code) public void onError(final int code)

8
client/NetPacksClient.cpp
View File

@ -95,6 +95,14 @@ void callAllInterfaces(CClient & cl, void (T::*ptr)(Args...), Args2 && ...args)
template<typename T, typename ... Args, typename ... Args2> template<typename T, typename ... Args, typename ... Args2>
void callBattleInterfaceIfPresentForBothSides(CClient & cl, void (T::*ptr)(Args...), Args2 && ...args) void callBattleInterfaceIfPresentForBothSides(CClient & cl, void (T::*ptr)(Args...), Args2 && ...args)
{ {
assert(cl.gameState()->curB);
if (!cl.gameState()->curB)
{
logGlobal->error("Attempt to call battle interface without ongoing battle!");
return;
}
callOnlyThatBattleInterface(cl, cl.gameState()->curB->sides[0].color, ptr, std::forward<Args2>(args)...); callOnlyThatBattleInterface(cl, cl.gameState()->curB->sides[0].color, ptr, std::forward<Args2>(args)...);
callOnlyThatBattleInterface(cl, cl.gameState()->curB->sides[1].color, ptr, std::forward<Args2>(args)...); callOnlyThatBattleInterface(cl, cl.gameState()->curB->sides[1].color, ptr, std::forward<Args2>(args)...);
if(settings["session"]["spectate"].Bool() && !settings["session"]["spectate-skip-battle"].Bool() && LOCPLINT->battleInt) if(settings["session"]["spectate"].Bool() && !settings["session"]["spectate-skip-battle"].Bool() && LOCPLINT->battleInt)

14
client/render/Graphics.cpp
View File

@ -299,3 +299,17 @@ void Graphics::initializeImageLists()
addImageListEntries(CGI->spells()); addImageListEntries(CGI->spells());
addImageListEntries(CGI->skills()); addImageListEntries(CGI->skills());
} }
std::shared_ptr<CAnimation> Graphics::getAnimation(const std::string & path)
{
ResourceID animationPath(path, EResType::ANIMATION);
if (cachedAnimations.count(animationPath.getName()) != 0)
return cachedAnimations.at(animationPath.getName());
auto newAnimation = std::make_shared<CAnimation>(animationPath.getName());
newAnimation->preload();
cachedAnimations[animationPath.getName()] = newAnimation;
return newAnimation;
}

4
client/render/Graphics.h
View File

@ -47,7 +47,11 @@ class Graphics
void loadFonts(); void loadFonts();
void initializeImageLists(); void initializeImageLists();
std::map<std::string, std::shared_ptr<CAnimation>> cachedAnimations;
public: public:
std::shared_ptr<CAnimation> getAnimation(const std::string & path);
//Fonts //Fonts
static const int FONTS_NUMBER = 9; static const int FONTS_NUMBER = 9;
std::array< std::shared_ptr<IFont>, FONTS_NUMBER> fonts; std::array< std::shared_ptr<IFont>, FONTS_NUMBER> fonts;

4
client/widgets/CGarrisonInt.cpp
View File

@ -422,10 +422,10 @@ CGarrisonSlot::CGarrisonSlot(CGarrisonInt * Owner, int x, int y, SlotID IID, EGa
std::string imgName = owner->smallIcons ? "cprsmall" : "TWCRPORT"; std::string imgName = owner->smallIcons ? "cprsmall" : "TWCRPORT";
creatureImage = std::make_shared<CAnimImage>(imgName, 0); creatureImage = std::make_shared<CAnimImage>(graphics->getAnimation(imgName), 0);
creatureImage->disable(); creatureImage->disable();
selectionImage = std::make_shared<CAnimImage>(imgName, 1); selectionImage = std::make_shared<CAnimImage>(graphics->getAnimation(imgName), 1);
selectionImage->disable(); selectionImage->disable();
if(Owner->smallIcons) if(Owner->smallIcons)

41
client/widgets/MiscWidgets.cpp
View File

@ -18,6 +18,7 @@
#include "../CPlayerInterface.h" #include "../CPlayerInterface.h"
#include "../CGameInfo.h" #include "../CGameInfo.h"
#include "../widgets/TextControls.h" #include "../widgets/TextControls.h"
#include "../widgets/CGarrisonInt.h"
#include "../windows/CCastleInterface.h" #include "../windows/CCastleInterface.h"
#include "../windows/InfoWindows.h" #include "../windows/InfoWindows.h"
#include "../render/Canvas.h" #include "../render/Canvas.h"
@ -303,28 +304,30 @@ CHeroTooltip::CHeroTooltip(Point pos, const CGHeroInstance * hero):
init(InfoAboutHero(hero, InfoAboutHero::EInfoLevel::DETAILED)); init(InfoAboutHero(hero, InfoAboutHero::EInfoLevel::DETAILED));
} }
CInteractableHeroTooltip::CInteractableHeroTooltip(Point pos, const CGHeroInstance * hero): CInteractableHeroTooltip::CInteractableHeroTooltip(Point pos, const CGHeroInstance * hero)
CGarrisonInt(pos + Point(0, 73), 4, Point(0, 0), hero, nullptr, true, true, CGarrisonInt::ESlotsLayout::REVERSED_TWO_ROWS)
{ {
init(InfoAboutHero(hero, InfoAboutHero::EInfoLevel::DETAILED)); init(InfoAboutHero(hero, InfoAboutHero::EInfoLevel::DETAILED));
OBJECT_CONSTRUCTION_CAPTURING(255-DISPOSE);
garrison = std::make_shared<CGarrisonInt>(pos + Point(0, 73), 4, Point(0, 0), hero, nullptr, true, true, CGarrisonInt::ESlotsLayout::REVERSED_TWO_ROWS);
} }
void CInteractableHeroTooltip::init(const InfoAboutHero & hero) void CInteractableHeroTooltip::init(const InfoAboutHero & hero)
{ {
OBJECT_CONSTRUCTION_CAPTURING(255-DISPOSE); OBJECT_CONSTRUCTION_CAPTURING(255-DISPOSE);
portrait = std::make_shared<CAnimImage>("PortraitsLarge", hero.portrait, 0, 3, 2-73); portrait = std::make_shared<CAnimImage>("PortraitsLarge", hero.portrait, 0, 3, 2);
title = std::make_shared<CLabel>(66, 2-73, FONT_SMALL, ETextAlignment::TOPLEFT, Colors::WHITE, hero.name); title = std::make_shared<CLabel>(66, 2, FONT_SMALL, ETextAlignment::TOPLEFT, Colors::WHITE, hero.name);
if(hero.details) if(hero.details)
{ {
for(size_t i = 0; i < hero.details->primskills.size(); i++) for(size_t i = 0; i < hero.details->primskills.size(); i++)
labels.push_back(std::make_shared<CLabel>(75 + 28 * (int)i, 58-73, FONT_SMALL, ETextAlignment::CENTER, Colors::WHITE, labels.push_back(std::make_shared<CLabel>(75 + 28 * (int)i, 58, FONT_SMALL, ETextAlignment::CENTER, Colors::WHITE,
std::to_string(hero.details->primskills[i]))); std::to_string(hero.details->primskills[i])));
labels.push_back(std::make_shared<CLabel>(158, 98-73, FONT_TINY, ETextAlignment::CENTER, Colors::WHITE, std::to_string(hero.details->mana))); labels.push_back(std::make_shared<CLabel>(158, 98, FONT_TINY, ETextAlignment::CENTER, Colors::WHITE, std::to_string(hero.details->mana)));
morale = std::make_shared<CAnimImage>("IMRL22", hero.details->morale + 3, 0, 5, 74-73); morale = std::make_shared<CAnimImage>("IMRL22", hero.details->morale + 3, 0, 5, 74);
luck = std::make_shared<CAnimImage>("ILCK22", hero.details->luck + 3, 0, 5, 91-73); luck = std::make_shared<CAnimImage>("ILCK22", hero.details->luck + 3, 0, 5, 91);
} }
} }
@ -383,9 +386,11 @@ CTownTooltip::CTownTooltip(Point pos, const CGTownInstance * town)
} }
CInteractableTownTooltip::CInteractableTownTooltip(Point pos, const CGTownInstance * town) CInteractableTownTooltip::CInteractableTownTooltip(Point pos, const CGTownInstance * town)
: CGarrisonInt(pos + Point(0, 73), 4, Point(0, 0), town->getUpperArmy(), nullptr, true, true, CGarrisonInt::ESlotsLayout::REVERSED_TWO_ROWS)
{ {
init(InfoAboutTown(town, true)); init(InfoAboutTown(town, true));
OBJECT_CONSTRUCTION_CAPTURING(255-DISPOSE);
garrison = std::make_shared<CGarrisonInt>(pos + Point(0, 73), 4, Point(0, 0), town->getUpperArmy(), nullptr, true, true, CGarrisonInt::ESlotsLayout::REVERSED_TWO_ROWS);
} }
void CInteractableTownTooltip::init(const InfoAboutTown & town) void CInteractableTownTooltip::init(const InfoAboutTown & town)
@ -395,37 +400,37 @@ void CInteractableTownTooltip::init(const InfoAboutTown & town)
//order of icons in def: fort, citadel, castle, no fort //order of icons in def: fort, citadel, castle, no fort
size_t fortIndex = town.fortLevel ? town.fortLevel - 1 : 3; size_t fortIndex = town.fortLevel ? town.fortLevel - 1 : 3;
fort = std::make_shared<CAnimImage>("ITMCLS", fortIndex, 0, 105, 31-73); fort = std::make_shared<CAnimImage>("ITMCLS", fortIndex, 0, 105, 31);
assert(town.tType); assert(town.tType);
size_t iconIndex = town.tType->clientInfo.icons[town.fortLevel > 0][town.built >= CGI->settings()->getInteger(EGameSettings::TOWNS_BUILDINGS_PER_TURN_CAP)]; size_t iconIndex = town.tType->clientInfo.icons[town.fortLevel > 0][town.built >= CGI->settings()->getInteger(EGameSettings::TOWNS_BUILDINGS_PER_TURN_CAP)];
build = std::make_shared<CAnimImage>("itpt", iconIndex, 0, 3, 2-73); build = std::make_shared<CAnimImage>("itpt", iconIndex, 0, 3, 2);
title = std::make_shared<CLabel>(66, 2-73, FONT_SMALL, ETextAlignment::TOPLEFT, Colors::WHITE, town.name); title = std::make_shared<CLabel>(66, 2, FONT_SMALL, ETextAlignment::TOPLEFT, Colors::WHITE, town.name);
if(town.details) if(town.details)
{ {
hall = std::make_shared<CAnimImage>("ITMTLS", town.details->hallLevel, 0, 67, 31-73); hall = std::make_shared<CAnimImage>("ITMTLS", town.details->hallLevel, 0, 67, 31);
if(town.details->goldIncome) if(town.details->goldIncome)
{ {
income = std::make_shared<CLabel>(157, 58-73, FONT_TINY, ETextAlignment::CENTER, Colors::WHITE, income = std::make_shared<CLabel>(157, 58, FONT_TINY, ETextAlignment::CENTER, Colors::WHITE,
std::to_string(town.details->goldIncome)); std::to_string(town.details->goldIncome));
} }
if(town.details->garrisonedHero) //garrisoned hero icon if(town.details->garrisonedHero) //garrisoned hero icon
garrisonedHero = std::make_shared<CPicture>("TOWNQKGH", 149, 76-73); garrisonedHero = std::make_shared<CPicture>("TOWNQKGH", 149, 76);
if(town.details->customRes)//silo is built if(town.details->customRes)//silo is built
{ {
if(town.tType->primaryRes == EGameResID::WOOD_AND_ORE )// wood & ore if(town.tType->primaryRes == EGameResID::WOOD_AND_ORE )// wood & ore
{ {
res1 = std::make_shared<CAnimImage>("SMALRES", GameResID(EGameResID::WOOD), 0, 7, 75-73); res1 = std::make_shared<CAnimImage>("SMALRES", GameResID(EGameResID::WOOD), 0, 7, 75);
res2 = std::make_shared<CAnimImage>("SMALRES", GameResID(EGameResID::ORE), 0, 7, 88-73); res2 = std::make_shared<CAnimImage>("SMALRES", GameResID(EGameResID::ORE), 0, 7, 88);
} }
else else
{ {
res1 = std::make_shared<CAnimImage>("SMALRES", town.tType->primaryRes, 0, 7, 81-73); res1 = std::make_shared<CAnimImage>("SMALRES", town.tType->primaryRes, 0, 7, 81);
} }
} }
} }

8
client/widgets/MiscWidgets.h
View File

@ -10,7 +10,6 @@
#pragma once #pragma once
#include "../gui/CIntObject.h" #include "../gui/CIntObject.h"
#include "CGarrisonInt.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -22,6 +21,7 @@ class AFactionMember;
VCMI_LIB_NAMESPACE_END VCMI_LIB_NAMESPACE_END
class CLabel; class CLabel;
class CGarrisonInt;
class CCreatureAnim; class CCreatureAnim;
class CComponent; class CComponent;
class CAnimImage; class CAnimImage;
@ -82,13 +82,14 @@ public:
}; };
/// Class for HD mod-like interactable infobox tooltip. Does not have any background! /// Class for HD mod-like interactable infobox tooltip. Does not have any background!
class CInteractableHeroTooltip : public CGarrisonInt class CInteractableHeroTooltip : public CIntObject
{ {
std::shared_ptr<CLabel> title; std::shared_ptr<CLabel> title;
std::shared_ptr<CAnimImage> portrait; std::shared_ptr<CAnimImage> portrait;
std::vector<std::shared_ptr<CLabel>> labels; std::vector<std::shared_ptr<CLabel>> labels;
std::shared_ptr<CAnimImage> morale; std::shared_ptr<CAnimImage> morale;
std::shared_ptr<CAnimImage> luck; std::shared_ptr<CAnimImage> luck;
std::shared_ptr<CGarrisonInt> garrison;
void init(const InfoAboutHero & hero); void init(const InfoAboutHero & hero);
public: public:
@ -115,7 +116,7 @@ public:
}; };
/// Class for HD mod-like interactable infobox tooltip. Does not have any background! /// Class for HD mod-like interactable infobox tooltip. Does not have any background!
class CInteractableTownTooltip : public CGarrisonInt class CInteractableTownTooltip : public CIntObject
{ {
std::shared_ptr<CLabel> title; std::shared_ptr<CLabel> title;
std::shared_ptr<CAnimImage> fort; std::shared_ptr<CAnimImage> fort;
@ -125,6 +126,7 @@ class CInteractableTownTooltip : public CGarrisonInt
std::shared_ptr<CPicture> garrisonedHero; std::shared_ptr<CPicture> garrisonedHero;
std::shared_ptr<CAnimImage> res1; std::shared_ptr<CAnimImage> res1;
std::shared_ptr<CAnimImage> res2; std::shared_ptr<CAnimImage> res2;
std::shared_ptr<CGarrisonInt> garrison;
void init(const InfoAboutTown & town); void init(const InfoAboutTown & town);
public: public:

2
config/schemas/settings.json
View File

@ -201,8 +201,6 @@
}, },
"targetfps" : { "targetfps" : {
"type" : "number", "type" : "number",
"defaultIOS" : 30, // reduce battery usage
"defaultAndroid" : 30, // reduce battery usage
"default" : 60 "default" : 60
} }
} }

2
lib/CHeroHandler.cpp
View File

@ -770,7 +770,7 @@ std::vector<bool> CHeroHandler::getDefaultAllowed() const
for(const CHero * hero : objects) for(const CHero * hero : objects)
{ {
allowedHeroes.push_back(!hero->special); allowedHeroes.push_back(hero && !hero->special);
} }
return allowedHeroes; return allowedHeroes;

8
lib/JsonNode.cpp
View File

@ -829,7 +829,13 @@ std::shared_ptr<Bonus> JsonUtils::parseBonus(const JsonNode &ability)
auto b = std::make_shared<Bonus>(); auto b = std::make_shared<Bonus>();
if (!parseBonus(ability, b.get())) if (!parseBonus(ability, b.get()))
{ {
return nullptr; // caller code can not handle this case and presumes that returned bonus is always valid
logGlobal->error("Failed to parse bonus! Json config was %S ", ability.toJson());
b->type = BonusType::NONE;
assert(0); // or throw? Game *should* work with dummy bonus
return b;
} }
return b; return b;
} }

10
server/NetPacksServer.cpp
View File

@ -282,24 +282,24 @@ void ApplyGhNetPackVisitor::visitMakeAction(MakeAction & pack)
{ {
const BattleInfo * b = gs.curB; const BattleInfo * b = gs.curB;
if(!b) if(!b)
gh.throwNotAllowedAction(&pack); gh.throwAndComplain(&pack, "Can not make action - there is no battle ongoing!");
if(b->tacticDistance) if(b->tacticDistance)
{ {
if(pack.ba.actionType != EActionType::WALK && pack.ba.actionType != EActionType::END_TACTIC_PHASE if(pack.ba.actionType != EActionType::WALK && pack.ba.actionType != EActionType::END_TACTIC_PHASE
&& pack.ba.actionType != EActionType::RETREAT && pack.ba.actionType != EActionType::SURRENDER) && pack.ba.actionType != EActionType::RETREAT && pack.ba.actionType != EActionType::SURRENDER)
gh.throwNotAllowedAction(&pack); gh.throwAndComplain(&pack, "Can not make actions while in tactics mode!");
if(!vstd::contains(gh.connections[b->sides[b->tacticsSide].color], pack.c)) if(!vstd::contains(gh.connections[b->sides[b->tacticsSide].color], pack.c))
gh.throwNotAllowedAction(&pack); gh.throwAndComplain(&pack, "Can not make actions in battles you are not part of!");
} }
else else
{ {
auto active = b->battleActiveUnit(); auto active = b->battleActiveUnit();
if(!active) if(!active)
gh.throwNotAllowedAction(&pack); gh.throwAndComplain(&pack, "No active unit in battle!");
auto unitOwner = b->battleGetOwner(active); auto unitOwner = b->battleGetOwner(active);
if(!vstd::contains(gh.connections[unitOwner], pack.c)) if(!vstd::contains(gh.connections[unitOwner], pack.c))
gh.throwNotAllowedAction(&pack); gh.throwAndComplain(&pack, "Can not make actions in battles you are not part of!");
} }
result = gh.makeBattleAction(pack.ba); result = gh.makeBattleAction(pack.ba);