games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-12-03 23:19:22 +02:00
Code Issues Releases Activity

CBattleInfoCallback.cpp comment: point to fix #6016 for the graceful error log

Browse Source
This commit is contained in:
Mircea TheHonestCTO
2025-09-01 05:02:34 +02:00
parent 13bd7ed8f4
commit 0efd7ea47c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/battle/CBattleInfoCallback.cpp
View File

@@ -1409,7 +1409,7 @@ AttackableTiles CBattleInfoCallback::getPotentiallyAttackableHexes(
if (!vstd::contains(defender->getSurroundingHexes(defenderPos), attackOriginHex)) if (!vstd::contains(defender->getSurroundingHexes(defenderPos), attackOriginHex))
{ {
// TODO: GrafDeVan/Mircea/Ivan/Dydzio added this quick fix, but the core issue should be fixed // Fixed in #6016 but left as a graceful error log instead of a runtime exception that crashes
logGlobal->error( logGlobal->error(
"Attempt to attack from invalid position! defenderPos (%d, %d) attackOriginHex (%d, %d)", "Attempt to attack from invalid position! defenderPos (%d, %d) attackOriginHex (%d, %d)",
defenderPos.getX(), defenderPos.getX(),