games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-25 22:42:04 +02:00
Code Issues Releases Activity

code review

Browse Source
This commit is contained in:
Laserlicht
2024-11-14 00:34:39 +01:00
committed by GitHub
parent 0e5711f8bf
commit 0f94f35dcf
5 changed files with 44 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
client/lobby/SelectionTab.cpp
View File

@@ -282,9 +282,12 @@ void SelectionTab::toggleMode()
}
case ESelectionScreen::loadGame:
inputName->disable();
parseSaves(getFiles("Saves/", EResType::SAVEGAME));
break;
{
inputName->disable();
auto unsupported = parseSaves(getFiles("Saves/", EResType::SAVEGAME));
handleUnsupportedSavegames(unsupported);
break;
}
case ESelectionScreen::saveGame:
parseSaves(getFiles("Saves/", EResType::SAVEGAME));
@@ -876,16 +879,9 @@ void SelectionTab::parseMaps(const std::unordered_set<ResourcePath> & files)
}
}
void SelectionTab::parseSaves(const std::unordered_set<ResourcePath> & files)
std::vector<ResourcePath> SelectionTab::parseSaves(const std::unordered_set<ResourcePath> & files)
{
enum Choice { NONE, REMAIN, DELETE };
Choice deleteUnsupported = NONE;
auto doDeleteUnsupported = [](std::string file){
LobbyDelete ld;
ld.type = LobbyDelete::SAVEGAME;
ld.name = file;
CSH->sendLobbyPack(ld);
};
std::vector<ResourcePath> unsupported;
for(auto & file : files)
{
@@ -925,32 +921,36 @@ void SelectionTab::parseSaves(const std::unordered_set<ResourcePath> & files)
allItems.push_back(mapInfo);
}
catch(const IdentifierResolutionException & e)
{
logGlobal->error("Error: Failed to process %s: %s", file.getName(), e.what());
}
catch(const std::exception & e)
{
// asking for deletion of unsupported saves
if(CSH->isHost())
{
if(deleteUnsupported == DELETE)
doDeleteUnsupported(file.getName());
else if(deleteUnsupported == NONE)
{
CInfoWindow::showYesNoDialog(CGI->generaltexth->translate("vcmi.lobby.deleteUnsupportedSave"), std::vector<std::shared_ptr<CComponent>>(), [&deleteUnsupported, doDeleteUnsupported, file](){
doDeleteUnsupported(file.getName());
deleteUnsupported = DELETE;
}, [&deleteUnsupported](){ deleteUnsupported = REMAIN; });
while(deleteUnsupported == NONE)
{
auto unlockInterface = vstd::makeUnlockGuard(GH.interfaceMutex);
boost::this_thread::sleep_for(boost::chrono::milliseconds(5));
}
}
}
if(deleteUnsupported != DELETE)
logGlobal->error("Error: Failed to process %s: %s", file.getName(), e.what());
unsupported.push_back(file); // IdentifierResolutionException is not relevant -> not ask to delete, when mods are disabled
logGlobal->error("Error: Failed to process %s: %s", file.getName(), e.what());
}
}
return unsupported;
}
void SelectionTab::handleUnsupportedSavegames(const std::vector<ResourcePath> files)
{
if(CSH->isHost() && files.size())
{
MetaString text = MetaString::createFromTextID("vcmi.lobby.deleteUnsupportedSave");
text.replaceNumber(files.size());
CInfoWindow::showYesNoDialog(text.toString(), std::vector<std::shared_ptr<CComponent>>(), [files](){
for(auto & file : files)
{
LobbyDelete ld;
ld.type = LobbyDelete::SAVEGAME;
ld.name = file.getName();
CSH->sendLobbyPack(ld);
}
}, nullptr);
}
}
void SelectionTab::parseCampaigns(const std::unordered_set<ResourcePath> & files)