games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-03-27 21:49:10 +02:00
Code Issues Releases Activity

Add validation for hero duplicate

Browse Source
This commit is contained in:
nordsoft 2023-04-22 20:08:52 +04:00 committed by Nordsoft91
parent bab84309a5
commit 1de9a57a76
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mapeditor/validator.cpp
View File

@ -74,6 +74,8 @@ std::list<Validator::Issue> Validator::validate(const CMap * map)
if(!hplayers) if(!hplayers)
issues.emplace_back("No human players allowed to play this map", true); issues.emplace_back("No human players allowed to play this map", true);
std::set<CHero*> allHeroesOnMap; //used to find hero duplicated
//checking all objects in the map //checking all objects in the map
for(auto o : map->objects) for(auto o : map->objects)
{ {
@ -121,6 +123,9 @@ std::list<Validator::Issue> Validator::validate(const CMap * map)
{ {
if(!map->allowedHeroes[ins->type->getId().getNum()]) if(!map->allowedHeroes[ins->type->getId().getNum()])
issues.emplace_back(QString("Hero %1 is prohibited by map settings").arg(ins->type->getNameTranslated().c_str()), false); issues.emplace_back(QString("Hero %1 is prohibited by map settings").arg(ins->type->getNameTranslated().c_str()), false);
if(!allHeroesOnMap.insert(ins->type).second)
issues.emplace_back(QString("Hero %1 has duplicate on map").arg(ins->type->getNameTranslated().c_str()), false);
} }
else else
issues.emplace_back(QString("Hero %1 has an empty type and must be removed").arg(ins->instanceName.c_str()), true); issues.emplace_back(QString("Hero %1 has an empty type and must be removed").arg(ins->instanceName.c_str()), true);