games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-12-01 23:12:49 +02:00
Code Issues Releases Activity

Attempt to fix & improve error detection:

Browse Source 
- use std::fstream instead of boost::iostreams for properly working flush
- removed some catch-all blocks
- reduce catch scope of some try/catch blocks to clearly indicate intent
This commit is contained in:
Ivan Savenko
2023-07-24 18:24:23 +03:00
parent a280cc8845
commit 21e794268b
9 changed files with 44 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/mapObjectConstructors/AObjectTypeHandler.cpp
View File

@@ -77,15 +77,8 @@ void AObjectTypeHandler::init(const JsonNode & input)
tmpl->id = Obj(type);
tmpl->subid = subtype;
tmpl->stringID = entry.first; // FIXME: create "fullID" - type.object.template?
try
{
tmpl->readJson(entry.second);
templates.push_back(std::shared_ptr<const ObjectTemplate>(tmpl));
}
catch (const std::exception & e)
{
logGlobal->warn("Failed to load terrains for object %s: %s", entry.first, e.what());
}
tmpl->readJson(entry.second);
templates.push_back(std::shared_ptr<const ObjectTemplate>(tmpl));
}
for(const JsonNode & node : input["sounds"]["ambient"].Vector())