From 289ae8a1f8c2a8b83331bc43dbcf749d811cdff5 Mon Sep 17 00:00:00 2001
From: nordsoft <nordsoft@rambler.ru>
Date: Wed, 7 Sep 2022 04:20:02 +0400
Subject: [PATCH] Fix terrain performance

---
 lib/Terrain.cpp | 29 +++++++++++++++++------------
 lib/Terrain.h   |  5 ++++-
 2 files changed, 21 insertions(+), 13 deletions(-)

diff --git a/lib/Terrain.cpp b/lib/Terrain.cpp
index 9c2073914..142355961 100644
--- a/lib/Terrain.cpp
+++ b/lib/Terrain.cpp
@@ -154,6 +154,11 @@ Terrain::Manager::Manager()
 			}
 			
 			terrainInfo[terr.first] = info;
+			if(!terrainId.count(terr.first))
+			{
+				terrainId[terr.first] = terrainVault.size();
+				terrainVault.push_back(terr.first);
+			}
 		}
 	}
 }
@@ -164,12 +169,18 @@ Terrain::Manager & Terrain::Manager::get()
 	return manager;
 }
 
-std::vector<Terrain> Terrain::Manager::terrains()
+const std::vector<Terrain> & Terrain::Manager::terrains()
 {
-	std::set<Terrain> _terrains; //have to use std::set to have ordered container. Othervise de-sync is possible
-	for(const auto & info : Terrain::Manager::get().terrainInfo)
-		_terrains.insert(info.first);
-	return std::vector<Terrain>(_terrains.begin(), _terrains.end());
+	return Terrain::Manager::get().terrainVault;
+}
+
+int Terrain::Manager::id(const Terrain & terrain)
+{
+	if(terrain.name == "ANY") return -3;
+	if(terrain.name == "WRONG") return -2;
+	if(terrain.name == "BORDER") return -1;
+	
+	return Terrain::Manager::get().terrainId.at(terrain);
 }
 
 const Terrain::Info & Terrain::Manager::getInfo(const Terrain & terrain)
@@ -219,13 +230,7 @@ bool operator<(const Terrain & l, const Terrain & r)
 	
 int Terrain::id() const
 {
-	if(name == "ANY") return -3;
-	if(name == "WRONG") return -2;
-	if(name == "BORDER") return -1;
-	
-	auto _terrains = Terrain::Manager::terrains();
-	auto iter = std::find(_terrains.begin(), _terrains.end(), *this);
-	return iter - _terrains.begin();
+	return Terrain::Manager::id(*this);
 }
 	
 bool Terrain::isLand() const
diff --git a/lib/Terrain.h b/lib/Terrain.h
index 2f20f12f4..d270090e5 100644
--- a/lib/Terrain.h
+++ b/lib/Terrain.h
@@ -48,14 +48,17 @@ public:
 	class DLL_LINKAGE Manager
 	{
 	public:
-		static std::vector<Terrain> terrains();
+		static const std::vector<Terrain> & terrains();
 		static const Info & getInfo(const Terrain &);
+		static int id(const Terrain &);
 		
 	private:
 		static Manager & get();
 		Manager();
 		
 		std::unordered_map<std::string, Info> terrainInfo;
+		std::vector<Terrain> terrainVault;
+		std::map<Terrain, int> terrainId;
 	};
 	
 	/*enum EETerrainType