games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-29 23:07:48 +02:00
Code Issues Releases Activity

fix: skip pass and priority pass if hero is not valid anymore to as extra checks for lost heroes

Browse Source
This commit is contained in:
Mircea TheHonestCTO
2025-09-04 00:56:36 +02:00
parent 7a40981a95
commit 2e49d6aca9
9 changed files with 37 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
AI/Nullkiller2/AIUtility.cpp
View File

@@ -95,14 +95,14 @@ const CGHeroInstance * HeroPtr::getUnverified() const
return hero;
}
bool HeroPtr::verify() const
bool HeroPtr::verify(const bool verbose) const
{
// TODO: check if these all assertions every time we get info about hero affect efficiency
// behave terribly when attempting unauthorized access to hero that is not ours (or was lost)
if(hero)
{
const auto *obj = cpsic->getObj(hero->id);
const auto *obj = cpsic->getObj(hero->id, verbose);
//const bool owned = obj && obj->tempOwner == ai->playerID;
if(!obj)
@@ -123,9 +123,9 @@ const CGHeroInstance * HeroPtr::operator->() const
}
// Should be called before using the hero inside this HeroPtr, that's the point of this
bool HeroPtr::isVerified() const
bool HeroPtr::isVerified(const bool verbose) const
{
return verify();
return verify(verbose);
}
// enforces isVerified()