games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-03-25 21:38:59 +02:00
Code Issues Releases Activity

Remove no longer needed (and incomplete) explicit target existence check

Browse Source
This commit is contained in:
AlexVinS 2015-04-03 03:36:10 +03:00
parent 6356247108
commit 46e7a0f829
2 changed files with 0 additions and 19 deletions

18
lib/spells/BattleSpellMechanics.cpp

@ -178,24 +178,6 @@ void DispellMechanics::applyBattle(BattleInfo * battle, const BattleSpellCast *
}
}
ESpellCastProblem::ESpellCastProblem DispellMechanics::canBeCasted(const CBattleInfoCallback * cb, PlayerColor player) const
{
//todo: check for lower level
std::stringstream cachingStr;
cachingStr << "source_" << Bonus::SPELL_EFFECT;
for(const CStack * s : cb->battleAliveStacks())
{
if(s->hasBonus(Selector::sourceType(Bonus::SPELL_EFFECT), cachingStr.str()))
{
return ESpellCastProblem::OK;
}
}
return ESpellCastProblem::NO_APPROPRIATE_TARGET;
}
ESpellCastProblem::ESpellCastProblem DispellMechanics::isImmuneByStack(const CGHeroInstance * caster, const CStack * obj) const
{
//DISPELL ignores all immunities, so do not call default

1
lib/spells/BattleSpellMechanics.h

@ -51,7 +51,6 @@ public:
ESpellCastProblem::ESpellCastProblem isImmuneByStack(const CGHeroInstance * caster, const CStack * obj) const override;
void applyBattle(BattleInfo * battle, const BattleSpellCast * packet) const override final;
ESpellCastProblem::ESpellCastProblem canBeCasted(const CBattleInfoCallback * cb, PlayerColor player) const override;
protected:
void applyBattleEffects(const SpellCastEnvironment * env, BattleSpellCastParameters & parameters, SpellCastContext & ctx) const override;
};