games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-06-21 00:19:29 +02:00
Code Issues Releases Activity

Fixes for code review issues

Browse Source
This commit is contained in:
AlexVinS
2021-02-20 04:57:50 +03:00
parent 784f6b973b
commit 483a4689ce
18 changed files with 196 additions and 209 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/ScriptHandler.cpp
View File

@ -121,7 +121,7 @@ void ScriptImpl::resolveHost()
else if(sourcePathId.getType() == EResType::LUA)
host = owner->lua;
else
throw std::runtime_error("Unknown script language in:"+sourcePath);
throw std::runtime_error("Unknown script language in:" + sourcePath);
}
PoolImpl::PoolImpl(const Environment * ENV)
@ -217,7 +217,8 @@ std::vector<JsonNode> ScriptHandler::loadLegacyData(size_t dataSize)
return std::vector<JsonNode>();
}
ScriptPtr ScriptHandler::loadFromJson(vstd::CLoggerBase * logger, const std::string & scope, const JsonNode & json, const std::string & identifier) const
ScriptPtr ScriptHandler::loadFromJson(vstd::CLoggerBase * logger, const std::string & scope,
const JsonNode & json, const std::string & identifier) const
{
ScriptPtr ret = std::make_shared<ScriptImpl>(this);