games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-07-01 00:45:26 +02:00
Code Issues Releases Activity

Changes for BattleInterface classes according to code review:

Browse Source 
- added documentation comments for classes, members and methods
- added const specifier to methods where applicable
- renamed some methods with more clear name
- removed some commented-out or unused code
This commit is contained in:
Ivan Savenko
2022-12-11 23:16:23 +02:00
parent 7f5e5259c8
commit 49a6d056d9
25 changed files with 227 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
client/battle/BattleStacksController.cpp
View File

@ -1,5 +1,5 @@
/*
* CBattleStacksController.cpp, part of VCMI engine
* BattleStacksController.cpp, part of VCMI engine
*
* Authors: listed in file AUTHORS in main folder
*
@ -435,7 +435,7 @@ void BattleStacksController::stackAttacking( const CStack *attacker, BattleHex d
//waitForAnims();
}
bool BattleStacksController::shouldRotate(const CStack * stack, const BattleHex & oldPos, const BattleHex & nextHex)
bool BattleStacksController::shouldRotate(const CStack * stack, const BattleHex & oldPos, const BattleHex & nextHex) const
{
Point begPosition = getStackPositionAtHex(oldPos,stack);
Point endPosition = getStackPositionAtHex(nextHex, stack);
@ -528,19 +528,19 @@ void BattleStacksController::setSelectedStack(const CStack *stack)
selectedStack = stack;
}
const CStack* BattleStacksController::getSelectedStack()
const CStack* BattleStacksController::getSelectedStack() const
{
return selectedStack;
}
const CStack* BattleStacksController::getActiveStack()
const CStack* BattleStacksController::getActiveStack() const
{
return activeStack;
}
bool BattleStacksController::facingRight(const CStack * stack)
bool BattleStacksController::facingRight(const CStack * stack) const
{
return stackFacingRight[stack->ID];
return stackFacingRight.at(stack->ID);
}
bool BattleStacksController::activeStackSpellcaster()
@ -555,7 +555,7 @@ SpellID BattleStacksController::activeStackSpellToCast()
return SpellID(creatureSpellToCast);
}
Point BattleStacksController::getStackPositionAtHex(BattleHex hexNum, const CStack * stack)
Point BattleStacksController::getStackPositionAtHex(BattleHex hexNum, const CStack * stack) const
{
Point ret(-500, -500); //returned value
if(stack && stack->initialPosition < 0) //creatures in turrets