games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-25 22:42:04 +02:00
Code Issues Releases Activity

Fix issues detected by Sonar

Browse Source
This commit is contained in:
Ivan Savenko
2025-05-05 16:05:59 +03:00
parent cb5295b9ec
commit 4b30336d03
37 changed files with 94 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/constants/StringConstants.h
View File

@@ -19,7 +19,7 @@ VCMI_LIB_NAMESPACE_BEGIN
namespace GameConstants
{
const std::string RESOURCE_NAMES [RESOURCE_QUANTITY] = {
"wood", "mercury", "ore", "sulfur", "crystal", "gems", "gold", "mithril"
"wood", "mercury", "ore", "sulfur", "crystal", "gems", "gold", "mithril"
};
const std::string PLAYER_COLOR_NAMES [PlayerColor::PLAYER_LIMIT_I] = {
@@ -50,7 +50,7 @@ namespace NSecondarySkill
const std::vector<std::string> levels =
{
"none", "basic", "advanced", "expert"
"none", "basic", "advanced", "expert"
};
}
@@ -83,7 +83,7 @@ namespace NFaction
namespace NArtifactPosition
{
const std::string namesHero [19] =
inline constexpr std::array namesHero =
{
"head", "shoulders", "neck", "rightHand", "leftHand", "torso", //5
"rightRing", "leftRing", "feet", //8
@@ -92,12 +92,12 @@ namespace NArtifactPosition
"spellbook", "misc5" //18
};
const std::string namesCreature[1] =
inline constexpr std::array namesCreature =
{
"creature1"
};
const std::string namesCommander[6] =
inline constexpr std::array namesCommander =
{
"commander1", "commander2", "commander3", "commander4", "commander5", "commander6",
};
@@ -110,10 +110,10 @@ namespace NMetaclass
{
const std::string names [16] =
{
"",
"artifact", "creature", "faction", "experience", "hero",
"heroClass", "luck", "mana", "morale", "movement",
"object", "primarySkill", "secondarySkill", "spell", "resource"
"",
"artifact", "creature", "faction", "experience", "hero",
"heroClass", "luck", "mana", "morale", "movement",
"object", "primarySkill", "secondarySkill", "spell", "resource"
};
}