games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-08-13 19:54:17 +02:00
Code Issues Releases Activity

Suggested tweaks

Browse Source
This commit is contained in:
Tomasz Zieliński
2022-09-14 11:37:12 +02:00
parent d0f857c3c4
commit 55b142a8c9
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/HeroBonus.cpp
View File

@@ -663,7 +663,7 @@ int IBonusBearer::valOfBonuses(Bonus::BonusType type, int subtype) const
//This part is performance-critical
char cachingStr[20] = {};
sprintf(cachingStr, "type_%ds_%d", (int)type, subtype);
std::sprintf(cachingStr, "type_%ds_%d", (int)type, subtype);
CSelector s = Selector::type()(type);
if(subtype != -1)
@@ -693,7 +693,7 @@ bool IBonusBearer::hasBonusOfType(Bonus::BonusType type, int subtype) const
{
//This part is performance-ciritcal
char cachingStr[20] = {};
sprintf(cachingStr, "type_%ds_%d", (int)type, subtype);
std::sprintf(cachingStr, "type_%ds_%d", (int)type, subtype);
CSelector s = Selector::type()(type);
if(subtype != -1)
@@ -975,7 +975,7 @@ void CBonusSystemNode::getAllBonusesRec(BonusList &out) const
}
bonuses.getAllBonuses(beforeUpdate);
for(auto & b : beforeUpdate)
for(const auto & b : beforeUpdate)
{
auto updated = b->updater
? getUpdatedBonus(b, b->updater)

2
lib/int3.h
View File

@@ -160,7 +160,7 @@ public:
{
//Performance is important here
char str[16] = {};
sprintf(str, "(%d %d %d)", x, y, z);
std::sprintf(str, "(%d %d %d)", x, y, z);
return std::string(str);
}