1
0
mirror of https://github.com/vcmi/vcmi.git synced 2024-12-24 22:14:36 +02:00

[launcher] treat manually selected/dropped file as a file path instead of URL

fixes file installation on Android
This commit is contained in:
Andrey Filipenkov 2024-07-08 16:10:44 +03:00
parent a15a191557
commit 5d9c1f986f
2 changed files with 20 additions and 20 deletions

View File

@ -70,9 +70,8 @@ void CModListView::dropEvent(QDropEvent* event)
if(mimeData->hasUrls())
{
const QList<QUrl> urlList = mimeData->urls();
for (const auto & url : urlList)
manualInstallFile(url);
manualInstallFile(url.toLocalFile());
}
}
@ -636,23 +635,21 @@ void CModListView::on_installFromFileButton_clicked()
for (const auto & file : files)
{
QUrl url = QUrl::fromLocalFile(file);
manualInstallFile(url);
manualInstallFile(file);
}
}
void CModListView::manualInstallFile(QUrl url)
void CModListView::manualInstallFile(QString filePath)
{
QString urlStr = url.toString();
QString fileName = url.fileName();
if(urlStr.endsWith(".zip", Qt::CaseInsensitive))
QString fileName = QFileInfo{filePath}.fileName();
if(filePath.endsWith(".zip", Qt::CaseInsensitive))
downloadFile(fileName.toLower()
// mod name currently comes from zip file -> remove suffixes from github zip download
.replace(QRegularExpression("-[0-9a-f]{40}"), "")
.replace(QRegularExpression("-vcmi-.+\\.zip"), ".zip")
.replace("-main.zip", ".zip")
, urlStr, "mods", 0);
else if(urlStr.endsWith(".json", Qt::CaseInsensitive))
, QUrl::fromLocalFile(filePath), "mods");
else if(filePath.endsWith(".json", Qt::CaseInsensitive))
{
QDir configDir(QString::fromStdString(VCMIDirs::get().userConfigPath().string()));
QStringList configFile = configDir.entryList({fileName}, QDir::Filter::Files); // case insensitive check
@ -663,7 +660,7 @@ void CModListView::manualInstallFile(QUrl url)
{
const auto configFilePath = configDir.filePath(configFile[0]);
QFile::remove(configFilePath);
QFile::copy(url.toLocalFile(), configFilePath);
QFile::copy(filePath, configFilePath);
// reload settings
Helper::loadSettings();
@ -676,10 +673,15 @@ void CModListView::manualInstallFile(QUrl url)
}
}
else
downloadFile(fileName, urlStr, fileName, 0);
downloadFile(fileName, QUrl::fromLocalFile(filePath), fileName);
}
void CModListView::downloadFile(QString file, QString url, QString description, qint64 size)
{
downloadFile(file, QUrl{url}, description, size);
}
void CModListView::downloadFile(QString file, QUrl url, QString description, qint64 size)
{
if(!dlManager)
{
@ -696,14 +698,11 @@ void CModListView::downloadFile(QString file, QString url, QString description,
connect(modModel, &CModListModel::dataChanged, filterModel, &QAbstractItemModel::dataChanged);
QString progressBarFormat = tr("Downloading %s%. %p% (%v MB out of %m MB) finished");
progressBarFormat.replace("%s%", description);
const auto progressBarFormat = tr("Downloading %1. %p% (%v MB out of %m MB) finished").arg(description);
ui->progressBar->setFormat(progressBarFormat);
}
dlManager->downloadFile(QUrl(url), file, size);
dlManager->downloadFile(url, file, size);
}
void CModListView::downloadProgress(qint64 current, qint64 max)

View File

@ -51,8 +51,9 @@ class CModListView : public QWidget
// find mods that depend on this one
QStringList findDependentMods(QString mod, bool excludeDisabled);
void manualInstallFile(QUrl url);
void manualInstallFile(QString filePath);
void downloadFile(QString file, QString url, QString description, qint64 size = 0);
void downloadFile(QString file, QUrl url, QString description, qint64 size = 0);
void installMods(QStringList archives);
void installMaps(QStringList maps);