games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-25 22:42:04 +02:00
Code Issues Releases Activity

Fix possibly hanging pointer to deleted CGObjectInstance

Browse Source 
Was stored by CRemoveObjectOperation and accessed on destruction even
though it has been removed by the game
This commit is contained in:
Ivan Savenko
2024-05-13 16:19:14 +00:00
parent f8e4e41c39
commit 62b564650d
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/rmg/CMapGenerator.cpp
View File

@@ -126,6 +126,9 @@ std::unique_ptr<CMap> CMapGenerator::generate()
fillZones(); fillZones();
//updated guarded tiles will be calculated in CGameState::initMapObjects() //updated guarded tiles will be calculated in CGameState::initMapObjects()
map->getZones().clear(); map->getZones().clear();
// undo manager keeps pointers to object that might be removed during gameplay. Remove them to prevent any hanging pointer after gameplay
map->getEditManager()->getUndoManager().clearAll();
} }
catch (rmgException &e) catch (rmgException &e)
{ {