games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-02-13 13:18:43 +02:00
Code Issues Releases Activity

Do not show empty or irrelevant information in mod details tab

Browse Source
This commit is contained in:
Ivan Savenko 2024-11-14 16:55:15 +00:00
parent 065a8d5fcf
commit 75a1a0938f
1 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
launcher/modManager/cmodlistview_moc.cpp
View File

@ -199,11 +199,21 @@ CModListView::~CModListView()
static QString replaceIfNotEmpty(QVariant value, QString pattern)
{
if(value.canConvert<QStringList>())
return pattern.arg(value.toStringList().join(", "));
if(value.canConvert<QString>())
return pattern.arg(value.toString());
{
if (value.toString().isEmpty())
return "";
else
return pattern.arg(value.toString());
}
if(value.canConvert<QStringList>())
{
if (value.toStringList().isEmpty())
return "";
else
return pattern.arg(value.toStringList().join(", "));
}
// all valid types of data should have been filtered by code above
assert(!value.isValid());
@ -264,6 +274,9 @@ QStringList CModListView::getModNames(QStringList input)
auto mod = modStateModel->getMod(modID);
if (mod.isHidden())
continue;
QString displayName = mod.getName();
if (displayName.isEmpty())
displayName = modID.toLower();