games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-29 23:07:48 +02:00
Code Issues Releases Activity

Return string by copy to fix cases when string is constructed on stack

Browse Source
This commit is contained in:
Ivan Savenko
2023-01-01 20:54:05 +02:00
parent 33a9aa8ee5
commit 7c0d5666a0
11 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/CGeneralTextHandler.h
View File

@@ -101,7 +101,7 @@ class DLL_LINKAGE LegacyTextContainer
public:
LegacyTextContainer(CGeneralTextHandler & owner, std::string const & basePath);
const std::string & operator[](size_t index) const;
std::string operator [](size_t index) const;
};
/// Small wrapper that provides help text access API compatible with old code
@@ -166,7 +166,7 @@ public:
/// returns translated version of a string that can be displayed to user
template<typename ... Args>
const std::string & translate(std::string arg1, Args ... args) const
std::string translate(std::string arg1, Args ... args) const
{
TextIdentifier id(arg1, args ...);
return deserialize(id);