From 824aec8416e67dc6b55d414d94b88331c26421bd Mon Sep 17 00:00:00 2001 From: Nordsoft91 Date: Sat, 24 Sep 2022 13:03:46 +0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Andrey Filipenkov --- config/translate.json | 2 +- lib/CModHandler.h | 3 ++- lib/NetPacksLobby.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/config/translate.json b/config/translate.json index 9d12a600b..687c6cf24 100644 --- a/config/translate.json +++ b/config/translate.json @@ -32,7 +32,7 @@ "errors" : { "existingProcess" : "Another vcmiserver process is running, please terminate it first", - "modsIncompatibility" : "Mods are required to load game:" + "modsIncompatibility" : "Required mods to load game:" } }, "systemOptions" : diff --git a/lib/CModHandler.h b/lib/CModHandler.h index d951334d8..70519b174 100644 --- a/lib/CModHandler.h +++ b/lib/CModHandler.h @@ -396,7 +396,8 @@ public: h & newActiveMods; Incompatibility::ModList missingMods; - for(auto & m : newActiveMods) + for(const auto & m : newActiveMods) + { CModInfo::Version mver; h & mver; diff --git a/lib/NetPacksLobby.h b/lib/NetPacksLobby.h index 18e9a5a5c..d2a74a4d9 100644 --- a/lib/NetPacksLobby.h +++ b/lib/NetPacksLobby.h @@ -316,7 +316,7 @@ struct LobbyShowMessage : public CLobbyPackToPropagate void applyOnLobbyScreen(CLobbyScreen * lobby, CServerHandler * handler); - template void serialize(Handler &h, const int version) + template void serialize(Handler & h, const int version) { h & message; }