1
0
mirror of https://github.com/vcmi/vcmi.git synced 2024-12-22 22:13:35 +02:00

Added 'Serializeable' base class for classes serializeable by pointer

This commit is contained in:
Ivan Savenko 2024-05-07 19:17:05 +00:00
parent cce3f1cb2d
commit 84bc6c42db
42 changed files with 145 additions and 79 deletions

View File

@ -206,6 +206,7 @@ public:
template<typename Handler> void serializeInternal(Handler & h) template<typename Handler> void serializeInternal(Handler & h)
{ {
#if 0
h & nullkiller->memory->knownTeleportChannels; h & nullkiller->memory->knownTeleportChannels;
h & nullkiller->memory->knownSubterraneanGates; h & nullkiller->memory->knownSubterraneanGates;
h & destinationTeleport; h & destinationTeleport;
@ -213,6 +214,7 @@ public:
h & nullkiller->memory->alreadyVisited; h & nullkiller->memory->alreadyVisited;
h & status; h & status;
h & battlename; h & battlename;
#endif
} }
}; };

View File

@ -53,7 +53,7 @@ namespace Goals
{ {
int3 tile = int3(0, 0, ourPos.z); int3 tile = int3(0, 0, ourPos.z);
const auto & slice = (*(ts->fogOfWarMap))[ourPos.z]; const auto & slice = ts->fogOfWarMap[ourPos.z];
for(tile.x = ourPos.x - scanRadius; tile.x <= ourPos.x + scanRadius; tile.x++) for(tile.x = ourPos.x - scanRadius; tile.x <= ourPos.x + scanRadius; tile.x++)
{ {
@ -81,13 +81,13 @@ namespace Goals
foreach_tile_pos([&](const int3 & pos) foreach_tile_pos([&](const int3 & pos)
{ {
if((*(ts->fogOfWarMap))[pos.z][pos.x][pos.y]) if(ts->fogOfWarMap[pos.z][pos.x][pos.y])
{ {
bool hasInvisibleNeighbor = false; bool hasInvisibleNeighbor = false;
foreach_neighbour(cbp, pos, [&](CCallback * cbp, int3 neighbour) foreach_neighbour(cbp, pos, [&](CCallback * cbp, int3 neighbour)
{ {
if(!(*(ts->fogOfWarMap))[neighbour.z][neighbour.x][neighbour.y]) if(!ts->fogOfWarMap[neighbour.z][neighbour.x][neighbour.y])
{ {
hasInvisibleNeighbor = true; hasInvisibleNeighbor = true;
} }
@ -171,7 +171,7 @@ namespace Goals
{ {
foreach_neighbour(cbp, tile, [&](CCallback * cbp, int3 neighbour) foreach_neighbour(cbp, tile, [&](CCallback * cbp, int3 neighbour)
{ {
if((*(ts->fogOfWarMap))[neighbour.z][neighbour.x][neighbour.y]) if(ts->fogOfWarMap[neighbour.z][neighbour.x][neighbour.y])
{ {
out.push_back(neighbour); out.push_back(neighbour);
} }
@ -184,7 +184,7 @@ namespace Goals
int ret = 0; int ret = 0;
int3 npos = int3(0, 0, pos.z); int3 npos = int3(0, 0, pos.z);
const auto & slice = (*(ts->fogOfWarMap))[pos.z]; const auto & slice = ts->fogOfWarMap[pos.z];
for(npos.x = pos.x - sightRadius; npos.x <= pos.x + sightRadius; npos.x++) for(npos.x = pos.x - sightRadius; npos.x <= pos.x + sightRadius; npos.x++)
{ {

View File

@ -303,6 +303,8 @@ public:
template<typename Handler> void serializeInternal(Handler & h) template<typename Handler> void serializeInternal(Handler & h)
{ {
#if 0
// serialization of client-side data is broken and not performed at the moment
h & knownTeleportChannels; h & knownTeleportChannels;
h & knownSubterraneanGates; h & knownSubterraneanGates;
h & destinationTeleport; h & destinationTeleport;
@ -358,6 +360,7 @@ public:
h & heroesUnableToExplore; h & heroesUnableToExplore;
//myCB is restored after load by init call //myCB is restored after load by init call
#endif
} }
}; };

View File

@ -16,6 +16,7 @@
#include "bonuses/CBonusSystemNode.h" #include "bonuses/CBonusSystemNode.h"
#include "GameConstants.h" #include "GameConstants.h"
#include "IHandlerBase.h" #include "IHandlerBase.h"
#include "serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -187,7 +188,7 @@ struct DLL_LINKAGE ArtSlotInfo
} }
}; };
class DLL_LINKAGE CArtifactSet class DLL_LINKAGE CArtifactSet : public virtual Serializeable
{ {
public: public:
using ArtPlacementMap = std::map<CArtifactInstance*, ArtifactPosition>; using ArtPlacementMap = std::map<CArtifactInstance*, ArtifactPosition>;

View File

@ -11,6 +11,7 @@
#include "bonuses/Bonus.h" #include "bonuses/Bonus.h"
#include "bonuses/CBonusSystemNode.h" #include "bonuses/CBonusSystemNode.h"
#include "serializer/Serializeable.h"
#include "GameConstants.h" #include "GameConstants.h"
#include "CArtHandler.h" #include "CArtHandler.h"
#include "CArtifactInstance.h" #include "CArtifactInstance.h"
@ -208,7 +209,7 @@ namespace NArmyFormation
static const std::vector<std::string> names{ "wide", "tight" }; static const std::vector<std::string> names{ "wide", "tight" };
} }
class DLL_LINKAGE CCreatureSet : public IArmyDescriptor //seven combined creatures class DLL_LINKAGE CCreatureSet : public IArmyDescriptor, public virtual Serializeable //seven combined creatures
{ {
CCreatureSet(const CCreatureSet &) = delete; CCreatureSet(const CCreatureSet &) = delete;
CCreatureSet &operator=(const CCreatureSet&); CCreatureSet &operator=(const CCreatureSet&);

View File

@ -553,7 +553,7 @@ std::shared_ptr<const boost::multi_array<TerrainTile*, 3>> CGameInfoCallback::ge
for(tile.x = 0; tile.x < width; tile.x++) for(tile.x = 0; tile.x < width; tile.x++)
for(tile.y = 0; tile.y < height; tile.y++) for(tile.y = 0; tile.y < height; tile.y++)
{ {
if ((*team->fogOfWarMap)[tile.z][tile.x][tile.y]) if (team->fogOfWarMap[tile.z][tile.x][tile.y])
(*ptr)[tile.z][tile.x][tile.y] = &gs->map->getTile(tile); (*ptr)[tile.z][tile.x][tile.y] = &gs->map->getTile(tile);
else else
(*ptr)[tile.z][tile.x][tile.y] = nullptr; (*ptr)[tile.z][tile.x][tile.y] = nullptr;

View File

@ -602,6 +602,7 @@ set(lib_MAIN_HEADERS
serializer/JsonUpdater.h serializer/JsonUpdater.h
serializer/Cast.h serializer/Cast.h
serializer/ESerializationVersion.h serializer/ESerializationVersion.h
serializer/Serializeable.h
spells/AbilityCaster.h spells/AbilityCaster.h
spells/AdventureSpellMechanics.h spells/AdventureSpellMechanics.h

View File

@ -128,7 +128,7 @@ public:
TeamID id; //position in gameState::teams TeamID id; //position in gameState::teams
std::set<PlayerColor> players; // members of this team std::set<PlayerColor> players; // members of this team
//TODO: boost::array, bool if possible //TODO: boost::array, bool if possible
std::unique_ptr<boost::multi_array<ui8, 3>> fogOfWarMap; //[z][x][y] true - visible, false - hidden boost::multi_array<ui8, 3> fogOfWarMap; //[z][x][y] true - visible, false - hidden
TeamState(); TeamState();
@ -136,6 +136,18 @@ public:
{ {
h & id; h & id;
h & players; h & players;
if (h.version < Handler::Version::REMOVE_FOG_OF_WAR_POINTER)
{
struct Helper : public Serializeable
{
void serialize(Handler &h)
{}
};
Helper helper;
auto ptrHelper = &helper;
h & ptrHelper;
}
h & fogOfWarMap; h & fogOfWarMap;
h & static_cast<CBonusSystemNode&>(*this); h & static_cast<CBonusSystemNode&>(*this);
} }

View File

@ -11,6 +11,7 @@
#pragma once #pragma once
#include <vstd/RNG.h> #include <vstd/RNG.h>
#include "serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -27,7 +28,7 @@ using TRandI = std::function<int()>;
/// The random generator randomly generates integers and real numbers("doubles") between /// The random generator randomly generates integers and real numbers("doubles") between
/// a given range. This is a header only class and mainly a wrapper for /// a given range. This is a header only class and mainly a wrapper for
/// convenient usage of the standard random API. An instance of this RNG is not thread safe. /// convenient usage of the standard random API. An instance of this RNG is not thread safe.
class DLL_LINKAGE CRandomGenerator : public vstd::RNG, boost::noncopyable class DLL_LINKAGE CRandomGenerator : public vstd::RNG, boost::noncopyable, public Serializeable
{ {
public: public:
/// Seeds the generator by default with the product of the current time in milliseconds and the /// Seeds the generator by default with the product of the current time in milliseconds and the

View File

@ -103,8 +103,8 @@ void CPrivilegedInfoCallback::getTilesInRange(std::unordered_set<int3> & tiles,
if(distance <= radious) if(distance <= radious)
{ {
if(!player if(!player
|| (mode == ETileVisibility::HIDDEN && (*team->fogOfWarMap)[pos.z][xd][yd] == 0) || (mode == ETileVisibility::HIDDEN && team->fogOfWarMap[pos.z][xd][yd] == 0)
|| (mode == ETileVisibility::REVEALED && (*team->fogOfWarMap)[pos.z][xd][yd] == 1) || (mode == ETileVisibility::REVEALED && team->fogOfWarMap[pos.z][xd][yd] == 1)
) )
tiles.insert(int3(xd,yd,pos.z)); tiles.insert(int3(xd,yd,pos.z));
} }

View File

@ -15,6 +15,7 @@
#include "TurnTimerInfo.h" #include "TurnTimerInfo.h"
#include "ExtraOptionsInfo.h" #include "ExtraOptionsInfo.h"
#include "campaign/CampaignConstants.h" #include "campaign/CampaignConstants.h"
#include "serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -107,7 +108,7 @@ enum class EStartMode : int32_t
}; };
/// Struct which describes the difficulty, the turn time,.. of a heroes match. /// Struct which describes the difficulty, the turn time,.. of a heroes match.
struct DLL_LINKAGE StartInfo struct DLL_LINKAGE StartInfo : public Serializeable
{ {
EStartMode mode; EStartMode mode;
ui8 difficulty; //0=easy; 4=impossible ui8 difficulty; //0=easy; 4=impossible

View File

@ -9,9 +9,11 @@
*/ */
#pragma once #pragma once
#include "BattleHex.h" #include "BattleHex.h"
#include "../constants/EntityIdentifiers.h"
#include "../filesystem/ResourcePath.h" #include "../filesystem/ResourcePath.h"
#include "../networkPacks/BattleChanges.h" #include "../networkPacks/BattleChanges.h"
#include "../constants/EntityIdentifiers.h" #include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -20,7 +22,7 @@ class ObstacleChanges;
class JsonSerializeFormat; class JsonSerializeFormat;
class SpellID; class SpellID;
struct DLL_LINKAGE CObstacleInstance struct DLL_LINKAGE CObstacleInstance : public Serializeable
{ {
enum EObstacleType : ui8 enum EObstacleType : ui8
{ {

View File

@ -13,6 +13,7 @@
#include "BonusCustomTypes.h" #include "BonusCustomTypes.h"
#include "../constants/VariantIdentifier.h" #include "../constants/VariantIdentifier.h"
#include "../constants/EntityIdentifiers.h" #include "../constants/EntityIdentifiers.h"
#include "../serializer/Serializeable.h"
#include "../MetaString.h" #include "../MetaString.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -55,7 +56,7 @@ public:
#define BONUS_TREE_DESERIALIZATION_FIX if(!h.saving && h.smartPointerSerialization) deserializationFix(); #define BONUS_TREE_DESERIALIZATION_FIX if(!h.saving && h.smartPointerSerialization) deserializationFix();
/// Struct for handling bonuses of several types. Can be transferred to any hero /// Struct for handling bonuses of several types. Can be transferred to any hero
struct DLL_LINKAGE Bonus : public std::enable_shared_from_this<Bonus> struct DLL_LINKAGE Bonus : public std::enable_shared_from_this<Bonus>, public Serializeable
{ {
BonusDuration::Type duration = BonusDuration::PERMANENT; //uses BonusDuration values BonusDuration::Type duration = BonusDuration::PERMANENT; //uses BonusDuration values
si16 turnsRemain = 0; //used if duration is N_TURNS, N_DAYS or ONE_WEEK si16 turnsRemain = 0; //used if duration is N_TURNS, N_DAYS or ONE_WEEK

View File

@ -9,11 +9,11 @@
*/ */
#pragma once #pragma once
#include "GameConstants.h"
#include "BonusList.h" #include "BonusList.h"
#include "IBonusBearer.h" #include "IBonusBearer.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
using TNodes = std::set<CBonusSystemNode *>; using TNodes = std::set<CBonusSystemNode *>;
@ -21,7 +21,7 @@ using TCNodes = std::set<const CBonusSystemNode *>;
using TNodesVector = std::vector<CBonusSystemNode *>; using TNodesVector = std::vector<CBonusSystemNode *>;
using TCNodesVector = std::vector<const CBonusSystemNode *>; using TCNodesVector = std::vector<const CBonusSystemNode *>;
class DLL_LINKAGE CBonusSystemNode : public virtual IBonusBearer, public boost::noncopyable class DLL_LINKAGE CBonusSystemNode : public virtual IBonusBearer, public virtual Serializeable, public boost::noncopyable
{ {
public: public:
enum ENodeTypes enum ENodeTypes

View File

@ -10,8 +10,9 @@
#include "Bonus.h" #include "Bonus.h"
#include "../GameConstants.h"
#include "../battle/BattleHex.h" #include "../battle/BattleHex.h"
#include "../serializer/Serializeable.h"
#include "../constants/Enumerations.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -27,7 +28,7 @@ struct BonusLimitationContext
const BonusList & stillUndecided; const BonusList & stillUndecided;
}; };
class DLL_LINKAGE ILimiter class DLL_LINKAGE ILimiter : public Serializeable
{ {
public: public:
enum class EDecision : uint8_t {ACCEPT, DISCARD, NOT_SURE}; enum class EDecision : uint8_t {ACCEPT, DISCARD, NOT_SURE};

View File

@ -12,11 +12,13 @@
#include "Bonus.h" #include "Bonus.h"
#include "CBonusSystemNode.h" #include "CBonusSystemNode.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
extern DLL_LINKAGE const std::map<std::string, TPropagatorPtr> bonusPropagatorMap; extern DLL_LINKAGE const std::map<std::string, TPropagatorPtr> bonusPropagatorMap;
class DLL_LINKAGE IPropagator class DLL_LINKAGE IPropagator : public Serializeable
{ {
public: public:
virtual ~IPropagator() = default; virtual ~IPropagator() = default;

View File

@ -10,6 +10,7 @@
#pragma once #pragma once
#include "Bonus.h" #include "Bonus.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -17,7 +18,7 @@ extern DLL_LINKAGE const std::map<std::string, TUpdaterPtr> bonusUpdaterMap;
// observers for updating bonuses based on certain events (e.g. hero gaining level) // observers for updating bonuses based on certain events (e.g. hero gaining level)
class DLL_LINKAGE IUpdater class DLL_LINKAGE IUpdater : public Serializeable
{ {
public: public:
virtual ~IUpdater() = default; virtual ~IUpdater() = default;

View File

@ -12,6 +12,7 @@
#include "../GameConstants.h" #include "../GameConstants.h"
#include "../MetaString.h" #include "../MetaString.h"
#include "../filesystem/ResourcePath.h" #include "../filesystem/ResourcePath.h"
#include "../serializer/Serializeable.h"
#include "../CGeneralTextHandler.h" #include "../CGeneralTextHandler.h"
#include "CampaignConstants.h" #include "CampaignConstants.h"
#include "CampaignScenarioPrologEpilog.h" #include "CampaignScenarioPrologEpilog.h"
@ -214,7 +215,7 @@ struct DLL_LINKAGE CampaignScenario
}; };
/// Class that represents loaded campaign information /// Class that represents loaded campaign information
class DLL_LINKAGE Campaign : public CampaignHeader class DLL_LINKAGE Campaign : public CampaignHeader, public Serializeable
{ {
friend class CampaignHandler; friend class CampaignHandler;

View File

@ -693,8 +693,8 @@ void CGameState::initFogOfWar()
for(auto & elem : teams) for(auto & elem : teams)
{ {
auto & fow = elem.second.fogOfWarMap; auto & fow = elem.second.fogOfWarMap;
fow->resize(boost::extents[layers][map->width][map->height]); fow.resize(boost::extents[layers][map->width][map->height]);
std::fill(fow->data(), fow->data() + fow->num_elements(), 0); std::fill(fow.data(), fow.data() + fow.num_elements(), 0);
for(CGObjectInstance *obj : map->objects) for(CGObjectInstance *obj : map->objects)
{ {
@ -704,7 +704,7 @@ void CGameState::initFogOfWar()
getTilesInRange(tiles, obj->getSightCenter(), obj->getSightRadius(), ETileVisibility::HIDDEN, obj->tempOwner); getTilesInRange(tiles, obj->getSightCenter(), obj->getSightRadius(), ETileVisibility::HIDDEN, obj->tempOwner);
for(const int3 & tile : tiles) for(const int3 & tile : tiles)
{ {
(*elem.second.fogOfWarMap)[tile.z][tile.x][tile.y] = 1; elem.second.fogOfWarMap[tile.z][tile.x][tile.y] = 1;
} }
} }
} }
@ -1326,7 +1326,7 @@ bool CGameState::isVisible(int3 pos, const std::optional<PlayerColor> & player)
if(player->isSpectator()) if(player->isSpectator())
return true; return true;
return (*getPlayerTeam(*player)->fogOfWarMap)[pos.z][pos.x][pos.y]; return getPlayerTeam(*player)->fogOfWarMap[pos.z][pos.x][pos.y];
} }
bool CGameState::isVisible(const CGObjectInstance * obj, const std::optional<PlayerColor> & player) const bool CGameState::isVisible(const CGObjectInstance * obj, const std::optional<PlayerColor> & player) const
@ -1957,7 +1957,6 @@ bool RumorState::update(int id, int extra)
TeamState::TeamState() TeamState::TeamState()
{ {
setNodeType(TEAM); setNodeType(TEAM);
fogOfWarMap = std::make_unique<boost::multi_array<ui8, 3>>();
} }
CRandomGenerator & CGameState::getRandomGenerator() CRandomGenerator & CGameState::getRandomGenerator()

View File

@ -79,7 +79,7 @@ class BattleInfo;
DLL_LINKAGE std::ostream & operator<<(std::ostream & os, const EVictoryLossCheckResult & victoryLossCheckResult); DLL_LINKAGE std::ostream & operator<<(std::ostream & os, const EVictoryLossCheckResult & victoryLossCheckResult);
class DLL_LINKAGE CGameState : public CNonConstInfoCallback class DLL_LINKAGE CGameState : public CNonConstInfoCallback, public Serializeable
{ {
friend class CGameStateCampaign; friend class CGameStateCampaign;

View File

@ -11,6 +11,7 @@
#include "../GameConstants.h" #include "../GameConstants.h"
#include "../campaign/CampaignConstants.h" #include "../campaign/CampaignConstants.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -28,7 +29,7 @@ struct CampaignHeroReplacement
std::vector<ArtifactPosition> transferrableArtifacts; std::vector<ArtifactPosition> transferrableArtifacts;
}; };
class CGameStateCampaign class CGameStateCampaign : public Serializeable
{ {
CGameState * gameState; CGameState * gameState;

View File

@ -11,6 +11,8 @@
#include "../GameConstants.h" #include "../GameConstants.h"
#include "TavernSlot.h" #include "TavernSlot.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -21,7 +23,7 @@ class CHeroClass;
class CGameState; class CGameState;
class CSimpleArmy; class CSimpleArmy;
class DLL_LINKAGE TavernHeroesPool class DLL_LINKAGE TavernHeroesPool : public Serializeable
{ {
struct TavernSlot struct TavernSlot
{ {

View File

@ -16,10 +16,11 @@
#include "../ResourceSet.h" #include "../ResourceSet.h"
#include "../json/JsonNode.h" #include "../json/JsonNode.h"
#include "../mapObjects/CBank.h" #include "../mapObjects/CBank.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
struct BankConfig struct BankConfig : public Serializeable
{ {
ui32 chance = 0; //chance for this level being chosen ui32 chance = 0; //chance for this level being chosen
std::vector<CStackBasicDescriptor> guards; //creature ID, amount std::vector<CStackBasicDescriptor> guards; //creature ID, amount

View File

@ -10,10 +10,11 @@
#pragma once #pragma once
#include "IObjectInterface.h" #include "IObjectInterface.h"
#include "../bonuses/BonusEnum.h"
#include "../constants/EntityIdentifiers.h" #include "../constants/EntityIdentifiers.h"
#include "../filesystem/ResourcePath.h" #include "../filesystem/ResourcePath.h"
#include "../int3.h" #include "../int3.h"
#include "../bonuses/BonusEnum.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN

View File

@ -12,6 +12,7 @@
#include "CRewardableObject.h" #include "CRewardableObject.h"
#include "../ResourceSet.h" #include "../ResourceSet.h"
#include "../MetaString.h" #include "../MetaString.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -36,7 +37,7 @@ enum class EQuestMission {
HOTA_REACH_DATE = 13, HOTA_REACH_DATE = 13,
}; };
class DLL_LINKAGE CQuest final class DLL_LINKAGE CQuest final : public Serializeable
{ {
public: public:
@ -74,13 +75,13 @@ public:
CQuest(); //TODO: Remove constructor CQuest(); //TODO: Remove constructor
static bool checkMissionArmy(const CQuest * q, const CCreatureSet * army); static bool checkMissionArmy(const CQuest * q, const CCreatureSet * army);
virtual bool checkQuest(const CGHeroInstance * h) const; //determines whether the quest is complete or not bool checkQuest(const CGHeroInstance * h) const; //determines whether the quest is complete or not
virtual void getVisitText(IGameCallback * cb, MetaString &text, std::vector<Component> & components, bool FirstVisit, const CGHeroInstance * h = nullptr) const; void getVisitText(IGameCallback * cb, MetaString &text, std::vector<Component> & components, bool FirstVisit, const CGHeroInstance * h = nullptr) const;
virtual void getCompletionText(IGameCallback * cb, MetaString &text) const; void getCompletionText(IGameCallback * cb, MetaString &text) const;
virtual void getRolloverText (IGameCallback * cb, MetaString &text, bool onHover) const; //hover or quest log entry void getRolloverText (IGameCallback * cb, MetaString &text, bool onHover) const; //hover or quest log entry
virtual void completeQuest(IGameCallback *, const CGHeroInstance * h) const; void completeQuest(IGameCallback *, const CGHeroInstance * h) const;
virtual void addTextReplacements(IGameCallback * cb, MetaString &out, std::vector<Component> & components) const; void addTextReplacements(IGameCallback * cb, MetaString &out, std::vector<Component> & components) const;
virtual void addKillTargetReplacements(MetaString &out) const; void addKillTargetReplacements(MetaString &out) const;
void defineQuestName(); void defineQuestName();
bool operator== (const CQuest & quest) const bool operator== (const CQuest & quest) const
@ -114,7 +115,7 @@ public:
void serializeJson(JsonSerializeFormat & handler, const std::string & fieldName); void serializeJson(JsonSerializeFormat & handler, const std::string & fieldName);
}; };
class DLL_LINKAGE IQuestObject class DLL_LINKAGE IQuestObject : public virtual Serializeable
{ {
public: public:
CQuest * quest = new CQuest(); CQuest * quest = new CQuest();

View File

@ -9,10 +9,11 @@
*/ */
#pragma once #pragma once
#include "../GameCallbackHolder.h"
#include "../constants/EntityIdentifiers.h"
#include "../networkPacks/EInfoWindowMode.h" #include "../networkPacks/EInfoWindowMode.h"
#include "../networkPacks/ObjProperty.h" #include "../networkPacks/ObjProperty.h"
#include "../constants/EntityIdentifiers.h" #include "../serializer/Serializeable.h"
#include "../GameCallbackHolder.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -29,7 +30,7 @@ class int3;
class MetaString; class MetaString;
class PlayerColor; class PlayerColor;
class DLL_LINKAGE IObjectInterface : public GameCallbackHolder class DLL_LINKAGE IObjectInterface : public GameCallbackHolder, public virtual Serializeable
{ {
public: public:
using GameCallbackHolder::GameCallbackHolder; using GameCallbackHolder::GameCallbackHolder;

View File

@ -185,7 +185,7 @@ protected:
void serializeJsonOptions(JsonSerializeFormat & handler) override; void serializeJsonOptions(JsonSerializeFormat & handler) override;
}; };
struct DLL_LINKAGE TeleportChannel struct DLL_LINKAGE TeleportChannel : public Serializeable
{ {
enum EPassability {UNKNOWN, IMPASSABLE, PASSABLE}; enum EPassability {UNKNOWN, IMPASSABLE, PASSABLE};

View File

@ -12,6 +12,7 @@
#include "../GameConstants.h" #include "../GameConstants.h"
#include "../int3.h" #include "../int3.h"
#include "../filesystem/ResourcePath.h" #include "../filesystem/ResourcePath.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -20,7 +21,7 @@ class CLegacyConfigParser;
class JsonNode; class JsonNode;
class int3; class int3;
class DLL_LINKAGE ObjectTemplate class DLL_LINKAGE ObjectTemplate : public Serializeable
{ {
enum EBlockMapBits enum EBlockMapBits
{ {

View File

@ -13,7 +13,8 @@
#include "../constants/EntityIdentifiers.h" #include "../constants/EntityIdentifiers.h"
#include "../constants/Enumerations.h" #include "../constants/Enumerations.h"
#include "../constants/VariantIdentifier.h" #include "../constants/VariantIdentifier.h"
#include "../modding/CModInfo.h" #include "../modding/ModVerificationInfo.h"
#include "../serializer/Serializeable.h"
#include "../LogicalExpression.h" #include "../LogicalExpression.h"
#include "../int3.h" #include "../int3.h"
#include "../MetaString.h" #include "../MetaString.h"
@ -202,7 +203,7 @@ enum class EMapDifficulty : uint8_t
}; };
/// The map header holds information about loss/victory condition,map format, version, players, height, width,... /// The map header holds information about loss/victory condition,map format, version, players, height, width,...
class DLL_LINKAGE CMapHeader class DLL_LINKAGE CMapHeader: public Serializeable
{ {
void setupEvents(); void setupEvents();
public: public:

View File

@ -9,6 +9,8 @@
*/ */
#pragma once #pragma once
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
struct StartInfo; struct StartInfo;
@ -21,7 +23,7 @@ class ResourcePath;
* A class which stores the count of human players and all players, the filename, * A class which stores the count of human players and all players, the filename,
* scenario options, the map header information,... * scenario options, the map header information,...
*/ */
class DLL_LINKAGE CMapInfo class DLL_LINKAGE CMapInfo : public Serializeable
{ {
public: public:
std::unique_ptr<CMapHeader> mapHeader; //may be nullptr if campaign std::unique_ptr<CMapHeader> mapHeader; //may be nullptr if campaign

View File

@ -10,6 +10,7 @@
#pragma once #pragma once
#include "../constants/EntityIdentifiers.h" #include "../constants/EntityIdentifiers.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -18,7 +19,7 @@ class CConnection;
class ICPackVisitor; class ICPackVisitor;
struct DLL_LINKAGE CPack struct DLL_LINKAGE CPack : public Serializeable
{ {
/// Pointer to connection that pack received from /// Pointer to connection that pack received from
/// Only set & used on server /// Only set & used on server

View File

@ -963,7 +963,7 @@ void FoWChange::applyGs(CGameState *gs)
TeamState * team = gs->getPlayerTeam(player); TeamState * team = gs->getPlayerTeam(player);
auto & fogOfWarMap = team->fogOfWarMap; auto & fogOfWarMap = team->fogOfWarMap;
for(const int3 & t : tiles) for(const int3 & t : tiles)
(*fogOfWarMap)[t.z][t.x][t.y] = mode != ETileVisibility::HIDDEN; fogOfWarMap[t.z][t.x][t.y] = mode != ETileVisibility::HIDDEN;
if (mode == ETileVisibility::HIDDEN) //do not hide too much if (mode == ETileVisibility::HIDDEN) //do not hide too much
{ {
@ -986,7 +986,7 @@ void FoWChange::applyGs(CGameState *gs)
} }
} }
for(const int3 & t : tilesRevealed) //probably not the most optimal solution ever for(const int3 & t : tilesRevealed) //probably not the most optimal solution ever
(*fogOfWarMap)[t.z][t.x][t.y] = 1; fogOfWarMap[t.z][t.x][t.y] = 1;
} }
} }
@ -1325,7 +1325,7 @@ void TryMoveHero::applyGs(CGameState *gs)
auto & fogOfWarMap = gs->getPlayerTeam(h->getOwner())->fogOfWarMap; auto & fogOfWarMap = gs->getPlayerTeam(h->getOwner())->fogOfWarMap;
for(const int3 & t : fowRevealed) for(const int3 & t : fowRevealed)
(*fogOfWarMap)[t.z][t.x][t.y] = 1; fogOfWarMap[t.z][t.x][t.y] = 1;
} }
void NewStructures::applyGs(CGameState *gs) void NewStructures::applyGs(CGameState *gs)

View File

@ -19,13 +19,13 @@ VCMI_LIB_NAMESPACE_BEGIN
namespace PathfinderUtil namespace PathfinderUtil
{ {
using FoW = std::unique_ptr<boost::multi_array<ui8, 3>>; using FoW = boost::multi_array<ui8, 3>;
using ELayer = EPathfindingLayer; using ELayer = EPathfindingLayer;
template<EPathfindingLayer::Type layer> template<EPathfindingLayer::Type layer>
EPathAccessibility evaluateAccessibility(const int3 & pos, const TerrainTile & tinfo, const FoW & fow, const PlayerColor player, const CGameState * gs) EPathAccessibility evaluateAccessibility(const int3 & pos, const TerrainTile & tinfo, const FoW & fow, const PlayerColor player, const CGameState * gs)
{ {
if(!(*fow)[pos.z][pos.x][pos.y]) if(!fow[pos.z][pos.x][pos.y])
return EPathAccessibility::BLOCKED; return EPathAccessibility::BLOCKED;
switch(layer) switch(layer)

View File

@ -12,6 +12,7 @@
#include "../GameConstants.h" #include "../GameConstants.h"
#include "../ResourceSet.h" #include "../ResourceSet.h"
#include "../serializer/Serializeable.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -26,7 +27,7 @@ using LimitersList = std::vector<std::shared_ptr<Rewardable::Limiter>>;
/// Limiters of rewards. Rewards will be granted to hero only if he satisfies requirements /// Limiters of rewards. Rewards will be granted to hero only if he satisfies requirements
/// Note: for this is only a test - it won't remove anything from hero (e.g. artifacts or creatures) /// Note: for this is only a test - it won't remove anything from hero (e.g. artifacts or creatures)
struct DLL_LINKAGE Limiter final struct DLL_LINKAGE Limiter final : public Serializeable
{ {
/// day of week, unused if 0, 1-7 will test for current day of week /// day of week, unused if 0, 1-7 will test for current day of week
si32 dayOfWeek; si32 dayOfWeek;

View File

@ -11,6 +11,7 @@
#pragma once #pragma once
#include "../GameConstants.h" #include "../GameConstants.h"
#include "../serializer/Serializeable.h"
#include "CRmgTemplate.h" #include "CRmgTemplate.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -26,7 +27,7 @@ enum class EPlayerType
/// The map gen options class holds values about general map generation settings /// The map gen options class holds values about general map generation settings
/// e.g. the size of the map, the count of players,... /// e.g. the size of the map, the count of players,...
class DLL_LINKAGE CMapGenOptions class DLL_LINKAGE CMapGenOptions : public Serializeable
{ {
public: public:
/// The player settings class maps the player color, starting town and human player flag. /// The player settings class maps the player color, starting town and human player flag.

View File

@ -119,7 +119,7 @@ class DLL_LINKAGE BinaryDeserializer : public CLoaderBase
class IPointerLoader class IPointerLoader
{ {
public: public:
virtual void * loadPtr(CLoaderBase &ar, IGameCallback * cb, ui32 pid) const =0; //data is pointer to the ACTUAL POINTER virtual Serializeable * loadPtr(CLoaderBase &ar, IGameCallback * cb, ui32 pid) const =0; //data is pointer to the ACTUAL POINTER
virtual ~IPointerLoader() = default; virtual ~IPointerLoader() = default;
template<typename Type> static IPointerLoader *getApplier(const Type * t = nullptr) template<typename Type> static IPointerLoader *getApplier(const Type * t = nullptr)
@ -132,7 +132,7 @@ class DLL_LINKAGE BinaryDeserializer : public CLoaderBase
class CPointerLoader : public IPointerLoader class CPointerLoader : public IPointerLoader
{ {
public: public:
void * loadPtr(CLoaderBase &ar, IGameCallback * cb, ui32 pid) const override //data is pointer to the ACTUAL POINTER Serializeable * loadPtr(CLoaderBase &ar, IGameCallback * cb, ui32 pid) const override //data is pointer to the ACTUAL POINTER
{ {
auto & s = static_cast<BinaryDeserializer &>(ar); auto & s = static_cast<BinaryDeserializer &>(ar);
@ -142,7 +142,7 @@ class DLL_LINKAGE BinaryDeserializer : public CLoaderBase
ptr->serialize(s); ptr->serialize(s);
return static_cast<void*>(ptr); return static_cast<Serializeable*>(ptr);
} }
}; };
@ -157,8 +157,8 @@ public:
Version version; Version version;
std::vector<std::string> loadedStrings; std::vector<std::string> loadedStrings;
std::map<ui32, void*> loadedPointers; std::map<ui32, Serializeable*> loadedPointers;
std::map<const void*, std::shared_ptr<void>> loadedSharedPointers; std::map<const Serializeable*, std::shared_ptr<Serializeable>> loadedSharedPointers;
IGameCallback * cb = nullptr; IGameCallback * cb = nullptr;
bool smartPointerSerialization; bool smartPointerSerialization;
bool saving; bool saving;
@ -355,7 +355,7 @@ public:
{ {
// We already got this pointer // We already got this pointer
// Cast it in case we are loading it to a non-first base pointer // Cast it in case we are loading it to a non-first base pointer
data = static_cast<T>(i->second); data = dynamic_cast<T>(i->second);
return; return;
} }
} }
@ -380,15 +380,15 @@ public:
data = nullptr; data = nullptr;
return; return;
} }
data = static_cast<T>(app->loadPtr(*this, cb, pid)); data = dynamic_cast<T>(app->loadPtr(*this, cb, pid));
} }
} }
template <typename T> template <typename T>
void ptrAllocated(const T *ptr, ui32 pid) void ptrAllocated(T *ptr, ui32 pid)
{ {
if(smartPointerSerialization && pid != 0xffffffff) if(smartPointerSerialization && pid != 0xffffffff)
loadedPointers[pid] = (void*)ptr; //add loaded pointer to our lookup map; cast is to avoid errors with const T* pt loadedPointers[pid] = const_cast<Serializeable*>(dynamic_cast<const Serializeable*>(ptr)); //add loaded pointer to our lookup map; cast is to avoid errors with const T* pt
} }
template<typename Base, typename Derived> void registerType(const Base * b = nullptr, const Derived * d = nullptr) template<typename Base, typename Derived> void registerType(const Base * b = nullptr, const Derived * d = nullptr)
@ -403,7 +403,7 @@ public:
NonConstT *internalPtr; NonConstT *internalPtr;
load(internalPtr); load(internalPtr);
void * internalPtrDerived = static_cast<void*>(internalPtr); Serializeable * internalPtrDerived = static_cast<Serializeable*>(internalPtr);
if(internalPtr) if(internalPtr)
{ {
@ -418,7 +418,7 @@ public:
{ {
auto hlp = std::shared_ptr<NonConstT>(internalPtr); auto hlp = std::shared_ptr<NonConstT>(internalPtr);
data = hlp; data = hlp;
loadedSharedPointers[internalPtrDerived] = std::static_pointer_cast<void>(hlp); loadedSharedPointers[internalPtrDerived] = std::static_pointer_cast<Serializeable>(hlp);
} }
} }
else else

View File

@ -12,6 +12,7 @@
#include "CSerializer.h" #include "CSerializer.h"
#include "CTypeList.h" #include "CTypeList.h"
#include "ESerializationVersion.h" #include "ESerializationVersion.h"
#include "Serializeable.h"
#include "../mapObjects/CArmedInstance.h" #include "../mapObjects/CArmedInstance.h"
VCMI_LIB_NAMESPACE_BEGIN VCMI_LIB_NAMESPACE_BEGIN
@ -114,7 +115,7 @@ public:
using Version = ESerializationVersion; using Version = ESerializationVersion;
std::map<std::string, uint32_t> savedStrings; std::map<std::string, uint32_t> savedStrings;
std::map<const void*, ui32> savedPointers; std::map<const Serializeable*, ui32> savedPointers;
const Version version = Version::CURRENT; const Version version = Version::CURRENT;
bool smartPointerSerialization; bool smartPointerSerialization;
@ -268,7 +269,7 @@ public:
{ {
// We might have an object that has multiple inheritance and store it via the non-first base pointer. // We might have an object that has multiple inheritance and store it via the non-first base pointer.
// Therefore, all pointers need to be normalized to the actual object address. // Therefore, all pointers need to be normalized to the actual object address.
const void * actualPointer = static_cast<const void*>(data); const Serializeable * actualPointer = static_cast<const Serializeable*>(data);
auto i = savedPointers.find(actualPointer); auto i = savedPointers.find(actualPointer);
if(i != savedPointers.end()) if(i != savedPointers.end())
{ {

View File

@ -46,6 +46,7 @@ enum class ESerializationVersion : int32_t
COMPACT_STRING_SERIALIZATION, COMPACT_STRING_SERIALIZATION,
COMPACT_INTEGER_SERIALIZATION, COMPACT_INTEGER_SERIALIZATION,
REMOVE_FOG_OF_WAR_POINTER,
CURRENT = COMPACT_INTEGER_SERIALIZATION CURRENT = REMOVE_FOG_OF_WAR_POINTER
}; };

View File

@ -0,0 +1,21 @@
/*
* Serializeable.h, part of VCMI engine
*
* Authors: listed in file AUTHORS in main folder
*
* License: GNU General Public License v2.0 or later
* Full text of license available in license.txt file, in main folder
*
*/
#pragma once
VCMI_LIB_NAMESPACE_BEGIN
// Tag class that acts as base for all classes that can be serialized by pointer
class Serializeable
{
public:
virtual ~Serializeable() = default;
};
VCMI_LIB_NAMESPACE_END

View File

@ -735,7 +735,7 @@ ESpellCastResult ViewMechanics::applyAdventureEffects(SpellCastEnvironment * env
{ {
ObjectPosInfo posInfo(obj); ObjectPosInfo posInfo(obj);
if((*fowMap)[posInfo.pos.z][posInfo.pos.x][posInfo.pos.y] == 0) if(fowMap[posInfo.pos.z][posInfo.pos.x][posInfo.pos.y] == 0)
pack.objectPositions.push_back(posInfo); pack.objectPositions.push_back(posInfo);
} }
} }

View File

@ -884,11 +884,11 @@ void CGameHandler::onNewTurn()
// find all hidden tiles // find all hidden tiles
const auto & fow = getPlayerTeam(player)->fogOfWarMap; const auto & fow = getPlayerTeam(player)->fogOfWarMap;
auto shape = fow->shape(); auto shape = fow.shape();
for(size_t z = 0; z < shape[0]; z++) for(size_t z = 0; z < shape[0]; z++)
for(size_t x = 0; x < shape[1]; x++) for(size_t x = 0; x < shape[1]; x++)
for(size_t y = 0; y < shape[2]; y++) for(size_t y = 0; y < shape[2]; y++)
if (!(*fow)[z][x][y]) if (!fow[z][x][y])
fw.tiles.insert(int3(x, y, z)); fw.tiles.insert(int3(x, y, z));
sendAndApply (&fw); sendAndApply (&fw);

View File

@ -367,7 +367,7 @@ void PlayerMessageProcessor::cheatMapReveal(PlayerColor player, bool reveal)
for(int z = 0; z < mapSize.z; z++) for(int z = 0; z < mapSize.z; z++)
for(int x = 0; x < mapSize.x; x++) for(int x = 0; x < mapSize.x; x++)
for(int y = 0; y < mapSize.y; y++) for(int y = 0; y < mapSize.y; y++)
if(!(*fowMap)[z][x][y] || fc.mode == ETileVisibility::HIDDEN) if(!fowMap[z][x][y] || fc.mode == ETileVisibility::HIDDEN)
hlp_tab[lastUnc++] = int3(x, y, z); hlp_tab[lastUnc++] = int3(x, y, z);
fc.tiles.insert(hlp_tab, hlp_tab + lastUnc); fc.tiles.insert(hlp_tab, hlp_tab + lastUnc);